From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010026.outbound.protection.outlook.com [52.101.56.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2179019AD8B for ; Tue, 17 Mar 2026 02:29:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.26 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773714594; cv=fail; b=jvqPiu1qB49hp4kmhGiNg9TgH/HK9o8flgAT9g9E+QKboXyVdcx4AjLCtzGMbCqKI7tlj54Gn+SygEek6xjzxzzWvIdu3Zpwe7IqrXKBQQVaEvYSLq7YXEHo/53Rhjm5GPXHCpKGjB9TKjjdtneUK2H9MYsFxLb3F7GvPKWoTAI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773714594; c=relaxed/simple; bh=M7g/mfwxvdoq6MjIsGnFJwqFYake0P5s8J1548L/a/U=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Tod25xmUoxgAkXBHvfTMo2+oCT2fPP/rPQ2Ev6POfclBrPhJVVJzyleAODF/xsj/WvOD/P+pr2uOTZt48I5ULKdmDd5TVtIl1Xq1TUN2wATq7RaYCTUduC3vkvm42dtUCMyxmT9bGfnDGv/bfkcEXGLWObJh9nCci2rfbLYl4jU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=NdGzbWsP; arc=fail smtp.client-ip=52.101.56.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="NdGzbWsP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AsQeVK8wclfrlQeqmMs8S7lNycaREAvC1kl0cQR1UgKN1vndWhgofMuIdESKalHllEX1xxtB29CCt7aEmfpWsdyKST2hqD6moP4WoQfOnQKNNVyLyjOXFPjMkfCthi7VPPXcaPg09mnvhhfWtgUgjeZYnWTa6ffUzZyOFSsSf1tAs8Aabx/09Wofs3HkL67Z6Jtz8TqsdCesJC2fmxkmmAOl+78AFvSvxbmw0BB1o0rQncWt8QZPAOxz6b/EhhvsmJrDYA2NkgtpUFbcOcvoUCueeOc8Qeo8bh6+vP+gL9485sQnw3QYwIJ0SifuUPOHBr78FR+K4YlNV36FcID2/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qa6dYIG/iui/DRLL7an+U//olpIWVvuUKpNsuazFo6M=; b=o2jD2kLzPqnNP3IfLLNzykH7plHPp271qOOVD4xJ4ZnOpswE0AT86E47RlfRfHgdYFXqytkLr6BCPU9hvh3Y/VWhTgMVIO9cpZP+fw5R/jsZMt5M/etU/z84qe3u0+rQlhRWiYlcHkGnQ/hCsqVcr1wLuHAxqoB9xmOr1/H70MUkmZ5o5FwPZgJmasaheB/i7Qzv8K7PccHJMUv0U+fMqYg+MXBpe5xhZh9aW/wSf2e0ooZ2Mo/jZFJ5SZHzPwSyHYc/WQxECTUf8TUdVULQagB/g/7DJb+plyJL7pVO+RARi5ppK0z8x9bidytQb2L4U/gkQcj3wvphntftByH4ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=google.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qa6dYIG/iui/DRLL7an+U//olpIWVvuUKpNsuazFo6M=; b=NdGzbWsPJf0P3A5ulBT7dCd+phzA5PTQ0p1sSGd0eTe8rnSHpFgLDSX8ptXhgV650n1wnMQDoWXOjX5qpYl+Guk0+FWpDcPzOSLK/s0p614U1fmx0zZbAza4WAjuE056SyNIpqQq6IjOGnMgFfks10PPfc+m+loahMIZoWH0xGw= Received: from BN0PR04CA0130.namprd04.prod.outlook.com (2603:10b6:408:ed::15) by LV8PR12MB9134.namprd12.prod.outlook.com (2603:10b6:408:180::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.19; Tue, 17 Mar 2026 02:29:47 +0000 Received: from BN1PEPF00004681.namprd03.prod.outlook.com (2603:10b6:408:ed:cafe::b3) by BN0PR04CA0130.outlook.office365.com (2603:10b6:408:ed::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9700.25 via Frontend Transport; Tue, 17 Mar 2026 02:29:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BN1PEPF00004681.mail.protection.outlook.com (10.167.243.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.17 via Frontend Transport; Tue, 17 Mar 2026 02:29:47 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 16 Mar 2026 21:29:47 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 16 Mar 2026 19:29:47 -0700 Received: from [10.136.37.230] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Mon, 16 Mar 2026 21:29:41 -0500 Message-ID: <58ac67d7-649f-426b-9e8f-ace8d5d88e94@amd.com> Date: Tue, 17 Mar 2026 07:59:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v25 8/9] sched: Move attach_one_task and attach_task helpers to sched.h To: John Stultz CC: LKML , Joel Fernandes , Qais Yousef , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Valentin Schneider , Steven Rostedt , Ben Segall , Zimuzo Ezeozue , Mel Gorman , Will Deacon , Waiman Long , Boqun Feng , "Paul E. McKenney" , Metin Kaya , Xuewen Yan , Thomas Gleixner , "Daniel Lezcano" , Suleiman Souhlal , kuyo chang , hupu , References: <20260313023022.2902479-1-jstultz@google.com> <20260313023022.2902479-9-jstultz@google.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF00004681:EE_|LV8PR12MB9134:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ecde225-0e44-4024-5e5b-08de83cd0f30 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|82310400026|376014|7416014|18002099003|56012099003|22082099003|13003099007; X-Microsoft-Antispam-Message-Info: jOZZF9BILsIcrO0YcAO7pTqbBh8p7QKJsT/v3R27abq9kH7Sso2+sZE9XXT1kJ1hhwVPLQHJJvDMv1LWRM6yul1XO5dSp7roALvTCAYQGPgHBtZiX1IZDdGU9SvKR1nJ3puviJ1nwPE+pWcxf3li0zAgtmUJ0kNrwCSVcOey/hhC9lVZMgM0hVP/q5Gib+XTDu5W99PvbsljWU5XuCSzT5zHiayE2ZF+0KmMNdJTWwJsn6fzUQDUKGfJJYTGBOXT3NBOUNsZKNb+0SePiUITUdjaphFl9rD71E6uUhv2GLDCi7SbUF2YvC7HrAH/YkucirgfGE6Uxoxe4cfSdEJ4nB8D69FOybyuDOOPpM5/TN3GMzkMUq8ec2aLefSTx/21RymTlsSxAiblzuhM7gFJtGG5s3GpSoDAGOHQqQ/t0cbuAwAzJ6Tm8UZYRw6M9QI/CSeXk8Mm+naybPsXWc0t1YEAHmI8ohK9ted9CJm0+cE22p9At3p2WquWwmrK/K3K6Kx5p+KS+o0gxicyruFP4UwSa93r+XbhGFqh2mt94lYrTQHh+V0EO69AW+1ZLUV5gsnv7EWZe0XNutc5hLXD8T7BhjnPr6EKC0MLihk4zEswYLpGerK37lXh+s51ytwlVvz1XxWjvjGnInhd2JpNO97wzmBOe6Pf1eWJVQQ+OY3r77HyedDkimWcV/uubUlvwbDx+AC+s9yLnuJvAVkbh+brBNHi0cmmTvQMNioMKiiKVWo4d/rBASaGCxp2fzcXTFCZH+tXXkKnMyYQwuYCjg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(82310400026)(376014)(7416014)(18002099003)(56012099003)(22082099003)(13003099007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: QFSZ+cax7G42sMvmh0aqGiKIJQ8zyqTdeNv9HWC+/uZiAlcxal2Rb/OhGeIA38k1S6sPcJeTyhoK2cwCdcKtBS2INV8WrYdZK5XlFslQux+eN9pqiwrLtB8Zze+xla/u3h/RkQjI3y86MzcNzIXcwJFMXhWJNyXp1sv1agwxwAOaieVVzd5C1MxIoKC/glx7KO43vEuU8fFhVXeAJIjUFj9Af0Ks5w7NxccFoczuWYAJzsA48QoEmbR7qswdZCrjFy66H3+wsyqEShVfFEyRFhX/h42UlQDSh938VsIX9vHMsajo9SSuyuGLjrcvtSmqLzN4I7XysZpmzm7UrzS/Z4rin5uYpveD6meoXlkLORXH8MVlsrZxozAIJ1K/l6iYn5657NSSTswtu/8ivMEouJ3M1rt8BMNssPsrkHZbCGZLhvT1gkSvApMfj9O100RF X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2026 02:29:47.9270 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ecde225-0e44-4024-5e5b-08de83cd0f30 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF00004681.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9134 Hello John, On 3/17/2026 5:04 AM, John Stultz wrote: > On Sun, Mar 15, 2026 at 9:34 AM K Prateek Nayak wrote: >> On 3/13/2026 8:00 AM, John Stultz wrote: >>> +/* >>> + * attach_one_task() -- attaches the task returned from detach_one_task() to >>> + * its new rq. >>> + */ >>> +static inline void attach_one_task(struct rq *rq, struct task_struct *p) >>> +{ >>> + struct rq_flags rf; >>> + >>> + rq_lock(rq, &rf); >> >> nit. We can now use guard(rq_lock)(rq) and save on needing to declare a >> "rf". Apart from that, feel free to include: > > I actually did this in a later patch in the full series, as it seemed > more clear I wasn't modifying logic when moving the code: > https://github.com/johnstultz-work/linux-dev/commit/8d8a12278d81ce81af6b0dfd051750f4ce2ec0e5 > > But, given your feedback, I'll go ahead and fold that fix down to this > change and add a note in the commit message. Thanks a ton! That reminds me that I should go look at the full proxy series once again. I've queued some usual benchmark runs for these bits on top of tip - I've hopeful I've sorted the stuff with longer running benchmarks this time around; will report back once they are done. Again, thank you for incorporating the suggestions and reworking the series. Much appreciated _/\_ -- Thanks and Regards, Prateek