public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bean Huo <huobean@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
	linux-mmc@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Cc: Wenchao Chen <wenchao.chen666@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Avri Altman <avri.altman@wdc.com>,
	Christian Lohle <cloehle@hyperstone.com>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] mmc: core: Disable REQ_FUA if the eMMC supports an internal cache
Date: Thu, 2 Mar 2023 16:02:26 +0100	[thread overview]
Message-ID: <58bb34de-e333-00bd-ae3f-4ddf0e56aa5d@gmail.com> (raw)
In-Reply-To: <20230302144330.274947-1-ulf.hansson@linaro.org>

On 02.03.23 3:43 PM, Ulf Hansson wrote:
> REQ_FUA is in general supported for eMMC cards, which translates into so
> called "reliable writes". To support these write operations, the CMD23
> (MMC_CAP_CMD23), needs to be supported by the mmc host too, which is common
> but not always the case.
>
> For some eMMC devices, it has been reported that reliable writes are quite
> costly, leading to performance degradations.
>
> In a way to improve the situation, let's avoid announcing REQ_FUA support
> if the eMMC supports an internal cache, as that allows us to rely solely on
> flush-requests (REQ_OP_FLUSH) instead, which seems to be a lot cheaper.
> Note that, those mmc hosts that lacks CMD23 support are already using this
> type of configuration, whatever that could mean.
>
> Reported-by: Wenchao Chen<wenchao.chen666@gmail.com>
> Signed-off-by: Ulf Hansson<ulf.hansson@linaro.org>
Acked-by: Bean Huo <beanhuo@micron.com>

  reply	other threads:[~2023-03-02 15:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02 14:43 [RFC PATCH] mmc: core: Disable REQ_FUA if the eMMC supports an internal cache Ulf Hansson
2023-03-02 15:02 ` Bean Huo [this message]
2023-03-03  9:39   ` Avri Altman
2023-03-03 11:03     ` Ulf Hansson
2023-03-03 11:37       ` Avri Altman
2023-03-02 15:07 ` Christian Löhle
2023-03-03 11:40   ` Christian Löhle
2023-03-03 12:01     ` Ulf Hansson
2023-03-03 14:41       ` Adrian Hunter
2023-03-06 16:09         ` Ulf Hansson
2023-03-07 13:15           ` Adrian Hunter
2023-03-10 13:43 ` Christian Löhle
2023-03-10 14:53   ` Ulf Hansson
2023-03-10 17:06     ` Christian Löhle
2023-03-13 16:56       ` Adrian Hunter
2023-03-14  7:56         ` Ulf Hansson
2023-03-14  8:57           ` Adrian Hunter
2023-03-16 12:12             ` Ulf Hansson
2023-03-16 12:44               ` Adrian Hunter
2023-03-11  8:30   ` Avri Altman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58bb34de-e333-00bd-ae3f-4ddf0e56aa5d@gmail.com \
    --to=huobean@gmail.com \
    --cc=adrian.hunter@intel.com \
    --cc=avri.altman@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=cloehle@hyperstone.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=wenchao.chen666@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox