From: Xingyu Wu <xingyu.wu@starfivetech.com>
To: Mark Brown <broonie@kernel.org>
Cc: Conor Dooley <conor@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Claudiu Beznea <Claudiu.Beznea@microchip.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor.dooley@microchip.com>,
Walker Chen <walker.chen@starfivetech.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<alsa-devel@alsa-project.org>, <linux-sound@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] dt-bindings: ASoC: Add Cadence I2S controller for StarFive JH8100 SoC
Date: Fri, 29 Dec 2023 16:30:38 +0800 [thread overview]
Message-ID: <58c244d9-c754-420c-8c34-73dc09af0e72@starfivetech.com> (raw)
In-Reply-To: <229ffec0-3a8d-4ce8-a4bb-ef6ece639ad8@sirena.org.uk>
On 2023/12/22 21:03, Mark Brown wrote:
> On Fri, Dec 22, 2023 at 05:55:14PM +0800, Xingyu Wu wrote:
>
>> The Cadence I2S can support 8 channels. But on the JH8100 SoC, two
>> instances of this just provide 4 channels to use, one just provides 2
>> channels, and the other one can provide 8 channels. Should I use the
>> property name of 'jh8100,i2s-max-channels' instead for some special
>> instances on the JH8100 SoC?
>
> No, your current name is fine if the binding is generic for all Cadence
> users. I do think it would be good to have a separate compatible for
> these two channel instances, if there's been one customisation there may
> well have been others.
>
> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns. Doing this makes your messages much
> easier to read and reply to.
Great, thank you for your support.
Best regards,
Xingyu Wu
next prev parent reply other threads:[~2023-12-29 8:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 3:32 [PATCH v1 0/2] Add Cadence I2S controller driver for the Xingyu Wu
2023-12-21 3:32 ` [PATCH v1 1/2] dt-bindings: ASoC: Add Cadence I2S controller for StarFive JH8100 SoC Xingyu Wu
2023-12-21 13:53 ` Conor Dooley
2023-12-21 13:58 ` Mark Brown
2023-12-22 9:55 ` Xingyu Wu
2023-12-22 13:03 ` Mark Brown
2023-12-29 8:30 ` Xingyu Wu [this message]
2023-12-22 9:44 ` Xingyu Wu
2023-12-21 16:07 ` Krzysztof Kozlowski
2023-12-22 9:56 ` Xingyu Wu
2023-12-21 3:32 ` [PATCH v1 2/2] ASoC: starfive: Add drivers of Cadence Multi-Channel I2S Controller Xingyu Wu
2023-12-21 12:55 ` Mark Brown
2023-12-22 9:11 ` Xingyu Wu
2023-12-22 12:39 ` Mark Brown
2023-12-29 8:31 ` Xingyu Wu
2023-12-22 21:32 ` kernel test robot
2023-12-23 11:54 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58c244d9-c754-420c-8c34-73dc09af0e72@starfivetech.com \
--to=xingyu.wu@starfivetech.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=walker.chen@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox