public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Andries Brouwer <andries.brouwer@cwi.nl>
Cc: micah milano <micaho@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: SiI3112 Serial ATA Maxtor 6Y120M0 incorrect geometry detected
Date: Sun, 26 Sep 2004 12:59:48 +0200	[thread overview]
Message-ID: <58cb370e04092603596138133a@mail.gmail.com> (raw)
In-Reply-To: <20040926102937.GA27269@apps.cwi.nl>

On Sun, 26 Sep 2004 12:29:37 +0200, Andries Brouwer
<andries.brouwer@cwi.nl> wrote:
> On Sun, Sep 26, 2004 at 12:15:33AM +0200, Bartlomiej Zolnierkiewicz wrote:
> 
> > I'm tired of this issue and this is what I'm going to do:
> > - remove CHS info from IDE printks and /proc/ide/
> > - add BLKGETSTART ioctl for getting partition's start sector
> >   (this is the only legitimate use of HDIO_GETGEO currently)
> > - at least obsolete HDIO_GETGEO in IDE or even remove it (failing is
> >   better than returning unexpected results)
> > - silence complainers :)
> >
> > Bartlomiej
> 
> Yes. Consider returning 0 for C/H/S in HDIO_GETGEO.
> 
> We need the BLKGETSTART ioctl for another reason:
> the field start of a struct hd_geometry has 32 bits
> and fails for partitions starting past the 2TB mark.
> So, just like BLKGETSIZE64, this BLKGETSTART must
> return a u64 and return an offset in bytes.

Yes, I though so. Also u64 is 64-bit safe.

> As we all know, geometry is meaningless for IDE.
> But it is not for MFM/RLL and similar ancient stuff.
> If support for old disks is not broken yet, try not to break it.

OK.

  reply	other threads:[~2004-09-26 10:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-25 19:14 SiI3112 Serial ATA Maxtor 6Y120M0 incorrect geometry detected micah milano
2004-09-25 21:03 ` micah milano
2004-09-25 22:15   ` Bartlomiej Zolnierkiewicz
2004-09-25 23:44     ` Alan Cox
2004-09-26 10:29     ` Andries Brouwer
2004-09-26 10:59       ` Bartlomiej Zolnierkiewicz [this message]
2004-09-27 15:50         ` micah milano
2004-09-27 19:31           ` Andries Brouwer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58cb370e04092603596138133a@mail.gmail.com \
    --to=bzolnier@gmail.com \
    --cc=andries.brouwer@cwi.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=micaho@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox