* [PATCH] ppc64: Bump MAX_HWIFS in IDE code @ 2004-11-09 20:30 Anton Blanchard 2004-11-09 20:55 ` Andrew Morton 2004-11-10 20:45 ` Anton Blanchard 0 siblings, 2 replies; 10+ messages in thread From: Anton Blanchard @ 2004-11-09 20:30 UTC (permalink / raw) To: akpm; +Cc: linux-kernel When fully configured, some POWER5 boxes can have much more than 4 IDE interfaces. Increase the limit to reflect this. Signed-off-by: Anton Blanchard <anton@samba.org> diff -puN include/asm-ppc64/ide.h~bump_ide_hwifs include/asm-ppc64/ide.h --- gr_work/include/asm-ppc64/ide.h~bump_ide_hwifs 2004-08-25 08:11:54.357759525 -0500 +++ gr_work-anton/include/asm-ppc64/ide.h 2004-08-25 08:11:54.366758100 -0500 @@ -19,7 +19,7 @@ #ifdef __KERNEL__ #ifndef MAX_HWIFS -# define MAX_HWIFS 4 +# define MAX_HWIFS 16 #endif #define IDE_ARCH_OBSOLETE_INIT _ ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code 2004-11-09 20:30 [PATCH] ppc64: Bump MAX_HWIFS in IDE code Anton Blanchard @ 2004-11-09 20:55 ` Andrew Morton 2004-11-09 21:12 ` Chris Wedgwood 2004-11-09 21:20 ` Anton Blanchard 2004-11-10 20:45 ` Anton Blanchard 1 sibling, 2 replies; 10+ messages in thread From: Andrew Morton @ 2004-11-09 20:55 UTC (permalink / raw) To: Anton Blanchard; +Cc: linux-kernel Anton Blanchard <anton@samba.org> wrote: > > > When fully configured, some POWER5 boxes can have much more than 4 IDE > interfaces. Increase the limit to reflect this. > > Signed-off-by: Anton Blanchard <anton@samba.org> > > diff -puN include/asm-ppc64/ide.h~bump_ide_hwifs include/asm-ppc64/ide.h > --- gr_work/include/asm-ppc64/ide.h~bump_ide_hwifs 2004-08-25 08:11:54.357759525 -0500 > +++ gr_work-anton/include/asm-ppc64/ide.h 2004-08-25 08:11:54.366758100 -0500 > @@ -19,7 +19,7 @@ > #ifdef __KERNEL__ > > #ifndef MAX_HWIFS > -# define MAX_HWIFS 4 > +# define MAX_HWIFS 16 > #endif hrmph. That costs 50kbytes, excluding ide-tape. It's worth a config variable, I think. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code 2004-11-09 20:55 ` Andrew Morton @ 2004-11-09 21:12 ` Chris Wedgwood 2004-11-09 21:21 ` Anton Blanchard 2004-11-09 22:12 ` Benjamin Herrenschmidt 2004-11-09 21:20 ` Anton Blanchard 1 sibling, 2 replies; 10+ messages in thread From: Chris Wedgwood @ 2004-11-09 21:12 UTC (permalink / raw) To: Andrew Morton; +Cc: Anton Blanchard, linux-kernel On Tue, Nov 09, 2004 at 12:55:07PM -0800, Andrew Morton wrote: > hrmph. That costs 50kbytes, excluding ide-tape. It's worth a > config variable, I think. this come up from time to time, and i wonder why it can't be dynamic? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code 2004-11-09 21:12 ` Chris Wedgwood @ 2004-11-09 21:21 ` Anton Blanchard 2004-11-09 22:12 ` Benjamin Herrenschmidt 1 sibling, 0 replies; 10+ messages in thread From: Anton Blanchard @ 2004-11-09 21:21 UTC (permalink / raw) To: Chris Wedgwood; +Cc: Andrew Morton, linux-kernel > this come up from time to time, and i wonder why it can't be dynamic? Agreed, that would be the best solution. Anton ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code 2004-11-09 21:12 ` Chris Wedgwood 2004-11-09 21:21 ` Anton Blanchard @ 2004-11-09 22:12 ` Benjamin Herrenschmidt 2004-11-10 18:05 ` Bartlomiej Zolnierkiewicz 1 sibling, 1 reply; 10+ messages in thread From: Benjamin Herrenschmidt @ 2004-11-09 22:12 UTC (permalink / raw) To: Chris Wedgwood; +Cc: Andrew Morton, Anton Blanchard, Linux Kernel list On Tue, 2004-11-09 at 13:12 -0800, Chris Wedgwood wrote: > On Tue, Nov 09, 2004 at 12:55:07PM -0800, Andrew Morton wrote: > > > hrmph. That costs 50kbytes, excluding ide-tape. It's worth a > > config variable, I think. > > this come up from time to time, and i wonder why it can't be dynamic? Good question :) I suppose Bart has that on his todolist, but it will require some work on the IDE layer, which only few people can do without breaking it all :) Ben. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code 2004-11-09 22:12 ` Benjamin Herrenschmidt @ 2004-11-10 18:05 ` Bartlomiej Zolnierkiewicz 2004-11-10 20:30 ` Anton Blanchard 0 siblings, 1 reply; 10+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2004-11-10 18:05 UTC (permalink / raw) To: Benjamin Herrenschmidt Cc: Chris Wedgwood, Andrew Morton, Anton Blanchard, Linux Kernel list Anton, IDE driver is limited to 10 major numbers anyway so please just use 10 for now... On Wed, 10 Nov 2004 09:12:45 +1100, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > On Tue, 2004-11-09 at 13:12 -0800, Chris Wedgwood wrote: > > On Tue, Nov 09, 2004 at 12:55:07PM -0800, Andrew Morton wrote: > > > > > hrmph. That costs 50kbytes, excluding ide-tape. It's worth a > > > config variable, I think. > > > > this come up from time to time, and i wonder why it can't be dynamic? > > Good question :) I suppose Bart has that on his todolist, but it will > require some work on the IDE layer, which only few people can do without > breaking it all :) Yes I'm working on it and I will need some help with fixing PPC drivers. :) ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code 2004-11-10 18:05 ` Bartlomiej Zolnierkiewicz @ 2004-11-10 20:30 ` Anton Blanchard 0 siblings, 0 replies; 10+ messages in thread From: Anton Blanchard @ 2004-11-10 20:30 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: Benjamin Herrenschmidt, Chris Wedgwood, Andrew Morton, Linux Kernel list > Anton, IDE driver is limited to 10 major numbers anyway > so please just use 10 for now... Thanks Bart, will do. Anton ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code 2004-11-09 20:55 ` Andrew Morton 2004-11-09 21:12 ` Chris Wedgwood @ 2004-11-09 21:20 ` Anton Blanchard 2004-11-09 21:41 ` Andrew Morton 1 sibling, 1 reply; 10+ messages in thread From: Anton Blanchard @ 2004-11-09 21:20 UTC (permalink / raw) To: Andrew Morton; +Cc: linux-kernel > > diff -puN include/asm-ppc64/ide.h~bump_ide_hwifs include/asm-ppc64/ide.h > > --- gr_work/include/asm-ppc64/ide.h~bump_ide_hwifs 2004-08-25 08:11:54.357759525 -0500 > > +++ gr_work-anton/include/asm-ppc64/ide.h 2004-08-25 08:11:54.366758100 -0500 > > @@ -19,7 +19,7 @@ > > #ifdef __KERNEL__ > > > > #ifndef MAX_HWIFS > > -# define MAX_HWIFS 4 > > +# define MAX_HWIFS 16 > > #endif > > hrmph. That costs 50kbytes, excluding ide-tape. It's worth a config > variable, I think. Ouch. BTW i386 has it set to 10, it should be looked at as well. Anton ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code 2004-11-09 21:20 ` Anton Blanchard @ 2004-11-09 21:41 ` Andrew Morton 0 siblings, 0 replies; 10+ messages in thread From: Andrew Morton @ 2004-11-09 21:41 UTC (permalink / raw) To: Anton Blanchard; +Cc: linux-kernel Anton Blanchard <anton@samba.org> wrote: > > > > > diff -puN include/asm-ppc64/ide.h~bump_ide_hwifs include/asm-ppc64/ide.h > > > --- gr_work/include/asm-ppc64/ide.h~bump_ide_hwifs 2004-08-25 08:11:54.357759525 -0500 > > > +++ gr_work-anton/include/asm-ppc64/ide.h 2004-08-25 08:11:54.366758100 -0500 > > > @@ -19,7 +19,7 @@ > > > #ifdef __KERNEL__ > > > > > > #ifndef MAX_HWIFS > > > -# define MAX_HWIFS 4 > > > +# define MAX_HWIFS 16 > > > #endif > > > > hrmph. That costs 50kbytes, excluding ide-tape. It's worth a config > > variable, I think. > > Ouch. BTW i386 has it set to 10, it should be looked at as well. > Oh, I failed to notice that it was a ppc64-specific header file. You can afford 50k ;) ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code 2004-11-09 20:30 [PATCH] ppc64: Bump MAX_HWIFS in IDE code Anton Blanchard 2004-11-09 20:55 ` Andrew Morton @ 2004-11-10 20:45 ` Anton Blanchard 1 sibling, 0 replies; 10+ messages in thread From: Anton Blanchard @ 2004-11-10 20:45 UTC (permalink / raw) To: akpm; +Cc: linux-kernel When fully configured, some POWER5 boxes can have much more than 4 IDE interfaces. Increase the limit to reflect this. Signed-off-by: Anton Blanchard <anton@samba.org> diff -puN include/asm-ppc64/ide.h~bump_ide_hwifs include/asm-ppc64/ide.h --- gr_work/include/asm-ppc64/ide.h~bump_ide_hwifs 2004-08-25 08:11:54.357759525 -0500 +++ gr_work-anton/include/asm-ppc64/ide.h 2004-08-25 08:11:54.366758100 -0500 @@ -19,7 +19,7 @@ #ifdef __KERNEL__ #ifndef MAX_HWIFS -# define MAX_HWIFS 4 +# define MAX_HWIFS 10 #endif #define IDE_ARCH_OBSOLETE_INIT _ ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2004-11-10 20:48 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2004-11-09 20:30 [PATCH] ppc64: Bump MAX_HWIFS in IDE code Anton Blanchard 2004-11-09 20:55 ` Andrew Morton 2004-11-09 21:12 ` Chris Wedgwood 2004-11-09 21:21 ` Anton Blanchard 2004-11-09 22:12 ` Benjamin Herrenschmidt 2004-11-10 18:05 ` Bartlomiej Zolnierkiewicz 2004-11-10 20:30 ` Anton Blanchard 2004-11-09 21:20 ` Anton Blanchard 2004-11-09 21:41 ` Andrew Morton 2004-11-10 20:45 ` Anton Blanchard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox