From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: torvalds@osdl.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: 2.6.10 - Still mishandles volumes without geometry data
Date: Tue, 28 Dec 2004 21:48:13 +0100 [thread overview]
Message-ID: <58cb370e041228124878cb6e2a@mail.gmail.com> (raw)
In-Reply-To: <1104155840.20898.3.camel@localhost.localdomain>
On Mon, 27 Dec 2004 13:57:20 +0000, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> An IDE device can choose not to report geometry. In this situation the
> base 2.6 kernel tries to verify the LBA data despite having nothing to
> validate it against and prints it out (although now only as pr_debug).
>
> This patch fixes these problems and has in various forms been in
> 2.6.9-ac and Fedora Core for a considerable time now
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.10/drivers/ide/ide-disk.c linux-2.6.10/drivers/ide/ide-disk.c
> --- linux.vanilla-2.6.10/drivers/ide/ide-disk.c 2004-12-25 21:15:34.000000000 +0000
> +++ linux-2.6.10/drivers/ide/ide-disk.c 2004-12-26 21:55:43.084714368 +0000
> @@ -84,6 +84,10 @@
> {
> unsigned long lba_sects, chs_sects, head, tail;
>
> + /* No non-LBA info .. so valid! */
> + if (id->cyls == 0)
> + return 1;
> +
> /*
> * The ATA spec tells large drives to return
> * C/H/S = 16383/16/63 independent of their size.
> @@ -201,7 +205,8 @@
> head = track % drive->head;
> cyl = track / drive->head;
>
> - pr_debug("%s: CHS=%u/%u/%u\n", drive->name, cyl, head, sect);
> + if(drive->bios_cyl)
> + pr_debug("%s: CHS=%u/%u/%u\n", drive->name, cyl, head, sect);
>
> hwif->OUTB(0x00, IDE_FEATURE_REG);
> hwif->OUTB(nsectors.b.low, IDE_NSECTOR_REG);
Shouldn't this check be around printk in idedisk_setup() instead?
next prev parent reply other threads:[~2004-12-28 20:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-27 13:57 PATCH: 2.6.10 - Still mishandles volumes without geometry data Alan Cox
2004-12-28 20:48 ` Bartlomiej Zolnierkiewicz [this message]
2004-12-28 22:03 ` Alan Cox
2004-12-28 22:08 ` Alan Cox
2004-12-29 2:52 ` Andries Brouwer
2004-12-29 14:36 ` Alan Cox
2004-12-29 19:28 ` Andries Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e041228124878cb6e2a@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox