From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
torvalds@osdl.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Subject: Re: PATCH: 2.6.10 - Incorrect return from PCI ide controller
Date: Tue, 28 Dec 2004 22:15:26 +0100 [thread overview]
Message-ID: <58cb370e04122813152759d94f@mail.gmail.com> (raw)
In-Reply-To: <20041228205553.GA18525@electric-eye.fr.zoreil.com>
On Tue, 28 Dec 2004 21:55:53 +0100, Francois Romieu
<romieu@fr.zoreil.com> wrote:
> Alan Cox <alan@lxorguk.ukuu.org.uk> :
> > Several IDE drivers return positive values as errors in the PCI setup
> > code. Unfortunately the PCI layer considers positive values as success
> > so the driver skips the device but still claims it and things then go
> > downhill.
> >
> > This fixes the IT8172 driver. There are other drivers with this bug (eg
> > generic) but the -ac IDE is sufficiently diverged from base that someone
> > else needs to generate/test the more divergent cases.
>
> ide_setup_pci_device{s} will always claim that everything is fine even
> though do_ide_setup_pci_device() has some opportunity to fail.
>
> Should it matter as well ?
Yes. Patches welcomed.
next prev parent reply other threads:[~2004-12-28 21:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-27 14:37 PATCH: 2.6.10 - Incorrect return from PCI ide controller Alan Cox
2004-12-28 20:55 ` Francois Romieu
2004-12-28 21:15 ` Bartlomiej Zolnierkiewicz [this message]
2004-12-29 0:09 ` Francois Romieu
2004-12-30 0:03 ` [patch 2.6.10-bk1 1/5] pci-ide: propagation of error code in ide setup Francois Romieu
2004-12-30 0:04 ` [patch 2.6.10-bk1 2/5] pci-ide: clean up error path in do_ide_setup_pci_device Francois Romieu
2004-12-30 0:06 ` [patch 2.6.10-bk1 3/5] pci-ide: propagate the error status in ide_pci_enable/ide_setup_pci_controller Francois Romieu
2004-12-30 0:07 ` [patch 2.6.10-bk1 4/5] pci-ide: fix the incorrect returns for the generic driver Francois Romieu
2004-12-30 0:09 ` [patch 2.6.10-bk1 5/5] pci-ide: make device drivers code aware of the changes made to ide_setup_pci_device{s} Francois Romieu
2004-12-30 0:21 ` colophon Francois Romieu
2004-12-28 22:12 ` PATCH: 2.6.10 - Incorrect return from PCI ide controller Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e04122813152759d94f@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox