Re: [PATCH 2.6.11-rc2 03/29] ide: cleanup opti621

Tejun Heo
2005-02-02T02:46:30Z

> 03_ide_cleanup_opti621.patch
>
> In drivers/ide/pci/opti612.[hc], init_setup_opt621() is
> declared, defined and referenced but never actullay used.
> Thie patch removes the function.

Signed-off-by: Tejun Heo <tj@home-tj.org>

Index: linux-ide-export/drivers/ide/pci/opti621.c
===================================================================
--- linux-ide-export.orig/drivers/ide/pci/opti621.c 2005-02-02 10:27:16.326131292 +0900
+++ linux-ide-export/drivers/ide/pci/opti621.c 2005-02-02 10:28:01.947729558 +0900
@@ -348,11 +348,6 @@ static void __init init_hwif_opti621 (id
hwif->drives[1].autodma = hwif->autodma;
}

-static int __init init_setup_opti621 (struct pci_dev *dev, ide_pci_device_t *d)
-{
- return ide_setup_pci_device(dev, d);
-}
-
static int __devinit opti621_init_one(struct pci_dev *dev, const struct pci_device_id *id)
{
return ide_setup_pci_device(dev, &opti621_chipsets[id->driver_data]);
Index: linux-ide-export/drivers/ide/pci/opti621.h
===================================================================
--- linux-ide-export.orig/drivers/ide/pci/opti621.h 2005-02-02 10:27:16.327131130 +0900
+++ linux-ide-export/drivers/ide/pci/opti621.h 2005-02-02 10:28:01.948729395 +0900
@@ -5,13 +5,11 @@
#include <linux/pci.h>
#include <linux/ide.h>

-static int init_setup_opti621(struct pci_dev *, ide_pci_device_t *);
static void init_hwif_opti621(ide_hwif_t *);

static ide_pci_device_t opti621_chipsets[] __devinitdata = {
{ /* 0 */
.name = "OPTI621",
- .init_setup = init_setup_opti621,
.init_hwif = init_hwif_opti621,
.channels = 2,
.autodma = AUTODMA,
@@ -19,7 +17,6 @@ static ide_pci_device_t opti621_chipsets
.bootable = ON_BOARD,
},{ /* 1 */
.name = "OPTI621X",
- .init_setup = init_setup_opti621,
.init_hwif = init_hwif_opti621,
.channels = 2,
.autodma = AUTODMA,