Re: [PATCH 2.6.11-rc2 19/29] ide: ide_diag_taskfile() rq initialization fix

Tejun Heo
2005-02-02T03:59:51Z

> 19_ide_diag_taskfile_use_init_drive_cmd.patch
>
> In ide_diag_taskfile(), when initializing taskfile rq,
> ref_count wasn't initialized properly. Modified to use
> ide_init_drive_cmd(). This doesn't really change any behavior
> as the request isn't managed via the block layer.

Signed-off-by: Tejun Heo <tj@home-tj.org>

Index: linux-ide-export/drivers/ide/ide-taskfile.c
===================================================================
--- linux-ide-export.orig/drivers/ide/ide-taskfile.c 2005-02-02 10:28:05.642130143 +0900
+++ linux-ide-export/drivers/ide/ide-taskfile.c 2005-02-02 10:28:05.851096238 +0900
@@ -471,7 +471,7 @@ static int ide_diag_taskfile(ide_drive_t
{
struct request rq;

- memset(&rq, 0, sizeof(rq));
+ ide_init_drive_cmd(&rq);
rq.flags = REQ_DRIVE_TASKFILE;
rq.buffer = buf;