From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: via82cxxx resume failure.
Date: Thu, 3 Feb 2005 21:29:43 +0100 [thread overview]
Message-ID: <58cb370e05020312296060f4bf@mail.gmail.com> (raw)
In-Reply-To: <1105953931.26551.314.camel@hades.cambridge.redhat.com>
Sorry for the delay.
On Mon, 17 Jan 2005 09:25:30 +0000, David Woodhouse <dwmw2@infradead.org> wrote:
> On resume from sleep, via_set_speed() doesn't reinstate the correct DMA
> mode, because it thinks the drive is already configured correctly. This
> one-line hack is sufficient to make it refrain from dying a horrible
> death immediately after resume, but presumably has other problems...
I applied this to libata-dev so it gets some testing in -mm.
> ===== drivers/ide/pci/via82cxxx.c 1.24 vs edited =====
> --- 1.24/drivers/ide/pci/via82cxxx.c Mon Aug 9 18:00:46 2004
> +++ edited/drivers/ide/pci/via82cxxx.c Tue Oct 26 22:48:59 2004
> @@ -328,7 +328,7 @@
> struct ide_timing t, p;
> unsigned int T, UT;
>
> - if (speed != XFER_PIO_SLOW && speed != drive->current_speed)
> + // if (speed != XFER_PIO_SLOW && speed != drive->current_speed)
> if (ide_config_drive_speed(drive, speed))
> printk(KERN_WARNING "ide%d: Drive %d didn't "
> "accept speed setting. Oh, well.\n",
>
next prev parent reply other threads:[~2005-02-03 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-17 9:25 via82cxxx resume failure David Woodhouse
2005-02-03 20:29 ` Bartlomiej Zolnierkiewicz [this message]
2005-02-03 22:14 ` Jeff Garzik
2005-02-03 22:23 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e05020312296060f4bf@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox