* via82cxxx resume failure.
@ 2005-01-17 9:25 David Woodhouse
2005-02-03 20:29 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 4+ messages in thread
From: David Woodhouse @ 2005-01-17 9:25 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-kernel
On resume from sleep, via_set_speed() doesn't reinstate the correct DMA
mode, because it thinks the drive is already configured correctly. This
one-line hack is sufficient to make it refrain from dying a horrible
death immediately after resume, but presumably has other problems...
===== drivers/ide/pci/via82cxxx.c 1.24 vs edited =====
--- 1.24/drivers/ide/pci/via82cxxx.c Mon Aug 9 18:00:46 2004
+++ edited/drivers/ide/pci/via82cxxx.c Tue Oct 26 22:48:59 2004
@@ -328,7 +328,7 @@
struct ide_timing t, p;
unsigned int T, UT;
- if (speed != XFER_PIO_SLOW && speed != drive->current_speed)
+ // if (speed != XFER_PIO_SLOW && speed != drive->current_speed)
if (ide_config_drive_speed(drive, speed))
printk(KERN_WARNING "ide%d: Drive %d didn't "
"accept speed setting. Oh, well.\n",
--
dwmw2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: via82cxxx resume failure.
2005-01-17 9:25 via82cxxx resume failure David Woodhouse
@ 2005-02-03 20:29 ` Bartlomiej Zolnierkiewicz
2005-02-03 22:14 ` Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2005-02-03 20:29 UTC (permalink / raw)
To: David Woodhouse; +Cc: linux-kernel
Sorry for the delay.
On Mon, 17 Jan 2005 09:25:30 +0000, David Woodhouse <dwmw2@infradead.org> wrote:
> On resume from sleep, via_set_speed() doesn't reinstate the correct DMA
> mode, because it thinks the drive is already configured correctly. This
> one-line hack is sufficient to make it refrain from dying a horrible
> death immediately after resume, but presumably has other problems...
I applied this to libata-dev so it gets some testing in -mm.
> ===== drivers/ide/pci/via82cxxx.c 1.24 vs edited =====
> --- 1.24/drivers/ide/pci/via82cxxx.c Mon Aug 9 18:00:46 2004
> +++ edited/drivers/ide/pci/via82cxxx.c Tue Oct 26 22:48:59 2004
> @@ -328,7 +328,7 @@
> struct ide_timing t, p;
> unsigned int T, UT;
>
> - if (speed != XFER_PIO_SLOW && speed != drive->current_speed)
> + // if (speed != XFER_PIO_SLOW && speed != drive->current_speed)
> if (ide_config_drive_speed(drive, speed))
> printk(KERN_WARNING "ide%d: Drive %d didn't "
> "accept speed setting. Oh, well.\n",
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: via82cxxx resume failure.
2005-02-03 20:29 ` Bartlomiej Zolnierkiewicz
@ 2005-02-03 22:14 ` Jeff Garzik
2005-02-03 22:23 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2005-02-03 22:14 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: David Woodhouse, linux-kernel
Bartlomiej Zolnierkiewicz wrote:
> Sorry for the delay.
>
> On Mon, 17 Jan 2005 09:25:30 +0000, David Woodhouse <dwmw2@infradead.org> wrote:
>
>>On resume from sleep, via_set_speed() doesn't reinstate the correct DMA
>>mode, because it thinks the drive is already configured correctly. This
>>one-line hack is sufficient to make it refrain from dying a horrible
>>death immediately after resume, but presumably has other problems...
>
>
> I applied this to libata-dev so it gets some testing in -mm.
Chuckle -- you mean ide-dev, presumably :)
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: via82cxxx resume failure.
2005-02-03 22:14 ` Jeff Garzik
@ 2005-02-03 22:23 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2005-02-03 22:23 UTC (permalink / raw)
To: Jeff Garzik; +Cc: David Woodhouse, linux-kernel
On Thu, 03 Feb 2005 17:14:50 -0500, Jeff Garzik <jgarzik@pobox.com> wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > Sorry for the delay.
> >
> > On Mon, 17 Jan 2005 09:25:30 +0000, David Woodhouse <dwmw2@infradead.org> wrote:
> >
> >>On resume from sleep, via_set_speed() doesn't reinstate the correct DMA
> >>mode, because it thinks the drive is already configured correctly. This
> >>one-line hack is sufficient to make it refrain from dying a horrible
> >>death immediately after resume, but presumably has other problems...
> >
> >
> > I applied this to libata-dev so it gets some testing in -mm.
>
> Chuckle -- you mean ide-dev, presumably :)
yes, obviously :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-02-03 22:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-17 9:25 via82cxxx resume failure David Woodhouse
2005-02-03 20:29 ` Bartlomiej Zolnierkiewicz
2005-02-03 22:14 ` Jeff Garzik
2005-02-03 22:23 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox