From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S262408AbVBXQBH@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S262408AbVBXQBH (ORCPT <rfc822;willy@w.ods.org>);
	Thu, 24 Feb 2005 11:01:07 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262407AbVBXP7x
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 24 Feb 2005 10:59:53 -0500
Received: from wproxy.gmail.com ([64.233.184.206]:57404 "EHLO wproxy.gmail.com")
	by vger.kernel.org with ESMTP id S262420AbVBXP6E (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 24 Feb 2005 10:58:04 -0500
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references;
        b=pHSTEBh5zleI3yGqw3Ac03cCUgC+EP+o6BCaKnBZW9BZnHOGxV5YyU49y64Yl9JSYLdWrNQZTezAnBa/Qblm+D7gZmZvViKm+wZttjDX13oalJauo3aEof0rhtLsm+YWN7y0wpH55ZlGWkvqw68Xb5oI9fglLnQ1Qr5qdaEAzGE=
Message-ID: <58cb370e05022407587e86f8ad@mail.gmail.com>
Date: Thu, 24 Feb 2005 16:58:03 +0100
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Reply-To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix
Cc: lkml <linux-kernel@vger.kernel.org>, linux-ide <linux-ide@vger.kernel.org>,
       Jeff Garzik <jgarzik@pobox.com>
In-Reply-To: <20050210083809.63BF53E6@htj.dyndns.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
References: <20050210083808.48E9DD1A@htj.dyndns.org>
	 <20050210083809.63BF53E6@htj.dyndns.org>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 10 Feb 2005 17:38:14 +0900 (KST), Tejun Heo <htejun@gmail.com> wrote:
> 
> 01_ide_task_end_request_fix.patch
> 
>         task_end_request() modified to always call ide_end_drive_cmd()
>         for taskfile requests.  Previously, ide_end_drive_cmd() was
>         called only when task->tf_out_flags.all was set.  Also,
>         ide_dma_intr() is modified to use task_end_request().
> 
>         * fixes taskfile ioctl oops bug which was caused by referencing
>           NULL rq->rq_disk of taskfile requests.

I fixed it in slightly different way in ide-dev-2.6 - by calling
ide_end_request() instead of ->end_request().

>         * enables TASKFILE ioctls to get valid register outputs on
>           successful completion.

This change makes *all* taskfile registers to be read on completion
of *any* command.  Currently this is done only for flagged taskfiles
and commands using no-data protocol.

With all your changes it will be also done for:
* HDIO_DRIVE_[TASKFILE,CMD] ioctls
* /proc/ide/hd?/{identify,smart_thresholds,smart_values}
but reading back all registers is not always needed.

It is already bad enough (and we can't fix it cause it is exported
to user-space through HDIO_DRIVE_TASKFILE), we shouldn't
make it worse.