public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ide_init_disk
@ 2005-03-01 13:50 Szabolcs Berecz
  2005-03-01 14:03 ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 2+ messages in thread
From: Szabolcs Berecz @ 2005-03-01 13:50 UTC (permalink / raw)
  To: linux-kernel


My /dev/hdb showed up as /dev/hdq

The bug was introduced with bk-ide-dev.patch

Bye,
Szabi

--- linux-2.6.11-rc4-mm1/drivers/ide/ide-probe.c.orig	2005-02-24 20:04:03.000000000 +0100
+++ linux-2.6.11-rc4-mm1/drivers/ide/ide-probe.c	2005-02-27 23:52:54.000000000 +0100
@@ -1269,7 +1269,7 @@
 void ide_init_disk(struct gendisk *disk, ide_drive_t *drive)
 {
 	ide_hwif_t *hwif = drive->hwif;
-	unsigned int unit = drive->select.all & (1 << 4);
+	unsigned int unit = drive->select.b.unit;

 	disk->major = hwif->major;
 	disk->first_minor = unit << PARTN_BITS;


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ide_init_disk
  2005-03-01 13:50 [PATCH] ide_init_disk Szabolcs Berecz
@ 2005-03-01 14:03 ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2005-03-01 14:03 UTC (permalink / raw)
  To: Szabolcs Berecz; +Cc: linux-kernel

Already fixed by Andrew in 2.6.11-rc5-mm1.

Please always cc: me and linux-ide@vger.kernel.org on IDE patches.

Thanks.

On Tue, 1 Mar 2005 14:50:18 +0100 (CET), Szabolcs Berecz
<szabi@mplayerhq.hu> wrote:
> 
> My /dev/hdb showed up as /dev/hdq
> 
> The bug was introduced with bk-ide-dev.patch
> 
> Bye,
> Szabi
> 
> --- linux-2.6.11-rc4-mm1/drivers/ide/ide-probe.c.orig   2005-02-24 20:04:03.000000000 +0100
> +++ linux-2.6.11-rc4-mm1/drivers/ide/ide-probe.c        2005-02-27 23:52:54.000000000 +0100
> @@ -1269,7 +1269,7 @@
>  void ide_init_disk(struct gendisk *disk, ide_drive_t *drive)
>  {
>         ide_hwif_t *hwif = drive->hwif;
> -       unsigned int unit = drive->select.all & (1 << 4);
> +       unsigned int unit = drive->select.b.unit;
> 
>         disk->major = hwif->major;
>         disk->first_minor = unit << PARTN_BITS;
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-03-01 14:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-01 13:50 [PATCH] ide_init_disk Szabolcs Berecz
2005-03-01 14:03 ` Bartlomiej Zolnierkiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox