Re: [2.6 patch] unexport complete_all

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Fri, 04 Mar 2005 03:09:39 -0500, Mike Waychison <mike@waychison.com> wrote:
> > I didn't find any possible modular usage in the kernel.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> > --- linux-2.6.11-rc5-mm1-full/kernel/sched.c.old      2005-03-04 01:04:28.000000000 +0100
> > +++ linux-2.6.11-rc5-mm1-full/kernel/sched.c  2005-03-04 01:04:34.000000000 +0100
> > @@ -3053,7 +3053,6 @@
> >                        0, 0, NULL);
> >       spin_unlock_irqrestore(&x->wait.lock, flags);
> >  }
> > -EXPORT_SYMBOL(complete_all);
> >
> >  void fastcall __sched wait_for_completion(struct completion *x)
> >  {
> > -
> 
> This is a valid piece of API that is exported for future use.

Let me guess: autofsng?

It was you who added it (through akpm):


[PATCH] export complete_all()

From: Mike Waychison <Michael.Waychison@Sun.COM>

Export complete_all for module use.


Andrew, what is the policy for adding exports for out of tree GPL code?

IMHO although it is convenient for maintainers of such code it is
inconvenient for us (ie. when making changes to code) and gives
people false assumptions about stability of *in-kernel* APIs.

Bartlomiej