Re: [PATCH] disk quotas fail when /etc/mtab is symlinked to /proc/mounts

Andrew Morton
2005-07-29T00:25:03Z

Mark Bellon <mbellon@mvista.com> wrote:
>
> If /etc/mtab is a regular file all of the mount options (of a file
> system) are written to /etc/mtab by the mount command. The quota tools
> look there for the quota strings for their operation. If, however,
> /etc/mtab is a symlink to /proc/mounts (a "good thing" in some
> environments) the tools don't write anything - they assume the kernel
> will take care of things.
>
> While the quota options are sent down to the kernel via the mount system
> call and the file system codes handle them properly unfortunately there
> is no code to echo the quota strings into /proc/mounts and the quota
> tools fail in the symlink case.

hm. Perhaps others with operational experience in that area can comment.

> The attached patchs modify the EXT[2|3] and [X|J]FS codes to add the
> necessary hooks. The show_options function of each file system in these
> patches currently deal with only those things that seemed related to
> quotas; especially in the EXT3 case more can be done (later?).

It seems sad to do it in each filesystem. Is there no way in which we can
do this for all filesystems, in a single place in the VFS?