From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 10/11] LED: Add IDE disk activity LED trigger
Date: Tue, 31 Jan 2006 15:46:58 +0100 [thread overview]
Message-ID: <58cb370e0601310646y263acb96h62c422435e7016e@mail.gmail.com> (raw)
In-Reply-To: <1138714918.6869.139.camel@localhost.localdomain>
Hi,
Why cannot existing block layer hook be used for this?
Why are you adding LED_FULL event handling to a specific
device driver (ide-disk) but LED_OFF event handling to a generic
IDE end request function?
This solution has very limited flexibility (disk accesses for
all IDE ports will be registered as coming from the same
source) but I guess it is fine?
Thanks,
Bartlomiej
On 1/31/06, Richard Purdie <rpurdie@rpsys.net> wrote:
> Add an LED trigger for IDE disk activity to the IDE subsystem.
>
> Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
next prev parent reply other threads:[~2006-01-31 14:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 13:41 [PATCH 10/11] LED: Add IDE disk activity LED trigger Richard Purdie
2006-01-31 14:46 ` Bartlomiej Zolnierkiewicz [this message]
2006-01-31 16:21 ` Richard Purdie
2006-01-31 17:44 ` Bartlomiej Zolnierkiewicz
2006-01-31 20:29 ` Jens Axboe
2006-01-31 22:08 ` Benjamin Herrenschmidt
2006-01-31 23:39 ` Richard Purdie
2006-02-04 15:29 ` Richard Purdie
2006-01-31 20:35 ` Jens Axboe
2006-01-31 21:22 ` Jordan Crouse
2006-02-01 0:12 ` Matt Reimer
2006-02-02 1:32 ` Adrian Bunk
2006-01-31 22:03 ` [PATCH 10/11] " Richard Purdie
2006-02-02 11:07 ` Pavel Machek
2006-02-01 16:09 ` Jan Engelhardt
2006-02-04 9:54 ` Jan-Benedict Glaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e0601310646y263acb96h62c422435e7016e@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox