[PATCH] rivafb & small 16 bit mode problem

[PATCH] rivafb & small 16 bit mode problem

[Rusty Russell]

Ani,

	I assume this should be in 2.6's drivers/video/riva/fbdev.c as
well?

Rusty.

Date: Thu, 8 Jan 2004 22:45:56 +0100
From: "[iso-8859-2] Pawe? Goleniowski" <pawelg@dabrowa.pl>
To: linux-kernel@vger.kernel.org
Cc: marcelo.tosatti@cyclades.com, trivial@rustcorp.com.au
Subject: [PATCH for 2.4.x] rivafb & small 16 bit mode problem

I have already send this once before Xmas but it probably got lost, so I'm
sending it again:

There is a problem with 16 bit mode with rivafb. Colors are sometimes broken
(specialy under Midnight Commander). This small patch fixes it. I've been
using it for last months and it works without any problems.

Pawel 'Goldi' Goleniowski


--Boundary-00=_U+c//wvZdA6GwMA
Content-Type: TEXT/X-DIFF; CHARSET=iso-8859-2; NAME="patch-rivafb.diff"
Content-ID: <Pine.LNX.4.58L.0401220001133.18059@logos.cnet>
Content-Description: 
Content-Disposition: ATTACHMENT; FILENAME="patch-rivafb.diff"

--- linux/drivers/video/riva/accel.c	2003-12-22 22:46:27.000000000 +0100
+++ linux/drivers/video/riva/accel.c	2003-12-22 19:47:19.000000000 +0100
@@ -300,8 +300,8 @@
 
 static inline void convert_bgcolor_16(u32 *col)
 {
-	*col = ((*col & 0x00007C00) << 9)
-             | ((*col & 0x000003E0) << 6)
+	*col = ((*col & 0x0000F800) << 8)
+             | ((*col & 0x000007E0) << 5)
              | ((*col & 0x0000001F) << 3)
              |          0xFF000000;
 }

--Boundary-00=_U+c//wvZdA6GwMA--

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

Re: [PATCH] rivafb & small 16 bit mode problem

[Paweł Goleniowski]

Dnia czw 22 stycznia 2004 05:51, Rusty Russell napisał/a:
> Ani,
>
> 	I assume this should be in 2.6's drivers/video/riva/fbdev.c as
> well?
>
> Rusty.
>
Well, I've just checked rivafb under 2.6.1 and I didn't notice this mistake - 
there are good colours in Midnight Commander. Probably this bug was repaired 
somewhere in 2.5.
But I have no idea which options should I send to kernel to get different 
resolution (video=riva:800x600-16@85 don't work) and I have very ugly Linux 
logo while booting ;)
-- 
	===>  Goldi  <===
Linux user since Jan 16 2000 (#176912)
Proletariusze wszystkich krajów świata
używajcie systemu Linux!

Re: [PATCH] rivafb & small 16 bit mode problem

[Ingo Buescher]

On Thu, 22 Jan 2004, [iso-8859-2] Pawe? Goleniowski wrote:

> But I have no idea which options should I send to kernel to get different
> resolution (video=riva:800x600-16@85 don't work) and I have very ugly Linux
> logo while booting ;)

video=rivafb:800x600-16@85
          ^^

should work

IB
-- 
===========================================================================
Ingo Buescher <usenet-2004@r-arcology.de>
"Maneuvering with an army is advantageous; with an undisciplined
multitude, most dangerous." -- Sun Tzu

Re: [PATCH] rivafb & small 16 bit mode problem

[Peter Matthias]

Ingo Buescher schrieb:

> On Thu, 22 Jan 2004, [iso-8859-2] Pawe? Goleniowski wrote:
> 
>> But I have no idea which options should I send to kernel to get different
>> resolution (video=riva:800x600-16@85 don't work) and I have very ugly
Linux
>> logo while booting ;)
> 
> video=rivafb:800x600-16@85
>           ^^
> 
> should work

Well, even this does not work on my nforce 2 integrated grafics. Any clues?

Peter

Re: [PATCH] rivafb & small 16 bit mode problem

[James Simmons]

On Fri, 23 Jan 2004, Peter Matthias wrote:

> Ingo Buescher schrieb:
> 
> > On Thu, 22 Jan 2004, [iso-8859-2] Pawe? Goleniowski wrote:
> > 
> >> But I have no idea which options should I send to kernel to get different
> >> resolution (video=riva:800x600-16@85 don't work) and I have very ugly
> Linux
> >> logo while booting ;)
> > 
> > video=rivafb:800x600-16@85
> >           ^^
> > 
> > should work
> 
> Well, even this does not work on my nforce 2 integrated grafics. Any clues?

Its a bug in the driver in both 2.4.X and 2.6.X. I have some patches for 
i2c support but mode changing still didn't work for me :-(