From: Reinette Chatre <reinette.chatre@intel.com>
To: James Morse <james.morse@arm.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
shameerali.kolothum.thodi@huawei.com,
Jamie Iles <jamie@nuviainc.com>,
D Scott Phillips OS <scott@os.amperecomputing.com>
Subject: Re: [PATCH v3 00/24] x86/resctrl: Merge the CDP resources
Date: Fri, 4 Jun 2021 16:56:28 -0700 [thread overview]
Message-ID: <5900da79-b21e-e41c-6348-d9b24cf65967@intel.com> (raw)
In-Reply-To: <20210519162424.27654-1-james.morse@arm.com>
Hi James,
On 5/19/2021 9:24 AM, James Morse wrote:
> Hi folks,
>
> Thanks to Reinette comments on v2. The major changes in v3 is a juggling
> of all the commit messages. One patch got merged into its parent, and
> the msr_param range thing got pulled out into its own patch. Otherwise
> changes are noted in the commit messages.
Thank you very much for reworking the commit messages. The additional
context do make these changes easier to digest.
On a high level the goal of these patches look good to me but the
patches themselves do have a few formatting issues and spelling mistakes
and while bisectability is a stated goal of this work I was surprised to
find that one patch ("x86/resctrl: Apply offset correction when config
is staged") cannot compile.
I started to document the formatting issues but found myself duplicating
a lot of what checkpatch.pl would already tell you. Could you please
ensure that this series gets a clean bill of health when using
"checkpatch.pl --strict"? I also recommend the codespell option ...
there are a few typos in this series that checkpatch.pl was able to pick
up. It would be more efficient to review this series from such a baseline.
Thank you
Reinette
next prev parent reply other threads:[~2021-06-04 23:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 16:24 [PATCH v3 00/24] x86/resctrl: Merge the CDP resources James Morse
2021-05-19 16:24 ` [PATCH v3 01/24] x86/resctrl: Split struct rdt_resource James Morse
2021-05-19 16:24 ` [PATCH v3 02/24] x86/resctrl: Split struct rdt_domain James Morse
2021-05-19 16:24 ` [PATCH v3 03/24] x86/resctrl: Add a separate schema list for resctrl James Morse
2021-05-19 16:24 ` [PATCH v3 04/24] x86/resctrl: Pass the schema in info dir's private pointer James Morse
2021-05-19 16:24 ` [PATCH v3 05/24] x86/resctrl: Label the resources with their configuration type James Morse
2021-05-19 16:24 ` [PATCH v3 06/24] x86/resctrl: Walk the resctrl schema list instead of an arch list James Morse
2021-05-19 16:24 ` [PATCH v3 07/24] x86/resctrl: Store the effective num_closid in the schema James Morse
2021-05-19 16:24 ` [PATCH v3 08/24] x86/resctrl: Add resctrl_arch_get_num_closid() James Morse
2021-05-19 16:24 ` [PATCH v3 09/24] x86/resctrl: Pass the schema to resctrl filesystem functions James Morse
2021-05-19 16:24 ` [PATCH v3 10/24] x86/resctrl: Swizzle rdt_resource and resctrl_schema in pseudo_lock_region James Morse
2021-05-19 16:24 ` [PATCH v3 11/24] x86/resctrl: Move the schemata names into struct resctrl_schema James Morse
2021-05-19 16:24 ` [PATCH v3 12/24] x86/resctrl: Group staged configuration into a separate struct James Morse
2021-05-19 16:24 ` [PATCH v3 13/24] x86/resctrl: Allow different CODE/DATA configurations to be staged James Morse
2021-05-19 16:24 ` [PATCH v3 14/24] x86/resctrl: Rename update_domains() resctrl_arch_update_domains() James Morse
2021-05-19 16:24 ` [PATCH v3 15/24] x86/resctrl: Add a helper to read a closid's configuration James Morse
2021-05-19 16:24 ` [PATCH v3 16/24] x86/resctrl: Add a helper to read/set the CDP configuration James Morse
2021-05-19 16:24 ` [PATCH v3 17/24] x86/resctrl: Pass configuration type to resctrl_arch_get_config() James Morse
2021-05-19 16:24 ` [PATCH v3 18/24] x86/resctrl: Make ctrlval arrays the same size James Morse
2021-05-19 16:24 ` [PATCH v3 19/24] x86/resctrl: Apply offset correction when config is staged James Morse
2021-05-19 16:24 ` [PATCH v3 20/24] x86/resctrl: Calculate the index from the configuration type James Morse
2021-05-19 16:24 ` [PATCH v3 21/24] x86/resctrl: Merge the ctrl_val arrays James Morse
2021-05-19 16:24 ` [PATCH v3 22/24] x86/resctrl: Remove rdt_cdp_peer_get() James Morse
2021-05-19 16:24 ` [PATCH v3 23/24] x86/resctrl: Expand resctrl_arch_update_domains()'s msr_param range James Morse
2021-05-19 16:24 ` [PATCH v3 24/24] x86/resctrl: Merge the CDP resources James Morse
2021-06-04 23:56 ` Reinette Chatre [this message]
2021-06-11 18:04 ` [PATCH v3 00/24] " James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5900da79-b21e-e41c-6348-d9b24cf65967@intel.com \
--to=reinette.chatre@intel.com \
--cc=Babu.Moger@amd.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jamie@nuviainc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=scott@os.amperecomputing.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox