Re: [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC

Re: [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC

[Rob Herring]

On Sun, Apr 30, 2017 at 3:00 PM, Frank Rowand <frank.rowand@sony.com> wrote:
> An undeclared variable was used in a macro that evaluates to nothing
> when CONFIG_DEBUG_LOCK_ALLOC is not defined.  Change to use the correct
> variable that does exist.
>
> ---
>
> reported by kbuild test robot on on robh/for-next
>    https://lkml.org/lkml/2017/4/29/134

That's a bit misleading because I've not applied the offending patch.
Please squash this.

Rob

RE: [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC

[Rowand, Frank]

On Monday, May 01, 2017 1:13 PM, Rob Herring [mailto:robh+dt@kernel.org]  wrote:
>
> On Sun, Apr 30, 2017 at 3:00 PM, Frank Rowand <frank.rowand@sony.com>
> wrote:
>> An undeclared variable was used in a macro that evaluates to nothing
>> when CONFIG_DEBUG_LOCK_ALLOC is not defined.  Change to use the correct
>> variable that does exist.
>>
>> ---
>>
>> reported by kbuild test robot on on robh/for-next
>>    https://lkml.org/lkml/2017/4/29/134
>
> That's a bit misleading because I've not applied the offending patch.
> Please squash this.
>
> Rob

Does "squash this" mean to redo the original path to include this fix?

Thanks,

Frank

Re: [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC

[Frank Rowand]

On 05/01/17 14:20, Rowand, Frank wrote:
> On Monday, May 01, 2017 1:13 PM, Rob Herring [mailto:robh+dt@kernel.org]  wrote:
>>
>> On Sun, Apr 30, 2017 at 3:00 PM, Frank Rowand <frank.rowand@sony.com>
>> wrote:
>>> An undeclared variable was used in a macro that evaluates to nothing
>>> when CONFIG_DEBUG_LOCK_ALLOC is not defined.  Change to use the correct
>>> variable that does exist.
>>>
>>> ---
>>>
>>> reported by kbuild test robot on on robh/for-next
>>>    https://lkml.org/lkml/2017/4/29/134
>>
>> That's a bit misleading because I've not applied the offending patch.
>> Please squash this.
>>
>> Rob
> 
> Does "squash this" mean to redo the original path to include this fix?

                                               ^^^^  patch

> 
> Thanks,
> 
> Frank
> 

[PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC

[frowand.list]

From: Frank Rowand <frank.rowand@sony.com>

An undeclared variable was used in a macro that evaluates to nothing
when CONFIG_DEBUG_LOCK_ALLOC is not defined.  Change to use the correct
variable that does exist.

---

reported by kbuild test robot on on robh/for-next
   https://lkml.org/lkml/2017/4/29/134

   drivers/of/base.c: In function '__of_add_phandle_sysfs':
>> drivers/of/base.c:198:23: error: 'pp' undeclared (first use in this function)
     sysfs_bin_attr_init(&pp->attr);

Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---
 drivers/of/base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 9fe42346925b..8a7ca2a49ba8 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -195,7 +195,7 @@ int __of_add_phandle_sysfs(struct device_node *np)
 	if (!np->phandle || np->phandle == 0xffffffff)
 		return 0;
 
-	sysfs_bin_attr_init(&pp->attr);
+	sysfs_bin_attr_init(&np->attr_phandle);
 	np->attr_phandle.attr.name = "phandle";
 	np->attr_phandle.attr.mode = 0444;
 	np->attr_phandle.size = sizeof(np->phandle);
-- 
Frank Rowand <frank.rowand@sony.com>