From: "Shen, Xiaochen" <xiaochen.shen@intel.com>
To: tglx@linutronix.de, linux-kernel@vger.kernel.org, x86@kernel.org
Cc: Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH] x86/intel_rdt: Fix two typos in Documentation
Date: Wed, 03 May 2017 11:29:33 +0800 [thread overview]
Message-ID: <59094E9D.6000103@intel.com> (raw)
In-Reply-To: <1491498581-21735-1-git-send-email-xiaochen.shen@intel.com>
Sorry, please ignore this patch.
The first typo in this patch has been already fixed by:
a9cad3d4f046 ("Documentation, x86: Intel Memory bandwidth allocation")
A new patch is submitted to address the other typo left over:
https://lkml.org/lkml/2017/5/2/595
Best regards
Xiaochen Shen
On 2017/4/7 1:09, Xiaochen Shen wrote:
> Both typos are in example 3.
>
> Because cache id 0 is the only cache id, the ";" is redundant in
> "# echo "L3:0=ffc00;" > p0/schemata".
>
> And "C0" in "# echo C0 > p0/cpus" is wrong because it specifies core
> 6-7 instead of wanted core 4-7.
>
> Correct the typos to avoid confusion.
>
> Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> ---
> Documentation/x86/intel_rdt_ui.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/x86/intel_rdt_ui.txt b/Documentation/x86/intel_rdt_ui.txt
> index 51cf6fa..cd752c1 100644
> --- a/Documentation/x86/intel_rdt_ui.txt
> +++ b/Documentation/x86/intel_rdt_ui.txt
> @@ -206,12 +206,12 @@ Next we make a resource group for our real time cores and give
> it access to the "top" 50% of the cache on socket 0.
>
> # mkdir p0
> -# echo "L3:0=ffc00;" > p0/schemata
> +# echo "L3:0=ffc00" > p0/schemata
>
> Finally we move core 4-7 over to the new group and make sure that the
> kernel and the tasks running there get 50% of the cache.
>
> -# echo C0 > p0/cpus
> +# echo F0 > p0/cpus
>
> 4) Locking between applications
>
next prev parent reply other threads:[~2017-05-03 3:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 17:09 [PATCH] x86/intel_rdt: Fix two typos in Documentation Xiaochen Shen
2017-05-03 3:29 ` Shen, Xiaochen [this message]
2017-05-09 7:30 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59094E9D.6000103@intel.com \
--to=xiaochen.shen@intel.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox