From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/3] of: fix sparse warning in of_pci_range_parser_one
Date: Thu, 4 May 2017 22:16:03 -0700 [thread overview]
Message-ID: <590C0A93.4080000@gmail.com> (raw)
In-Reply-To: <20170504180035.12834-2-robh@kernel.org>
On 05/04/17 11:00, Rob Herring wrote:
> sparse gives the following warning for 'pci_space':
>
> ../drivers/of/address.c:266:26: warning: incorrect type in assignment (different base types)
> ../drivers/of/address.c:266:26: expected unsigned int [unsigned] [usertype] pci_space
> ../drivers/of/address.c:266:26: got restricted __be32 const [usertype] <noident>
>
> It appears that pci_space is only ever accessed on powerpc, so the endian
> swap is often not needed.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/of/address.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index 02b2903fe9d2..72914cdfce2a 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -263,7 +263,7 @@ struct of_pci_range *of_pci_range_parser_one(struct of_pci_range_parser *parser,
> if (!parser->range || parser->range + parser->np > parser->end)
> return NULL;
>
> - range->pci_space = parser->range[0];
> + range->pci_space = be32_to_cpup(parser->range);
> range->flags = of_bus_pci_get_flags(parser->range);
> range->pci_addr = of_read_number(parser->range + 1, ns);
> range->cpu_addr = of_translate_address(parser->node,
>
Reviewed-by: Frank Rowand <frank.rowand@sony.com>
next prev parent reply other threads:[~2017-05-05 5:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 18:00 [PATCH 1/3] of: fix sparse warnings in of_find_next_cache_node Rob Herring
2017-05-04 18:00 ` [PATCH 2/3] of: fix sparse warning in of_pci_range_parser_one Rob Herring
2017-05-05 5:16 ` Frank Rowand [this message]
2017-05-04 18:00 ` [PATCH 3/3] of: fix sparse warnings in fdt, irq, and resolver code Rob Herring
2017-05-05 5:16 ` Frank Rowand
2017-05-05 5:15 ` [PATCH 1/3] of: fix sparse warnings in of_find_next_cache_node Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=590C0A93.4080000@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox