From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753541AbdEENbE (ORCPT ); Fri, 5 May 2017 09:31:04 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:39501 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751837AbdEENbC (ORCPT ); Fri, 5 May 2017 09:31:02 -0400 Subject: Re: [PATCH] Fixed a pathing issue with objdump and grep To: Adam Stylinski References: <20170505125710.GG7891@kernel.org> <590C7CB2.6000409@linux.vnet.ibm.com> Cc: Arnaldo Carvalho de Melo , Alexander Shishkin , Christian Borntraeger , Peter Zijlstra , Taeung Song , linux-kernel@vger.kernel.org, Ravi Bangoria From: Ravi Bangoria Date: Fri, 5 May 2017 19:00:47 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <590C7CB2.6000409@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17050513-0048-0000-0000-0000017824EE X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007025; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000209; SDB=6.00856520; UDB=6.00424083; IPR=6.00635789; BA=6.00005326; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015322; XFM=3.00000014; UTC=2017-05-05 13:30:59 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17050513-0049-0000-0000-00004102581B Message-Id: <590C7E87.3040807@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-05_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705050138 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 05 May 2017 06:52 PM, Ravi Bangoria wrote: > > On Friday 05 May 2017 06:27 PM, Arnaldo Carvalho de Melo wrote: >> Em Wed, May 03, 2017 at 12:12:23PM +0000, Adam Stylinski escreveu: >>> The path fed to the argument for objdump used in the perf-annotate >>> feature didn't escape spaces. The subsequent argument to grep for >>> the name of the DSO containing symbols also assumed no spaces existed >>> in the pathname, so grep also parsed these as extra positional >>> arguments. >> This one didn't apply to tip/perf/urgent, so I tried another patch >> addressing the same issue, from Ravi Bangoria, and it applied, ok? > Oh, I was not aware about this patch. Coincidently, I sent the same fix. :) BTW, Adam, Looks like you have older code. The same line was recently changed by Taeung Song in commit e7cb9de211ebb29. I don't see that change in your code. Ravi