From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751176AbdEIXdg (ORCPT ); Tue, 9 May 2017 19:33:36 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:28026 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbdEIXde (ORCPT ); Tue, 9 May 2017 19:33:34 -0400 X-AuditID: b6c32a35-f79806d000002bf4-14-591251cbbf59 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <591251CB.6000505@samsung.com> Date: Wed, 10 May 2017 08:33:31 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: myungjoo.ham@samsung.com, Dan Carpenter , "lgirdwood@gmail.com" , "broonie@kernel.org" , "krzk@kernel.org" , Bartlomiej Zolnierkiewicz Cc: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] regulator: max8997/8966: fix charger cv voltage set bug In-reply-to: <20170508054544epcms1p6d3d429e6f062e987adf72fc2c04ed159@epcms1p6> X-Brightmail-Tracker: H4sIAAAAAAAAA02SeUgUcRTH+TnHjtXWtGm9DGsb6A8XXJ31GkvDyGIjiY3+0SLWSSdXdA92 dkWNKIvKxC6PDgmSArGNPFYrFSwxKyLR8ko7tpu0yNjMo+ia3en67/Pe7/t+770vj8JUp8gQ KtviEOwWPpchZ+FXb4ZFhHdvVqVFekcQ13i6nuAqX7wmufc/TuHclUdLuN7eBgU3NVAcwPW3 nSW5x0W1ZBKlb616qtC7XYdJvffNI1x/tNmF9BPupQZiq5BgEvhMwa4WLBnWzGxLViKzcYtx rTEmNpINZ+O5OEZt4c1CIpOcYghfn50rjcKo8/hcp5Qy8KLIRKxOsFudDkFtsoqORGYby+q0 bGScVqfTaaOjtq/UxUiSdMFUNp1nOzY7f7Kyn9yLRqkSRFFAR0P3QGoJCpRwIdz31JMlaBal olsQjIy/RHIwgeB8xSVcVkkFrWXEX9Wt3tuY70FJz4eZcg/u+xWjl0FXX44vjdFhMPq5DJf1 HgT7xst+6zVwuajDzzi9AtqGHpM+JqX8jdFhP8+jl8PgzCvk42A6FVrPTSl8HwXRPxGUV3zy T4HRxQguXzjuH28BnQKN3o+EjwPpTdDY/9YvAtqlgC+DNUheOhTccmegk+HMj5NI5gXw7k6z QuYQKBp7ESDXHkLQdNaDy4HU7dnFIkJWRcGz5x5MXnQujE+WEnIDJRQfVMkSPdwZfkfK6TVw oyFMtqIDQftXL3Ecqav+c6/qn3tV/7lXjTAXWijYRHOWILI2VivyZtFpydJmWM1u5D9KTUwL quhJ6UQ0hZg5SkP7/DQVweeJBeZOBBTGBClhnSpNpczkCwoFu9Vod+YKYieKkcw/gYUEZ1il E7c4jGx0fGR0rE46u3iWZRYpg+uHUlV0Fu8QcgTBJtj/1AVQgSF7UemBzoK7K7qure/LTw9q as4feJ20Q1P78MKupy1Na6r3hdU5x77ZF1/Zg5XkV+a8je0ANO2aGvxOLDI1jBncCW7rftey xOJVPTWpwTOFodnJX2zXvYt3f+t/VdN+b16HceuTMxt2PGiOu1oXeqQ26cPQzHfN+ZH28tLZ dQ26vE9RO10MLpp4VoPZRf4XRFU3N6oDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRmVeSWpSXmKPExsVy+t9jAd3TgUKRBt2N6hYbZ6xntZj68Amb xet/01kstt6Stjh/fgO7xbcrHUwWl3fNYbO43biCzYHDY+esu+wem1Z1snl8fHqLxaNvyypG j8+b5AJYo9xsMlITU1KLFFLzkvNTMvPSbZVCQ9x0LZQU8hJzU22VInR9Q4KUFMoSc0qBPCMD NODgHOAerKRvl+CWMel7WUE/d8XXqZfZGhhfcHQxcnJICJhInNk5iRXCFpO4cG89WxcjF4eQ wDZGiVsNy1lAErwCghI/Jt8Dsjk4mAXkJY5cyoYw1SWmTMmFKH/AKNG24zMrRLmWxNrGA8wg NouAqsSua7fZQGw2oPj+FzfAbH4BRYmrPx4zgswRFYiQ6D5RCTJHRKCRSWJf604WEIdZoINR YsO95UwgDcICPhIbP75nhdh2gFGiaV4fI0iCU8BPYuPl56wTGAVnIbl1FsKtsxBuXcDIvIqR K7WgODc9t9iowHATIzDGth3W8t/B+ONs9CFGAQ5GJR7eDFmhSCHWxLLiytxDjBIczEoivBKu QCHelMTKqtSi/Pii0pzU4kOMpkDvTWSWEk3OB8Z/Xkm8oYmlkYmBmZmhkYGxmZI474TALxFC AumJJanZqakFqUUwfUwcnFINjPkHt24q2iLVXFmp9umf89ln393cWc6djHp25ELxuXWv5k0u 3uT4xWuCPHOxpXuRw5V3f7malcW/ZDi88ndjrvrZsYojRyaTw2eZ0tPzcgvqPO4bMLW4xOuV N/Q+lLDoejZV4kLmPLlT9q55l51d2R7xs989OfPpEuO8sh3nb3scOPDLiOdCvBJLcUaioRZz UXEiABivjA3HAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170509233331epcas1p4b42248de206146904ebe1f1c5b88a35e X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170428141118epcas2p42c864cf574cc6fa3ffedbef22029e3ef X-RootMTR: 20170428141118epcas2p42c864cf574cc6fa3ffedbef22029e3ef References: <20170428141103.llm5t44o2vf46y5c@mwanda> <20170508054544epcms1p6d3d429e6f062e987adf72fc2c04ed159@epcms1p6> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 05월 08일 14:45, MyungJoo Ham wrote: > > When min charger-CV is <= 4.0V and max charger-CV is >= 4.0V, > we can use 4.00V as CV (register value = 0x1).` > > The original code had a typo that wrote ">=" (max_uV >= 4000000), > which should've been "<", which is not necessary anyway > as mentioned by Dan Carpenter. > > Reported-By: Dan Carpenter > Signed-off-by: MyungJoo Ham > --- > drivers/regulator/max8997-regulator.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/regulator/max8997-regulator.c b/drivers/regulator/max8997-regulator.c > index efabc0e..559b9ac 100644 > --- a/drivers/regulator/max8997-regulator.c > +++ b/drivers/regulator/max8997-regulator.c > @@ -428,12 +428,9 @@ static int max8997_set_voltage_charger_cv(struct regulator_dev *rdev, > if (max_uV < 4000000 || min_uV > 4350000) > return -EINVAL; > > - if (min_uV <= 4000000) { > - if (max_uV >= 4000000) > - return -EINVAL; > - else > - val = 0x1; > - } else if (min_uV <= 4200000 && max_uV >= 4200000) > + if (min_uV <= 4000000) > + val = 0x1; > + else if (min_uV <= 4200000 && max_uV >= 4200000) > val = 0x0; > else { > lb = (min_uV - 4000001) / 20000 + 2; > Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics