From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932466AbdEOEFo (ORCPT ); Mon, 15 May 2017 00:05:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36770 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbdEOEFn (ORCPT ); Mon, 15 May 2017 00:05:43 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EF0924E03F Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=xpang@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com EF0924E03F Reply-To: xlpang@redhat.com Subject: Re: [PATCH v2 1/3] sched/deadline: Zero out positive runtime after throttling constrained tasks References: <1494559929-11462-1-git-send-email-xlpang@redhat.com> To: Xunlei Pang , linux-kernel@vger.kernel.org Cc: Peter Zijlstra , Juri Lelli , Ingo Molnar , Steven Rostedt , Luca Abeni , Daniel Bristot de Oliveira From: Xunlei Pang Message-ID: <5919296B.70806@redhat.com> Date: Mon, 15 May 2017 12:07:07 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1494559929-11462-1-git-send-email-xlpang@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 15 May 2017 04:05:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12/2017 at 11:32 AM, Xunlei Pang wrote: > When a contrained task is throttled by dl_check_constrained_dl(), > it may carry the remaining positive runtime, as a result when > dl_task_timer() fires and calls replenish_dl_entity(), it will > not be replenished correctly due to the positive dl_se->runtime. > > This patch assigns its runtime to 0 if positive after throttling. > > Fixes: df8eac8cafce ("sched/deadline: Throttle a constrained deadline task activated after the deadline) > Acked-by: Daniel Bristot de Oliveira > Signed-off-by: Xunlei Pang Hi Peter, According to the previous discussion with Luca, please ignore the last two patches of this series. Could you please only help review or pick up this one? Regards, Xunlei > --- > kernel/sched/deadline.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index a2ce590..d3d291e 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -723,6 +723,8 @@ static inline void dl_check_constrained_dl(struct sched_dl_entity *dl_se) > if (unlikely(dl_se->dl_boosted || !start_dl_timer(p))) > return; > dl_se->dl_throttled = 1; > + if (dl_se->runtime > 0) > + dl_se->runtime = 0; > } > } >