From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: topology: Fix incorrect addressing assignments
Date: Wed, 18 Sep 2024 16:29:37 +0200 [thread overview]
Message-ID: <591ee483-9370-4a8a-9cd0-b3d8ccb555bd@linux.intel.com> (raw)
In-Reply-To: <20240914081608.3514-1-tangbin@cmss.chinamobile.com>
On 9/14/2024 10:16 AM, Tang Bin wrote:
> The variable 'kc' is handled in the function
> soc_tplg_control_dbytes_create(), and 'kc->private_value'
> is assigned to 'sbe', so In the function soc_tplg_dbytes_create(),
> the right 'sbe' should be 'kc.private_value', the same logical error
> in the function soc_tplg_dmixer_create(), thus fix them.
>
> Fixes: 0867278200f7 ("ASoC: topology: Unify code for creating standalone and widget bytes control")
> Fixes: 4654ca7cc8d6 ("ASoC: topology: Unify code for creating standalone and widget mixer control")
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
My mistake, thanks!
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
next prev parent reply other threads:[~2024-09-18 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 8:16 [PATCH] ASoC: topology: Fix incorrect addressing assignments Tang Bin
2024-09-18 14:29 ` Amadeusz Sławiński [this message]
2024-09-19 15:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=591ee483-9370-4a8a-9cd0-b3d8ccb555bd@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tangbin@cmss.chinamobile.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox