From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>, alsa-devel@alsa-project.org
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Cezary Rojewski" <cezary.rojewski@intel.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Jie Yang" <yang.jie@linux.intel.com>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Takashi Iwai" <tiwai@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/4] Make headphone work on Huawei Matebook D15
Date: Thu, 7 Apr 2022 14:01:27 -0500 [thread overview]
Message-ID: <591f1596-a2be-309c-4f61-0d58ab0effc0@linux.intel.com> (raw)
In-Reply-To: <cover.1649357263.git.mchehab@kernel.org>
On 4/7/22 13:49, Mauro Carvalho Chehab wrote:
> Huawei Matebook D15 uses two different GPIOs are used to control the output:
>
> - gpio0 controls the speaker output;
> - gpio1 controls the headphone output.
>
> Changing both at the same time cause spurious events that are mis-interpreted
> as input events, causing troubles on apps. So, a delay is needed before turning
> on such gpios.
>
> Also, the headset microphone is connected to MIC1, instead of MIC2 port.
>
> With this patch, plugging a headphone causes a jack event to trigger the speaker
> supply, powering down the speaker and powering up the headphone output.
> Removing the headphone also triggers the power supply, powering up the speaker
> and powering down the headphone.
>
> The headset microphone also works.
For the series:
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thanks Mauro for your work, much appreciated.
>
> ---
>
> v5:
> - dropped an uneeded differential mux from the boards driver.
>
> v4:
> - add support for headset microphone on MIC1 port.
>
> v3:
> - add a patch changing GPIO quirk speaker naming. Patch 2 got rebased on the top of it.
>
> Mauro Carvalho Chehab (3):
> ASoC: Intel: sof_es8336: support a separate gpio to control headphone
> ASoC: Intel: sof_es8336: add a quirk for headset at mic1 port
> ASoC: Intel: sof_es8336: Add a quirk for Huawei Matebook D15
>
> Pierre-Louis Bossart (1):
> ASoC: Intel: sof_es8336: simplify speaker gpio naming
>
> sound/soc/intel/boards/sof_es8336.c | 117 +++++++++++++++++++++-------
> 1 file changed, 89 insertions(+), 28 deletions(-)
>
next prev parent reply other threads:[~2022-04-07 19:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 18:49 [PATCH v5 0/4] Make headphone work on Huawei Matebook D15 Mauro Carvalho Chehab
2022-04-07 18:49 ` [PATCH v5 1/4] ASoC: Intel: sof_es8336: simplify speaker gpio naming Mauro Carvalho Chehab
2022-04-07 18:49 ` [PATCH v5 2/4] ASoC: Intel: sof_es8336: support a separate gpio to control headphone Mauro Carvalho Chehab
2022-04-07 18:49 ` [PATCH v5 3/4] ASoC: Intel: sof_es8336: add a quirk for headset at mic1 port Mauro Carvalho Chehab
2022-04-07 18:49 ` [PATCH v5 4/4] ASoC: Intel: sof_es8336: Add a quirk for Huawei Matebook D15 Mauro Carvalho Chehab
2022-04-07 19:01 ` Pierre-Louis Bossart [this message]
2022-04-08 11:24 ` [PATCH v5 0/4] Make headphone work on " Mark Brown
2022-04-12 17:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=591f1596-a2be-309c-4f61-0d58ab0effc0@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox