From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7F2A3328F0 for ; Wed, 7 Jan 2026 20:02:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767816178; cv=none; b=qM7uoHB48XtsPMoW2sCw0+O9c068r0ZAebWMuO0Uz5tpqVAKaH54HOJzR67o/y7jCHFXpTLZWlDQsns0+EXfjnBsdO/GHHzWyNM4h6Rtw02TsaC40uBwvm1FaE8RomiqNQ0NQbwIZ4XdJHIzYGzjrPcsye6OXJebQKeBPhV1KFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767816178; c=relaxed/simple; bh=C56IoC/7pKu7IOe+bmIo3KG0TqDEmn/tNomGMdAluCU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=UOSDkfh4DIrmzhvC9PuQhgfWFu1DNAvDAL0PMgBb0nZrbC5YapQMot99qfAWcd0pk12mHT5uvp8QtVwFMvmwmVShowwC9lATQ6dFBavLFXMvzZDzOxpJYMUU1Epk9RPWSgvojNBJb9THjIaJyzKWqvwNCEasBPZv7vjA3n9AeUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fx7DRgq0; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=YRF5tVBf; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fx7DRgq0"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="YRF5tVBf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767816174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Iu+APFi4DB1BEixYf1NERY7bmC13ljDpUozQin2rblQ=; b=fx7DRgq0aRftvVxmFO7vKuj1KsVZde4v1libfEZMdoD9L+gYzFLiODi1qbQTOWca2LTDbF Kd3yqWncnDze4xMKsAFm7ySOOKwdFQtoeCO3OV/8TJD/o1uom1QmR/FpINyok/ymYVQKx0 lXpmn7fdSXgRtBgtFowNbGBfbwJ6K/Y= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-520-Mqenrk5KPBS6Pe70oXveiw-1; Wed, 07 Jan 2026 15:02:53 -0500 X-MC-Unique: Mqenrk5KPBS6Pe70oXveiw-1 X-Mimecast-MFC-AGG-ID: Mqenrk5KPBS6Pe70oXveiw_1767816172 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-790b7b3e56cso14077477b3.2 for ; Wed, 07 Jan 2026 12:02:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767816172; x=1768420972; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Iu+APFi4DB1BEixYf1NERY7bmC13ljDpUozQin2rblQ=; b=YRF5tVBf9i7M3G5iQCY/sPLkSHWaxqfgtZHG8OxXCLDNiRf2uHMROuL5CqDEiVHU2w c5WLUpgAZQtP/0Aft0cnGSHfWsTEJ5NADIgYAPMwYDio7aQR+iSwtQXOzzQXmIKlHu2C qmll2rAppmwYq6Smi+BjH91cYp7fYx/w28rRO1ESkHG04jCpbZUqaC0WxJgFjTUqAKga QzG81ANGW42MdRv9UUNnDSTbJeFU/06DUzysqWRbCz+R2NjgAH0UFQEp2MF6am+xAaQp 0t8phTolrASVZMQx2X8tczyqD6LmGTzrW8zHsyeGqnbUMLMoWPhTDWMtQx1voGAyKkdJ +09w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767816172; x=1768420972; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Iu+APFi4DB1BEixYf1NERY7bmC13ljDpUozQin2rblQ=; b=fTvXOoNNVwiN/4A3UE+n5XrYeo1f1Urtn+JSOW9ymXrMAvINXpQl6lYHxQ3amnRpsU m8W7pAIF+AwqS64HFxqLCHAr1QCTal5iWyUkDTBgzQWnI77mOEhAVeHtluN6GL5FuNxj uB9KkZbnf4MJMESvxknmenowV5lSEY2yXSSeJtS+yYwzcE0dXUa9GiUFIg/8igOd4zRb 7NksMSAHJ66E02qfx+g54doJ2hRo0eqDiZwgHXB4Lv2B5Ps5oguY8uwJ7ejkN0/E6H8Q GQeJfZAuohvu0+vrFvEmLOktgkV1gY89E+BiAUcXnsgeanV8YpTLQPcW4hvjyhbJNGhA p3lQ== X-Forwarded-Encrypted: i=1; AJvYcCVIt5ywJJedmdQnkHRbqDW7Nd1Q3G9nlRFYoSnNp/4q+t3fBsJdklA5zkgyxF3Wem0oAzD37iYqRWK9wAI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7REZaxYXr7HAvUjBLqrnNOITU+Q3UGU4lkpc/pRyPod7gj3Tz wvA874NlRnKCwoIrNOz2YLMyFVoIJKQWAMTHl6fH18zEn5f/Ivh+bLLiso3nllgsuDDk0XGuci2 gCdNws9V2nCgHJzO7AOcNzhxVt9ymwX1McQCagEgAOFqweRJRB8q81PtTN0b7U3pIXg== X-Gm-Gg: AY/fxX4Jd+J6P9le0bWC8oJ67HxhL+qCz7GIIOzuFmCBr3+dT5OV2PQnYLBrk3epYqB hehlSOgNHk2hvVSn979BWlv4NHiNb2bmP8L48AQ11n4uu8J/tZSZ7TCf+iUtowfaVHoICCE3jL7 buI/4UuXrgQdJ5nR3yCh1FLEE6RHaGbpraiJ1ap/rAc59mc4BRNT3VE4v4/sqzABeOE09icuhFt EL7F/Ruptz8g62MjBBCSzZfvzUY4Ibkt/vxKri0Hr2f9JRfaMUuhSCiYeDFXjYlO1U0TAijDWgB Ya9JPMSQGr0NSlxLtJMCpEJ8bEmFm40dG35i+And8KNnuODws3cljaF3JWwWVmXPQhGvlT06Azs tk9lmO66TXLpAu4VH1B5+2E4eEjizLuCUZNNrdNR7 X-Received: by 2002:a05:690c:6002:b0:78c:8cf2:e1a8 with SMTP id 00721157ae682-790b57fd697mr35186667b3.41.1767816172487; Wed, 07 Jan 2026 12:02:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IFFtanv8xfnFTTRT6tEbrRIY8LovgzhbuRiJibqFx8Wg+Ad59na27viUk0nz6iFz80kLE3f9Q== X-Received: by 2002:a05:690c:6002:b0:78c:8cf2:e1a8 with SMTP id 00721157ae682-790b57fd697mr35186317b3.41.1767816172118; Wed, 07 Jan 2026 12:02:52 -0800 (PST) Received: from li-4c4c4544-0032-4210-804c-c3c04f423534.ibm.com ([2600:1700:6476:1430::41]) by smtp.gmail.com with ESMTPSA id 00721157ae682-790aa5534f2sm22153297b3.10.2026.01.07.12.02.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 12:02:51 -0800 (PST) Message-ID: <591f69efdf89ba02c36b042faa3486eca0cec76d.camel@redhat.com> Subject: Re: [EXTERNAL] [PATCH 5/6] ceph: don't allow delegations to be set on directories From: Viacheslav Dubeyko To: Jeff Layton , Christian Brauner , Al Viro , Jan Kara , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Trond Myklebust , Anna Schumaker , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Andreas Gruenbacher , Xiubo Li , Ilya Dryomov , Hans de Goede , NeilBrown Cc: Christoph Hellwig , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, v9fs@lists.linux.dev, gfs2@lists.linux.dev, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org Date: Wed, 07 Jan 2026 12:02:49 -0800 In-Reply-To: <20260107-setlease-6-19-v1-5-85f034abcc57@kernel.org> References: <20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org> <20260107-setlease-6-19-v1-5-85f034abcc57@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-01-07 at 09:20 -0500, Jeff Layton wrote: > With the advent of directory leases, it's necessary to set the > ->setlease() handler in directory file_operations to properly deny them. >=20 > Fixes: e6d28ebc17eb ("filelock: push the S_ISREG check down to ->setlease= handlers") > Signed-off-by: Jeff Layton > --- > fs/ceph/dir.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c > index 86d7aa594ea99335af3e91a95c0a418fdc1b8a8a..804588524cd570078ba59bf38= d2460950ca67daf 100644 > --- a/fs/ceph/dir.c > +++ b/fs/ceph/dir.c > @@ -2214,6 +2214,7 @@ const struct file_operations ceph_dir_fops =3D { > .fsync =3D ceph_fsync, > .lock =3D ceph_lock, > .flock =3D ceph_flock, > + .setlease =3D simple_nosetlease, > }; > =20 > const struct file_operations ceph_snapdir_fops =3D { > @@ -2221,6 +2222,7 @@ const struct file_operations ceph_snapdir_fops =3D = { > .llseek =3D ceph_dir_llseek, > .open =3D ceph_open, > .release =3D ceph_release, > + .setlease =3D simple_nosetlease, > }; > =20 > const struct inode_operations ceph_dir_iops =3D { Looks good. Reviewed-by: Viacheslav Dubeyko Thanks, Slava.