Re: [PATCH v4 2/3] sched: make migrate_enable/migrate_disable inline

Alexei Starovoitov
2025-09-16T16:27:23Z

On Tue, Sep 16, 2025 at 4:07 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Thu, Aug 28, 2025 at 02:03:53PM +0800, Menglong Dong wrote:
>
> > +/* The "struct rq" is not available here, so we can't access the
> > + * "runqueues" with this_cpu_ptr(), as the compilation will fail in
> > + * this_cpu_ptr() -> raw_cpu_ptr() -> __verify_pcpu_ptr():
> > + * typeof((ptr) + 0)
> > + *
> > + * So use arch_raw_cpu_ptr()/PERCPU_PTR() directly here.
> > + */
>
> Please fix broken comment style while you fix that compile error.

+1

We switched to normal kernel comment style in bpf land quite some
time ago, but old habits die hard and I have to keep reminding people
to use normal comments in all new code.