From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763358AbdEWJ0W (ORCPT ); Tue, 23 May 2017 05:26:22 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:37017 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763327AbdEWJ0Q (ORCPT ); Tue, 23 May 2017 05:26:16 -0400 X-AuditID: b6c32a2e-f79506d0000046c0-d3-59240035788a MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <59240034.9070201@samsung.com> Date: Tue, 23 May 2017 18:26:12 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] extcon: Allow extcon drivers to specify the extcon name In-reply-to: <20170421130119.6187-1-hdegoede@redhat.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMKsWRmVeSWpSXmKPExsWy7bCmlq4pg0qkwdHZQhZvjk9nsri8aw6b xe3GFWwOzB7v911l8+jbsorR4/MmuQDmqFSbjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0Nd Q0sLcyWFvMTcVFslF58AXbfMHKBFSgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWhDQyM9 QwNzPSMjIz0T41grI1OgkoTUjGlXzrEVnOSqmH3Cr4HxCEcXIyeHhICJxNU7b5khbDGJC/fW s3UxcnEICSxllNi9oYsVwvnMKHGwrZOli5EDrOPeHQ6I+FpGicm7D4B18woISvyYfA+shllA XuLIpWyQMLOApsTW3evZIervMUr0Ns1lhajXklg/+ScbiM0ioCrRvWU7I4jNBhTf/+IGWJxf QFHi6o/HYHFRgQiJnfO/sYPYIgJBEje+r2CFWKAg8eveJjBbGCi+8tdtFhCbU8BCYs2nHlaI zz6zSbxo04G4X1Zi0wGoh10kOp9PhCoRlnh1fAs7hC0l0d0xC+xmCYF2RonNc0D+AnE6GCXu r2yE6jCWONXVyARxBJ9E7+8nTBALeCU62oQgSjwk1m1fxwRhO0o8OXgPGrrdjBKnv6xinsCo MAsp7GYhwm4WUtgtYGRexSiWWlCcm55abFpgrFecmFtcmpeul5yfu4kRnOC09HYw/lvgfYhR gINRiYdXYL1ypBBrYllxZe4hRgkOZiUR3sPfgUK8KYmVValF+fFFpTmpxYcYTYFBP5FZSjQ5 H5h880riDU0sDUxMzYwNjA0tLJXEeTVWXosQEkhPLEnNTk0tSC2C6WPi4JRqYDSt537Zxn9j wa6MtTtNq8Te34gLVmm7FMtpc9Bg4d+waJPFAgl/1vd4vlKefjJR6EObgVV+Cl/tNLWODVc0 +prcVwaIfjhgNEWea/f27gPXJ0YVnLn6e5+o+LaSkyv726MYVn7yfJL+6KP/u18ZIbsEp24/ 7usRrcv3bMdW87YV9lH9Eif6GZVYijMSDbWYi4oTAcZqjXSGAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIIsWRmVeSWpSXmKPExsVy+t9jQV1TBpVIgw0fGS3eHJ/OZHF51xw2 i9uNK9gcmD3e77vK5tG3ZRWjx+dNcgHMUW42GamJKalFCql5yfkpmXnptkqhIW66FkoKeYm5 qbZKEbq+IUFKCmWJOaVAnpEBGnBwDnAPVtK3S3DLmHblHFvBSa6K2Sf8GhiPcHQxcnBICJhI 3LsDZHICmWISF+6tZ+ti5OIQEljNKHHt8CxGkASvgKDEj8n3WEDqmQXkJY5cygYJMwuoS0ya t4gZov4Bo8S3PX+g6rUk1k/+yQZiswioSnRv2Q4WZwOK739xAyzOL6AocfXHY0aQmaICERLd JypBwiICARI/T/WzQ8xXkPh1bxMriC0MFJ/W8pEdYlcvo8T0vh3MIAlOAQuJNZ96WCcwCs5C cuoshFNnITl1ASPzKkau1ILi3PTcYqMCo02MwOjYdlgrYAdj07noQ4wCHIxKPLwzXJUjhVgT y4orcw8xSnAwK4nwHv4OFOJNSaysSi3Kjy8qzUktPsRoCvTdRGYp0eR8YOTmlcQbmlgamRiY mRkaGRibKYnzTgj8EiEkkJ5YkpqdmlqQWgTTx8TBKdXAuJf37qw1Jh7fF91QfNMkae3/vv5b 2TMvV/1feefuyab8NPnxOZH9ZgzLS67etdxs8S/lu3rqtNyOFbodzWG2b19w5sAVyZbLsj7r 7zs3bm0SEZnn1/dyoWaejpF14Aary2zxe5L51ouwJK4oYPoUpP/qr9XEcjUlz+CMNbN3tUZz 5ryf7yuvxFKckWioxVxUnAgABimi1qQCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170523092613epcas5p2ac0c2243340fd6c016160894249ff890 X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170421130123epcas4p12e891d305aa2b4126089e691d15c6659 X-RootMTR: 20170421130123epcas4p12e891d305aa2b4126089e691d15c6659 References: <20170421130119.6187-1-hdegoede@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, I'm sorry for late reply. On 2017년 04월 21일 22:01, Hans de Goede wrote: > The parent device name is not necessarily always useful, e.g. > with i2c devices it may simply be e.g.: "0-0022" and it also depends > on the i2c-bus number which depends on probe ordering. > > This commit allows drivers to set their own, more useful name, > avoiding the problems with some i2c-device names. > > Signed-off-by: Hans de Goede > --- > drivers/extcon/extcon.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c > index f422a78..f8d3c1b 100644 > --- a/drivers/extcon/extcon.c > +++ b/drivers/extcon/extcon.c > @@ -1117,7 +1117,8 @@ int extcon_dev_register(struct extcon_dev *edev) > edev->dev.class = extcon_class; > edev->dev.release = extcon_dev_release; > > - edev->name = dev_name(edev->dev.parent); > + if (!edev->name) > + edev->name = dev_name(edev->dev.parent); I think that the variables of 'struct extcon_dev' should be modified by extcon core. I don't want to touch the variables of 'struct extcon_dev' by extcon provider driver. > if (IS_ERR_OR_NULL(edev->name)) { > dev_err(&edev->dev, > "extcon device name is null\n"); > -- Best Regards, Chanwoo Choi Samsung Electronics