From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936824AbdEWJnf (ORCPT ); Tue, 23 May 2017 05:43:35 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:34314 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932938AbdEWJnc (ORCPT ); Tue, 23 May 2017 05:43:32 -0400 X-AuditID: b6c32a2d-f792a6d0000055a1-3a-59240442bc55 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <59240441.9090208@samsung.com> Date: Tue, 23 May 2017 18:43:29 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Arvind Yadav , myungjoo.ham@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, kgene@kernel.org, javier@osg.samsung.com Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] PM / devfreq: exynos-nocp : Handle return value of clk_prepare_enable In-reply-to: <1495191035-15882-1-git-send-email-arvind.yadav.cs@gmail.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKJsWRmVeSWpSXmKPExsWy7bCmuq4Ti0qkwevNfBbXehcyW7x5u4bJ ov/xa2aL8+c3sFucbXrDbrHp8TVWi8u75rBZfO49wmgx4/w+JovbjSvYHLg8ds66y+6xaVUn m8fmJfUeW/qBvL4tqxg9Pm+SC2CLSrXJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQw V1LIS8xNtVVy8QnQdcvMAbpMSaEsMacUKBSQWFyspG9nU5RfWpKqkJFfXGKrFG1oaKRnaGCu Z2RkpGdiHGtlZApUkpCa0TB/GnPBfI6KSe0HmRoY77J1MXJySAiYSKy4focJwhaTuHBvPVCc i0NIYCmjxLJXP6Ccz4wSm+YcZuxi5ADr+H9FDaRBSGAHo0TTfC0Qm1dAUOLH5HssICXMAvIS Ry5lg4SZBTQltu5ezw4x5h6jxLHpK9hBangFtCRmv+YDqWERUJV4MvEP2D1sQOH9L26A2fwC ihJXfzxmBLFFBSIkds7/BjZHRGABo8TqBU2sIA6zQCujxNPuTWAdwgLxEuc6n7GA2JwCXhJP r55iBCmSEDjELvFz2y1miAdkJTYdYIb42EXi14edUN8LS7w6voUdwpaS6O6YxQ7R284osXkO yGcgTgejxP2VjawQVcYSp7oamSD+5JPo/f2ECWIBr0RHmxBEiYfEiS9n2SHCjhLzZ1RDQmIu o8SVwx0sExgVZiEF3ixE4M1CCrwFjMyrGMVSC4pz01OLTQuM9IoTc4tL89L1kvNzNzGCk6iW 7g7GLwu8DzEKcDAq8fAGBCpHCrEmlhVX5h5ilOBgVhLhPfwdKMSbklhZlVqUH19UmpNafIjR FBj4E5mlRJPzgQk+ryTe0MTSwMTUzNjA2NDCUkmcV33ltQghgfTEktTs1NSC1CKYPiYOTqkG RkWNmI6tNp+3dHxetv2PZ4ezX891xtbN95eFytfuPWA8tSVfKWj+s5SNyXd/z1ANn6RxKXfn jZwUEaOYj+9WR29fuMW7o+PED4uD2+cYGX6/X39iyet3L6PPNf/d/7Ntf/oing3yJdMlQk9o 3t116wTjqVx3haLPy9i63uYeT9887eu5F62vbMuVWIozEg21mIuKEwHsX1zbuAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsVy+t9jAV1HFpVIg9aZxhbXehcyW7x5u4bJ ov/xa2aL8+c3sFucbXrDbrHp8TVWi8u75rBZfO49wmgx4/w+JovbjSvYHLg8ds66y+6xaVUn m8fmJfUeW/qBvL4tqxg9Pm+SC2CLcrPJSE1MSS1SSM1Lzk/JzEu3VQoNcdO1UFLIS8xNtVWK 0PUNCVJSKEvMKQXyjAzQgINzgHuwkr5dgltGw/xpzAXzOSomtR9kamC8y9bFyMEhIWAi8f+K WhcjJ5ApJnHh3nqgMBeHkMA2RolJ8zaxgCR4BQQlfky+xwJSzywgL3HkUjZImFlAHahkETNE /QNGiSMzNjCC1PAKaEnMfs0HUsMioCrxZOIfNhCbDSi8/8UNMJtfQFHi6o/HYOWiAhES3Scq QcaICCxglHh3cQcjiMMs0MooMblxIViDsEC8xLnOZywQy+YzSjz4NAXsOE4BL4mnV08xTmAU nIXk1lkIt85CcusCRuZVjFypBcW56bnFRgVGmxiBMbjtsFbADsamc9GHGAU4GJV4eGe4KkcK sSaWFVfmHmKU4GBWEuE9/B0oxJuSWFmVWpQfX1Sak1p8iNEU6L+JzFKiyfnA9JBXEm9oYmlk YmBmZmhkYGymJM47IfBLhJBAemJJanZqakFqEUwfEwenVANjsOyFF7wKc96xu7d+Cn7sZZn3 L3Fl9IOfzg7xlxq9OUQmzmGPXxI1VbmmoWPanO5d4UxOe3c8dps5v8f7uct12fIZ1jFzT6/5 qcwnMC9mudG8hmf3cm4URP5Mj8ue8KeO8czVRR3WVQfLxG0/HGsUYDXV2rFRKq+u4+G5S9+4 s1P0Xs5uehukxFKckWioxVxUnAgAbI6UktcCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170523094329epcas5p415c8ed307a31cc8171ed7361eef3a224 X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170519105215epcas5p26e75138ae5815f288ac6ca57a64c1087 X-RootMTR: 20170519105215epcas5p26e75138ae5815f288ac6ca57a64c1087 References: <1495191035-15882-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arvind, On 2017년 05월 19일 19:50, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/devfreq/event/exynos-nocp.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c > index 5c3e7b1..f6e7956 100644 > --- a/drivers/devfreq/event/exynos-nocp.c > +++ b/drivers/devfreq/event/exynos-nocp.c > @@ -267,7 +267,11 @@ static int exynos_nocp_probe(struct platform_device *pdev) > } > platform_set_drvdata(pdev, nocp); > > - clk_prepare_enable(nocp->clk); > + ret = clk_prepare_enable(nocp->clk); > + if (ret) { > + dev_err(&pdev->dev, "failed to prepare ppmu clock\n"); > + return ret; > + } I already replied from the similar patch. Thanks. > > pr_info("exynos-nocp: new NoC Probe device registered: %s\n", > dev_name(dev)); > -- Best Regards, Chanwoo Choi Samsung Electronics