From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030348AbdEWJqz (ORCPT ); Tue, 23 May 2017 05:46:55 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:35128 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967207AbdEWJqv (ORCPT ); Tue, 23 May 2017 05:46:51 -0400 X-AuditID: b6c32a2d-f792a6d0000055a1-dd-592405083f76 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <59240507.1040005@samsung.com> Date: Tue, 23 May 2017 18:46:47 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Enric Balletbo i Serra , MyungJoo Ham , Rob Herring Cc: Lee Jones , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Benson Leung , Olof Johansson Subject: Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out. In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCJsWRmVeSWpSXmKPExsWy7bCmui4Hq0qkwd9HAhbTn1xmsZh/5Byr xZrbhxgt7n89ymhxedccNovbjSvYLE5d/8xm0br3CLsDh8fshossHjvuLmH02LSqk83jzrU9 bB5XTjSxevRtWcXo8XmTXAB7VKpNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJC XmJuqq2Si0+ArltmDtBVSgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWhDQyM9QwNzPSMj Iz0T41grI1OgkoTUjJ1XvjEXXJGueDr1KVsDY5tYFyMnh4SAicSMD5dZIWwxiQv31rN1MXJx CAksZZR4ve0uE4TzmVFi38HNLDAdRw7tZoVIrGWUONLwCqydV0BQ4sfke0BFHBzMAvISRy5l g4SZBTQlXnyZxAJRf49RYuGiXjaIei2JmYd+g9ksAqoSP+b+YASx2YDi+1/cAIvzCyhKXP3x GCwuKhAhsXP+N3aQQSICbYwSu59sBruCWWA50BUPd4F1CAskSBxZfJYZxOYUcJQ49nMBWJGE wD52iTmfX7GBnCchICux6QAzxDsuEkfm/IB6TVji1fEt7BC2lER3xyx2iN52RonNc+6xQDgd jBL3VzZCg8xY4lRXIxPEo3wSvb+fMEEs4JXoaBOCKPGQmPj4EtRQR4nzN66DvSMkcIRJond2 zgRGhVlIoTcLEXqzkEJvASPzKkax1ILi3PTUYtMCI73ixNzi0rx0veT83E2M4BSqpbuD8csC 70OMAhyMSjy8AYHKkUKsiWXFlbmHGCU4mJVEeA9/BwrxpiRWVqUW5ccXleakFh9iNAUG/kRm KdHkfGB6zyuJNzSxNDAxNTM2MDa0sFQS51VfeS1CSCA9sSQ1OzW1ILUIpo+Jg1OqgbFosp2u 3k4m/QV8ZQxiRnHX3vNcSRf5KWX2SZGn7Cmn6sJTPrZWty0/XVP6/7xUZmPpFv683rXB+8XM i16+Z5R9tOPO68xkn/1u067d23xi/rYty4r+b3mbohE4jy3yaLyjt+Pz820rttspLNPYF9Dy qpZlir3YoXrhmeuUcxfu2eH59f+7HRuUWIozEg21mIuKEwGKgfj6twMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsVy+t9jQV12VpVIg6trbCymP7nMYjH/yDlW izW3DzFa3P96lNHi8q45bBa3G1ewWZy6/pnNonXvEXYHDo/ZDRdZPHbcXcLosWlVJ5vHnWt7 2DyunGhi9ejbsorR4/MmuQD2KDebjNTElNQihdS85PyUzLx0W6XQEDddCyWFvMTcVFulCF3f kCAlhbLEnFIgz8gADTg4B7gHK+nbJbhl7LzyjbnginTF06lP2RoY28S6GDk5JARMJI4c2s0K YYtJXLi3nq2LkYtDSGA1o8TpXT+ZQBK8AoISPybfY+li5OBgFpCXOHIpG8JUl5gyJRekQkjg AaPE62NsENVaEjMP/QazWQRUJX7M/cEIYrMBxfe/uAEW5xdQlLj64zEjyBhRgQiJ7hOVIFtF BNoYJU5u38gCUsMssJxRYubPShBbWCBB4sjis8wQpx1hkujd/gzsNE4BR4ljPxewTmAUnIXk 0lkIl85CuHQBI/MqRq7UguLc9NxiowKjTYzAuNt2WCtgB2PTuehDjAIcjEo8vDNclSOFWBPL iitzDzFKcDArifAe/g4U4k1JrKxKLcqPLyrNSS0+xGgK9N1EZinR5HxgSsgriTc0sTQyMTAz MzQyMDZTEuedEPglQkggPbEkNTs1tSC1CKaPiYNTqoGx89+84vhTU/bM2XujRS2wWOXxaq4r 33PWv5ycULLg2px+jqadhiXS2TNu39uz/tKe6XHP3/gv/VFgoVcl/Dcjgslp7nffDZuEdZ3t 5/3l3ypeHCH3VNjQJLpHk1k0a2lZb1S567EHx9VS2e52fogUlc3LKPPfov7LPtCp/7WB5nPW 25tPzGxSYinOSDTUYi4qTgQArggOm9ECAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170523094648epcas5p3fa8adc21c60262c05414897bfa72a98f X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170301112844epcas4p34012f1564f1145f8d8a8967f4fe9a821 X-RootMTR: 20170301112844epcas4p34012f1564f1145f8d8a8967f4fe9a821 References: <20170301111943.12170-1-enric.balletbo@collabora.com> <20170301111943.12170-2-enric.balletbo@collabora.com> <58B7C9BF.1040708@samsung.com> <58E44698.5020605@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Enric, On 2017년 04월 20일 19:16, Enric Balletbo i Serra wrote: > On 05/04/17 03:21, Chanwoo Choi wrote: >> Hi Enric, >> >> On 2017년 03월 02일 16:29, Chanwoo Choi wrote: >>> Hi, >>> >>> On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote: >>>> From: Benson Leung >>>> >>>> This is the driver for the USB Type C cable detection mechanism >>>> built into the ChromeOS Embedded Controller on systems that >>>> have USB Type-C ports. >>>> >>>> At present, this allows for the presence of display out, but in >>>> future, it may also be used to notify host and device type cables >>>> and the presence of power. >>>> >>>> Signed-off-by: Benson Leung >>>> Signed-off-by: Enric Balletbo i Serra >>>> --- >>>> Changes since v1: >>>> Requested by Chanwoo Choi >>>> - Rename files changing _ for - >>>> - Remove the unneeded blank line on bottom of header. >>>> - Remove kobject.h and cros_ec_commands.h includes. >>>> - Remove the debug message as is not necessary. >>>> - Use the tab for indentation instead of space for if sentence. >>>> - Define each variable on different lines when the variables should be >>>> initialized. >>>> - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now. >>>> - Add one blank line to split out between state and property setting. >>>> - Add the author information (header and module) >>>> >>>> Enric Balletbo >>>> - As Rob suggested to rename the compatible name to something indicating that >>>> is USB Type C related I also renamed the file names, extcon-cros-ec -> >>>> extcon-usbc-cros-ec, I think it's more clear. >>>> >>>> drivers/extcon/Kconfig | 7 + >>>> drivers/extcon/Makefile | 1 + >>>> drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++ >>>> include/linux/mfd/cros_ec_commands.h | 75 +++++++ >>>> 4 files changed, 498 insertions(+) >>>> create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c >>>> >>> >>> Looks good to me. >>> Acked-by: Chanwoo Choi >>> >>> I think this patch should be handled with patches[1]. >>> [1] https://lkml.org/lkml/2017/2/14/655 >>> >>> I think that one maintainer among following subsystems >>> (mfd, chrome h/w platform, rtc and extcon) >>> will apply their git repository, and then one maintainer >>> will send the pull request of immutable branch for these patches. >>> >> >> As I mentioned, these patch should be handled with related patches[1]. >> [1] https://lkml.org/lkml/2017/2/14/655 >> >> So, I can't apply these patch on extcon git because there is a merge conflict >> and we should handle these patches with immutable branch between subsystem maintainer. >> >> The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1, >> please take care of these patches. >> > > CC'ied : Olof Johansson > > Olof, Benson, > > Could at least the following patch in this series [1] picked as soon as possible > if it's ok. > > 9630769 New [01/13] mfd: cros_ec: Add helper for event notifier > > This specific patch is blocking this and others like the rtc-cros-ec to land and > the series were send some time ago without received bad feedback. > > [1] https://lkml.org/lkml/2017/3/17/321 > > Many thanks, > Enric Maybe, you better to resend these patches based on v4.12-rcX. -- Best Regards, Chanwoo Choi Samsung Electronics