From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753190AbdEXB5C (ORCPT ); Tue, 23 May 2017 21:57:02 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:38817 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245AbdEXB44 (ORCPT ); Tue, 23 May 2017 21:56:56 -0400 X-AuditID: b6c32a35-f79806d000002bf4-33-5924e8656dbb MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <5924E865.6030105@samsung.com> Date: Wed, 24 May 2017 10:56:53 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Arvind Yadav , myungjoo.ham@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, kgene@kernel.org, javier@osg.samsung.com Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] PM / devfreq: exynos-nocp : Handle return value of clk_prepare_enable In-reply-to: <59240441.9090208@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01SWUwTURTN60xnhmp1rKI3GLVOMMYaKlOgDEqNe2rESMS4YEydwAsldsFO IW6JYFxR3D+QGMGoUVAEKiFAXBFcUChqBNwwhqioqFFQMKJx2nH7O/e8c+679+QyhO4MFcak u7zY4xIdHKUhq65PMkbgrvAVkT9KIoTWvOOE0P3+nErY1/mOEPz+clpo2tJNC77OVrXwoPYo JfTk1SMh339ZJTzJOUPN0FhrCp7RVl/JLsp64eRma+U+udpbWYKsPb6xiVQyjrdjMRV79NiV 4k5Nd6VZuAVJttm2GHMkH8HHCbGc3iU6sYWbk5AYMS/dIU/G6bNER6ZMJYqSxE2ZHu9xZ3qx 3u6WvBZuJc+bjHxkrNFkMhmjo1ZNNcXIktXY/r7xNZFRqlm3tfgxnY2qmVwUwgAbDWX+blLB I6Glo4zKRRpGx1YjqG33IaXoQfCprwr9ceS3NKr/qho+96sDD1p2GPQf6pBbMQzBjoP6+2sC NMFOgq7eg6Si70Cwt+YbqegN0Pf0Ix3AJDsB9u/oDfKUzF/paqcCeCg7Hh72dwY/DmWXQ03h VzrQaARbhOBs0ZbgFAS7DcHL3b6gYzhrg+Zdr4KdQtjJ0NdcGtwB2Doajt1oQIHxgB0DvquE ss4cOH+n4ncAw+HtzUpawWGQ8+aFSvHuQHDhaAepFDsRPC/OUSuqKGjMzVEpiw6BD1/2qJUP tLBzu06RWOFWbxOt0DOhMH+jEsVlBA/etJD7kb7gv/QK/qVX8F96RYgoQSNxhuRMwxKfwRsl 0SllutKMKW6nDwWv1BBTjQ43J9QhlkHcYK0+KXyFTi1mSeuddQgYghuhPV0uU9pUcf0G7HHb PJkOLNWhGDn8A0RYaIpbvnmX18ZHx0VGm03y4cXxPDdKG1rWulzHpolevAbjDOz541MxIWHZ SFO1YHH+pUENbdK5UwNL5xvqbxW/s4+/vfrJ3IovySs93QZL28CepReXjW6arWorfDWtnEsa +Nw0Ou9FeOmRZZtW3Uu9rh638OejI1dvamMdsxKyp1z78PX7Nn9F1LeGE1kzhEXh5vS7i9uW tFvM13jzWvPE2uTpGweXxtWQmvhRjzh9I0dKdpE3EB5J/AVoeYhUuwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsVy+t9jAd3UFyqRBnvny1lc613IbPHm7Rom i/7Hr5ktzp/fwG5xtukNu8Wmx9dYLS7vmsNm8bn3CKPFjPP7mCxuN65gc+Dy2DnrLrvHplWd bB6bl9R7bOkH8vq2rGL0+LxJLoAtys0mIzUxJbVIITUvOT8lMy/dVik0xE3XQkkhLzE31VYp Qtc3JEhJoSwxpxTIMzJAAw7OAe7BSvp2CW4Zb089Zy5Yy1XRsvIWewPjDo4uRk4OCQETiRkX TrFC2GISF+6tZ+ti5OIQEtjGKNH0ehYzSIJXQFDix+R7LF2MHBzMAvISRy5lQ5jqElOm5EKU P2CUePNyFyNEuZbE9zvv2UFsFgFViQntX1hAbDag+P4XN9hAbH4BRYmrPx4zgswRFYiQ6D5R CTJHRGABo8S7izsYQRxmgVZGicmNC8EahAXiJc51PmOB2HaAUWJm+w6w4zgFtCW+n1vLOIFR cBaSW2ch3DoL4dYFjMyrGLlSC4pz03OLjQoMNzECY3DbYS3/HYw/zkYfYhTgYFTi4f1RpRIp xJpYVlyZe4hRgoNZSYR3+QagEG9KYmVValF+fFFpTmrxIUZToPcmMkuJJucD00NeSbyhiaWR iYGZmaGRgbGZkjjvhMAvEUIC6YklqdmpqQWpRTB9TBycUg2MjA8bfDbVzp+hyvRjY/TW+ryS 7RpbT11y8VZOUGESvn8q769AptiD6UUuXHFTdZZu8lq5X1xZm2/Gdb9eXo0DS8ssdLSeb2/i Ohz7ac6+KYbdPWelWVYfzty76maxk0HNxyXz/h097ibpuPaQ8EXhPRXz17+wf+raes705KeE H5s80y/ds/VeocRSnJFoqMVcVJwIACJPxeTXAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170524015653epcas1p24ffd4665054e17bfff03cab7fe7951ed X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170519105215epcas5p26e75138ae5815f288ac6ca57a64c1087 X-RootMTR: 20170519105215epcas5p26e75138ae5815f288ac6ca57a64c1087 References: <1495191035-15882-1-git-send-email-arvind.yadav.cs@gmail.com> <59240441.9090208@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 05월 23일 18:43, Chanwoo Choi wrote: > Hi Arvind, > > On 2017년 05월 19일 19:50, Arvind Yadav wrote: >> clk_prepare_enable() can fail here and we must check its return value. >> >> Signed-off-by: Arvind Yadav >> --- >> drivers/devfreq/event/exynos-nocp.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c >> index 5c3e7b1..f6e7956 100644 >> --- a/drivers/devfreq/event/exynos-nocp.c >> +++ b/drivers/devfreq/event/exynos-nocp.c >> @@ -267,7 +267,11 @@ static int exynos_nocp_probe(struct platform_device *pdev) >> } >> platform_set_drvdata(pdev, nocp); >> >> - clk_prepare_enable(nocp->clk); >> + ret = clk_prepare_enable(nocp->clk); >> + if (ret) { >> + dev_err(&pdev->dev, "failed to prepare ppmu clock\n"); >> + return ret; >> + } > > I already replied from the similar patch. Thanks. > >> >> pr_info("exynos-nocp: new NoC Probe device registered: %s\n", >> dev_name(dev)); >> > > I'm missing some point that if there is no clock this driver initializes 'nocp->clk = NULL;' on 217 line. Looks good to me. Acked-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics