From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940033AbdEXMeu (ORCPT ); Wed, 24 May 2017 08:34:50 -0400 Received: from mail-ve1eur01on0070.outbound.protection.outlook.com ([104.47.1.70]:57216 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S940020AbdEXMd6 (ORCPT ); Wed, 24 May 2017 08:33:58 -0400 From: Laurentiu Tudor To: Ruxandra Ioana Radulescu , "gregkh@linuxfoundation.org" CC: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "agraf@suse.de" , "arnd@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "iommu@lists.linux-foundation.org" , Bogdan Purcareata , "stuyoder@gmail.com" , "Nipun Gupta" Subject: Re: [PATCH 1/2] staging: fsl-dpaa2/eth: Fix address translations Thread-Topic: [PATCH 1/2] staging: fsl-dpaa2/eth: Fix address translations Thread-Index: AQHS1IcqLFEHn8DuV0qiLmaZnOUdTaIDavEA Date: Wed, 24 May 2017 12:33:53 +0000 Message-ID: <59257DB0.8010604@nxp.com> References: <20170524121328.16984-1-ruxandra.radulescu@nxp.com> In-Reply-To: <20170524121328.16984-1-ruxandra.radulescu@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [192.88.146.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR0401MB2431;7:GCOXGa1hCEQO0pfC9ISiwjCzm14yupjh+/CEmR89Fw4IrejfRxEsCjax8femoZ0T2ncUDcnY8dBQt5DOhGTjL58frr5aR8ddNvS0Vyy9RmulmfsjwVEfHkmqwqQF/cwBG1w9KmmZFlGOl+DiM/Hx+4uMzctJcES01+kwEmx6/wqud5EzYOeyyLBIlwnfaDluMPknnzmY/eDTue+t+3R/LdCj3RnBMiiylaEOrMUf56ObYe70pyZHHzm7fFNx4MGM9/CYvhvsHK1Wt61j2156+u+oHO5SJccGnPDA3h7UaAtGIiam6WRyc49WOIr3af9t2CsKFI5dgweonlZ/ZQ7CxQ== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39450400003)(39840400002)(39860400002)(39410400002)(39850400002)(39400400002)(377454003)(24454002)(2950100002)(86362001)(59896002)(575784001)(478600001)(77096006)(305945005)(2906002)(53546009)(25786009)(2501003)(2900100001)(80316001)(36756003)(6486002)(33656002)(54906002)(99136001)(102836003)(6116002)(38730400002)(3846002)(6436002)(189998001)(6246003)(4326008)(50986999)(65816999)(54356999)(76176999)(3280700002)(87266999)(66066001)(5660300001)(8676002)(81166006)(122556002)(229853002)(6512007)(8936002)(3660700001)(7736002)(99286003)(6506006)(39060400002)(53936002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB2431;H:VI1PR0401MB1856.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; x-ms-traffictypediagnostic: VI1PR0401MB2431: x-ms-office365-filtering-correlation-id: f387c904-31d4-4353-37b7-08d4a2a123df x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:VI1PR0401MB2431; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(6072148);SRVR:VI1PR0401MB2431;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB2431; x-forefront-prvs: 031763BCAF spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="Windows-1252" Content-ID: <1B196A65277E1543B853FF0C94AEAFC2@eurprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2017 12:33:53.8596 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2431 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4OCZgVO031818 Hi Ioana, Debatable nit inline. On 05/24/2017 03:13 PM, Ioana Radulescu wrote: > Use the correct mechanisms for translating a DMA-mapped IOVA > address into a virtual one. Without this fix, once SMMU is > enabled on Layerscape platforms, the Ethernet driver throws > IOMMU translation faults. > > Signed-off-by: Nipun Gupta > Signed-off-by: Ioana Radulescu > --- > drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 25 +++++++++++++++++++------ > drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 1 + > 2 files changed, 20 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c > index 6f9eed66c64d..3fee0d6f17e0 100644 > --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c > +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c > @@ -37,6 +37,7 @@ > #include > #include > #include > +#include > > #include "../../fsl-mc/include/mc.h" > #include "../../fsl-mc/include/mc-sys.h" > @@ -54,6 +55,16 @@ MODULE_DESCRIPTION("Freescale DPAA2 Ethernet Driver"); > > const char dpaa2_eth_drv_version[] = "0.1"; > > +static void *dpaa2_iova_to_virt(struct iommu_domain *domain, if you pass a "struct dpaa2_eth_priv *priv" instead of "iommu_domain" you can move the priv->iommu_domain reference in the function and slightly simplify the call sites. --- Best Regards, Laurentiu