From: Arnd Bergmann <arnd@arndb.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Tina Ruchandani <ruchandani.tina@gmail.com>,
linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@odin.com>,
y2038@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval
Date: Fri, 30 Oct 2015 13:45:08 +0100 [thread overview]
Message-ID: <5927653.jpoZ2K5FqB@wuerfel> (raw)
In-Reply-To: <56335B69.4010502@suse.de>
On Friday 30 October 2015 12:58:33 Hannes Reinecke wrote:
> > @@ -1076,7 +1069,7 @@ static int stex_ss_handshake(struct st_hba *hba)
> > h->req_cnt = cpu_to_le16(hba->rq_count+1);
> > h->status_sz = cpu_to_le16(sizeof(struct status_msg));
> > h->status_cnt = cpu_to_le16(hba->sts_count+1);
> > - stex_gettime(&h->hosttime);
> > + h->hosttime = cpu_to_le64(ktime_get_real_seconds());
> > h->partner_type = HMU_PARTNER_TYPE;
> > h->extra_offset = h->extra_size = 0;
> > scratch_size = (hba->sts_count+1)*sizeof(u32);
> >
> Just remove 'hosttime' altogether. It serves no purpose whatsoever.
>
>
Are you sure? It is defined in a struct that is shared with the HBA
as part of hba->dma_mem, so unless you have access to the firmware,
it's hard to guess what it might be used for inside of the firmware.
Arnd
next prev parent reply other threads:[~2015-10-30 12:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 8:30 [RESEND PATCH v3] scsi: stex: Remove use of struct timeval Tina Ruchandani
2015-10-30 8:50 ` Johannes Thumshirn
2015-10-30 8:54 ` Tina Ruchandani
2015-10-30 23:37 ` [Y2038] " Arnd Bergmann
2015-10-30 11:58 ` Hannes Reinecke
2015-10-30 12:45 ` Arnd Bergmann [this message]
2015-11-02 7:49 ` Hannes Reinecke
2015-11-05 16:23 ` [Y2038] " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5927653.jpoZ2K5FqB@wuerfel \
--to=arnd@arndb.de \
--cc=JBottomley@odin.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ruchandani.tina@gmail.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox