From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946754AbdEZDNx (ORCPT ); Thu, 25 May 2017 23:13:53 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:6918 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1163484AbdEZDNs (ORCPT ); Thu, 25 May 2017 23:13:48 -0400 Subject: Re: [PATCH] reset: hisilicon: Fix hi6220 module license To: =?UTF-8?Q?Andreas_F=c3=a4rber?= , References: <20170525092232.27960-1-afaerber@suse.de> CC: Arnd Bergmann , Philipp Zabel , From: Chen Feng Message-ID: <59279D3B.6090804@hisilicon.com> Date: Fri, 26 May 2017 11:12:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20170525092232.27960-1-afaerber@suse.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.142.193.64] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A010201.59279D3F.0026,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 459ed14adc54f064dab2d7bbc0030470 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org looks good to me. On 2017/5/25 17:22, Andreas Färber wrote: > The hi6220_reset driver fails to load: > > [ 10.423640] hi6220_reset: module license 'unspecified' taints kernel. > [ 10.423644] Disabling lock debugging due to kernel taint > [ 10.423735] hi6220_reset: Unknown symbol regmap_write (err 0) > [ 10.423747] hi6220_reset: Unknown symbol devm_kmalloc (err 0) > [ 10.423759] hi6220_reset: Unknown symbol syscon_node_to_regmap (err 0) > [ 10.423768] hi6220_reset: Unknown symbol reset_controller_register (err 0) > [ 10.423784] hi6220_reset: Unknown symbol __platform_driver_register (err 0) > > Add a MODULE_LICENSE() to fix this. > > Fixes: 70b3590f639f ("reset: hi6220: fix modular build") > Cc: Arnd Bergmann > Cc: Chen Feng > Signed-off-by: Andreas Färber > --- > drivers/reset/hisilicon/hi6220_reset.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c > index 35ce53edabf9..d5e5229308f2 100644 > --- a/drivers/reset/hisilicon/hi6220_reset.c > +++ b/drivers/reset/hisilicon/hi6220_reset.c > @@ -155,3 +155,5 @@ static int __init hi6220_reset_init(void) > } > > postcore_initcall(hi6220_reset_init); > + > +MODULE_LICENSE("GPL v2");