Re: [PATCH v5 13/32] x86/boot/e820: Add support to determine the E820 type of an address

Ard Biesheuvel
2017-05-06T07:48:30Z

On 5 May 2017 at 18:11, Borislav Petkov <bp@alien8.de> wrote:
> On Tue, Apr 18, 2017 at 04:18:31PM -0500, Tom Lendacky wrote:
>> Add a function that will return the E820 type associated with an address
>> range.
>
> ...
>
>> @@ -110,9 +111,28 @@ bool __init e820__mapped_all(u64 start, u64 end, enum e820_type type)
>> * coverage of the desired range exists:
>> */
>> if (start >= end)
>> - return 1;
>> + return entry;
>> }
>> - return 0;
>> +
>> + return NULL;
>> +}
>> +
>> +/*
>> + * This function checks if the entire range <start,end> is mapped with type.
>> + */
>> +bool __init e820__mapped_all(u64 start, u64 end, enum e820_type type)
>> +{
>> + return __e820__mapped_all(start, end, type) ? 1 : 0;
>
> return !!__e820__mapped_all(start, end, type);
>

Even the !! double negation is redundant, given that the function returns bool.