From: jeffy <jeffy.chen@rock-chips.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org,
dianders@chromium.org, tfiga@chromium.org
Subject: Re: [PATCH] genirq: Check irq disabled & masked states in irq_shutdown
Date: Sat, 27 May 2017 12:52:07 +0800 [thread overview]
Message-ID: <592905F7.4010803@rock-chips.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1705261519070.1902@nanos>
Hi Thomas,
On 05/26/2017 09:20 PM, Thomas Gleixner wrote:
> On Fri, 26 May 2017, Jeffy Chen wrote:
>
>> If irq is already disabled and masked, we would hit a unbalanced irq
>> shutdown/disable/mask when freeing it.
>
> Errr? What exactly is unbalanced? None of the called functions has any
> counter or whatever.
>
> Can you please explain what you are trying to fix?
sorry, i'll try to rewrite the commit message.
for example when a driver(drivers/net/wireless/marvell/mwifiex/main.c)
try to do these:
devm_request_irq->irq_startup->irq_enable
disable_irq <-- disabled and masked
devm_free_irq->irq_shutdown <-- disable it again
and the pinctrl-rockchip driver would enable/disable gpio clk in
irq_enable/irq_disable, so it would try to disable a disabled clk(due to
unbalanced irq disable)
>
> Thanks,
>
> tglx
>
>
>
next prev parent reply other threads:[~2017-05-27 4:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 13:17 [PATCH] genirq: Check irq disabled & masked states in irq_shutdown Jeffy Chen
2017-05-26 13:20 ` Thomas Gleixner
2017-05-27 4:52 ` jeffy [this message]
2017-05-27 8:16 ` Thomas Gleixner
2017-05-30 23:20 ` Brian Norris
2017-05-30 23:32 ` Brian Norris
2017-05-31 8:38 ` Thomas Gleixner
2017-05-31 9:22 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=592905F7.4010803@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tfiga@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).