From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751153AbdE2N5l (ORCPT ); Mon, 29 May 2017 09:57:41 -0400 Received: from mail-eopbgr20079.outbound.protection.outlook.com ([40.107.2.79]:16911 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751068AbdE2N5k (ORCPT ); Mon, 29 May 2017 09:57:40 -0400 From: Laurentiu Tudor To: Ruxandra Ioana Radulescu , "gregkh@linuxfoundation.org" CC: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "agraf@suse.de" , "arnd@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "iommu@lists.linux-foundation.org" , Bogdan Purcareata , "stuyoder@gmail.com" , "Nipun Gupta" Subject: Re: [PATCH 1/2] staging: fsl-dpaa2/eth: Fix address translations Thread-Topic: [PATCH 1/2] staging: fsl-dpaa2/eth: Fix address translations Thread-Index: AQHS1IcqLFEHn8DuV0qiLmaZnOUdTaIDavEAgAGRnICABmFugA== Date: Mon, 29 May 2017 13:57:34 +0000 Message-ID: <592C28CD.30604@nxp.com> References: <20170524121328.16984-1-ruxandra.radulescu@nxp.com> <59257DB0.8010604@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=laurentiu.tudor@nxp.com; x-originating-ip: [192.88.146.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR0401MB2430;7:CqBVJjGGPV78U4UakhpJjLrgsfvGWKoZFOKKTbAl4aluAuDKVGV+cRJzNYQEK1xCyZkHJ8GoNDgUPYaMcTbMVPzlkRFTmpxvR4IjXLRgzJ+57bJfSmBECfEM+Q5RUdCtWgqIa0vkWRkYTQGGDYb+2q0xFxUHPPhgB5VpvVRrQ4Ss7meQnfNQZKrAT3QVBG2lh4b9GCrbGHA4BRqeWy+tBAJwOwjvMzZMZRo0v8PYiB5B6IKGXkEO/SfPdj2gGHRlBY39TCVwlaoLiayvvSpSHRlcXALJXCJewnw51ofujBgLJ5QJpXBPC/s8m1igc3AsBfEwr9z9T9+jK+drdGvqoA== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39450400003)(39400400002)(39410400002)(39860400002)(39850400002)(39840400002)(13464003)(377454003)(24454002)(54906002)(76176999)(99286003)(6246003)(36756003)(14454004)(5250100002)(5660300001)(65816999)(6512007)(54356999)(2900100001)(50986999)(53936002)(38730400002)(39060400002)(6486002)(33656002)(3660700001)(4326008)(8936002)(8676002)(81166006)(189998001)(3280700002)(6436002)(6506006)(2950100002)(478600001)(66066001)(2906002)(229853002)(53546009)(25786009)(305945005)(7736002)(2501003)(3846002)(102836003)(6116002)(86362001)(575784001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB2430;H:VI1PR0401MB1856.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; x-ms-traffictypediagnostic: VI1PR0401MB2430: x-ms-office365-filtering-correlation-id: 6c671445-3d6c-4a2c-124a-08d4a69aa8a9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:VI1PR0401MB2430; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123558100)(20161123562025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148);SRVR:VI1PR0401MB2430;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB2430; x-forefront-prvs: 0322B4EDE1 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="Windows-1252" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2017 13:57:34.8877 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2430 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4TDvjJS028948 On 05/25/2017 03:31 PM, Ruxandra Ioana Radulescu wrote: >> -----Original Message----- >> From: Laurentiu Tudor >> Sent: Wednesday, May 24, 2017 3:34 PM >> To: Ruxandra Ioana Radulescu ; >> gregkh@linuxfoundation.org >> Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; >> agraf@suse.de; arnd@arndb.de; linux-arm-kernel@lists.infradead.org; >> iommu@lists.linux-foundation.org; Bogdan Purcareata >> ; stuyoder@gmail.com; Nipun Gupta >> >> Subject: Re: [PATCH 1/2] staging: fsl-dpaa2/eth: Fix address translations >> >> Hi Ioana, >> >> Debatable nit inline. >> >> On 05/24/2017 03:13 PM, Ioana Radulescu wrote: >>> Use the correct mechanisms for translating a DMA-mapped IOVA >>> address into a virtual one. Without this fix, once SMMU is >>> enabled on Layerscape platforms, the Ethernet driver throws >>> IOMMU translation faults. >>> >>> Signed-off-by: Nipun Gupta >>> Signed-off-by: Ioana Radulescu >>> --- >>> drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 25 >> +++++++++++++++++++------ >>> drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 1 + >>> 2 files changed, 20 insertions(+), 6 deletions(-) >>> >>> diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c >> b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c >>> index 6f9eed66c64d..3fee0d6f17e0 100644 >>> --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c >>> +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c >>> @@ -37,6 +37,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> #include "../../fsl-mc/include/mc.h" >>> #include "../../fsl-mc/include/mc-sys.h" >>> @@ -54,6 +55,16 @@ MODULE_DESCRIPTION("Freescale DPAA2 Ethernet >> Driver"); >>> >>> const char dpaa2_eth_drv_version[] = "0.1"; >>> >>> +static void *dpaa2_iova_to_virt(struct iommu_domain *domain, >> >> if you pass a "struct dpaa2_eth_priv *priv" instead of "iommu_domain" >> you can move the priv->iommu_domain reference in the function and >> slightly simplify the call sites. > > Fair point, but I'd prefer keeping this function independent of the > Ethernet driver's private data structure. This way, if other (future) > DPAA2 drivers will need a similar function, we can just move it > to a common area instead of duplicating the code. Understood. Fine by me then. --- Best Regards, Laurentiu