From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751402AbdFFIsr (ORCPT ); Tue, 6 Jun 2017 04:48:47 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:48470 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751274AbdFFIsq (ORCPT ); Tue, 6 Jun 2017 04:48:46 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="19709888" Subject: Re: [PATCH] Top Makefile: tiny correction on `make help` To: Masahiro Yamada References: <1496028061-19285-1-git-send-email-caoj.fnst@cn.fujitsu.com> CC: Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List From: Cao jin Message-ID: <59366D02.3020604@cn.fujitsu.com> Date: Tue, 6 Jun 2017 16:51:14 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.226.69] X-yoursite-MailScanner-ID: E34B747F64C5.A8374 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: caoj.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mr Masahiro, On 06/06/2017 09:47 AM, Masahiro Yamada wrote: > Hi Cao, > > > 2017-05-29 12:21 GMT+09:00 Cao jin : >> The help info of `make -C=1` is little confusing, make it clear. > > `make C=1` instead of `make -C=1` > > > >> Signed-off-by: Cao jin >> --- >> Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Makefile b/Makefile >> index efa267a..b34a34d 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -1417,7 +1417,7 @@ help: >> @echo ' make V=0|1 [targets] 0 => quiet build (default), 1 => verbose build' >> @echo ' make V=2 [targets] 2 => give reason for rebuild of target' >> @echo ' make O=dir [targets] Locate all output files in "dir", including .config' >> - @echo ' make C=1 [targets] Check all c source with $$CHECK (sparse by default)' >> + @echo ' make C=1 [targets] Check re-compiled c source only with $$CHECK (sparse by default)' >> @echo ' make C=2 [targets] Force check of all c source with $$CHECK' >> @echo ' make RECORDMCOUNT_WARN=1 [targets] Warn about ignored mcount sections' >> @echo ' make W=n [targets] Enable extra gcc checks, n=1,2,3 where' > > Which phrase is qualified by "only"? > > [1] re-compiled c source only > [2] only with $$CHECK > > I know [1] is what you mean (sorry for my nitpicking). > You are right, after reading it again, I myself have the same feeling as you... > > Perhaps, "Check only re-compiled c source with $$CHECK" is even clearer? > > (or, just drop "only" because "re-compiled c source" is understandable enough ?) I prefer the latter one. > > > Could you use "kbuild: " instead of "Top Makefile" in the subject? > Sure. Thanks very much for your suggestion:) -- Sincerely, Cao jin