From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752053AbdFLBBJ (ORCPT ); Sun, 11 Jun 2017 21:01:09 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:47235 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbdFLBBH (ORCPT ); Sun, 11 Jun 2017 21:01:07 -0400 X-AuditID: b6c32a58-f79896d000000567-79-593de7d0fcd2 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <593DE7D0.6010809@samsung.com> Date: Mon, 12 Jun 2017 10:01:04 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andy Shevchenko , MyungJoo Ham , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] extcon: int3496: Switch to devm_acpi_dev_add_driver_gpios() In-reply-to: <20170610190921.53567-1-andriy.shevchenko@linux.intel.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGKsWRmVeSWpSXmKPExsWy7bCmlu6F57aRBlcXm1r0Nk1nsri8aw6b xe3GFWwOzB7zTgZ69G1ZxejxeZNcAHNUqk1GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6h pYW5kkJeYm6qrZKLT4CuW2YO0B4lhbLEnFKgUEBicbGSvp1NUX5pSapCRn5xia1StKGhkZ6h gbmekZGRnolxrJWRKVBJQmrGrf3vWQtucFV8mXWGvYHxC0cXIyeHhICJxJX765ghbDGJC/fW s3UxcnEICSxllPi8dA4zhPOZUaLl4lqWLkYOsI6fd7xAGoQE1jJKXF6bBmLzCghK/Jh8D6yE WUBe4silbJAws4CmxNbd69khxtxjlNj7uocdol5L4uH6k2wgNouAqsTjY7/B4mxA8f0vboDF +QUUJa7+eMwIYosKREjsnP8NbJCIQAOjxL2Hm9hAlgkLhEq0HA8EqeEUcJfYsaSXDeKZ12wS U1daQ5wsK7HpANSPLhIrHxyDsoUlXh3fwg5hS0l0d8wCGy8h0M4osXkOyC8gTgejxP2VjawQ VcYSp7oamSA+45Po/f2ECWIBr0RHmxBEiYfEykcboModJVb8OsEC8fwsRolby56zTmCUn4UU XrMQ4TULKbwWMDKvYhRLLSjOTU8tNi0w0StOzC0uzUvXS87P3cQITmNaETsY/80IOsQowMGo xMObsNc2Uog1say4MvcQowQHs5IIL5c5UIg3JbGyKrUoP76oNCe1+BCjKTC4JzJLiSbnA1Ns Xkm8oYmlgYmpmbGBsaGFpZI4r/rKaxFCAumJJanZqakFqUUwfUwcnFINjHphqx+Yr6vl8Y79 3zTrs0fpNtffn69Z6681VTDUO/Q89dX/uKW9iXuPXomfuYivYse5GTwqp10utCwTS734UUm7 0zdtr4bJscvqTnvrZBSlK/+qf/2100PQp/XV1bdHgp9MktvVL8AZ4LQ7RFida1VI0cFrfYK8 +0QqVeXYrj8wXXm55s2VLUosxRmJhlrMRcWJAGdMedR5AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplkeLIzCtJLcpLzFFi42I5/e+xoO6F57aRBo/vqlr0Nk1nsri8aw6b xe3GFWwOzB7zTgZ69G1ZxejxeZNcAHOUm01GamJKapFCal5yfkpmXrqtUmiIm66FkkJeYm6q rVKErm9IkJJCWWJOKZBnZIAGHJwD3IOV9O0S3DJu7X/PWnCDq+LLrDPsDYxfOLoYOTgkBEwk ft7x6mLkBDLFJC7cW8/WxcjFISSwmlHi9LMXLCAJXgFBiR+T77GA1DMLyEscuZQNEmYWUJeY NG8RM0T9A0aJrwtfQtVrSTxcf5INxGYRUJV4fOw3O4jNBhTf/+IGWJxfQFHi6o/HjCAzRQUi JLpPVILMERFoYJRYd/Y5WFxYIFSi5XggxPw5jBL7H58D6+UUcJfYsaSXbQKjwCwk581COG8W kvMWMDKvYuRKLSjOTc8tNiow2sQIjIJth7UCdjA2nYs+xCjAwajEw5uw1zZSiDWxrLgy9xCj BAezkggvlzlQiDclsbIqtSg/vqg0J7X4EKMp0EcTmaVEk/OBEZpXEm9oYmlkYmBmZmhkYGym JM47IfBLhJBAemJJanZqakFqEUwfEwenVAOjlpvPbYGIJdqdB3ZOeVA5V9vsUNe5T55Zz5eJ y7az/+uQ17/qkLRVL07s8KI7y6dFrtobrLHJWl/jwt1jinnzQi5kNZUGpIZFt20tUs0o3WJx Z2aaYWfGBNNfuzakXv1zI+7B43mFNptv3LLL95sn/PHlh+5wboOgF9PbrFuaNr3x+n1FfZWG EktxRqKhFnNRcSIACHwx6JgCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170612010104epcas5p1bb4468dd9d7d8c2dc6d98327d40a04cf X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170610190957epcas5p1310ebdee45e6e0d94ac0ae8aafb53239 X-RootMTR: 20170610190957epcas5p1310ebdee45e6e0d94ac0ae8aafb53239 References: <20170610190921.53567-1-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 06월 11일 04:09, Andy Shevchenko wrote: > Switch to use managed variant of acpi_dev_add_driver_gpios() to simplify > error path and fix potentially wrong assingment if ->probe() fails. > > Signed-off-by: Andy Shevchenko > --- > drivers/extcon/extcon-intel-int3496.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c > index 9d17984bbbd4..d9f9afe45961 100644 > --- a/drivers/extcon/extcon-intel-int3496.c > +++ b/drivers/extcon/extcon-intel-int3496.c > @@ -94,8 +94,7 @@ static int int3496_probe(struct platform_device *pdev) > struct int3496_data *data; > int ret; > > - ret = acpi_dev_add_driver_gpios(ACPI_COMPANION(dev), > - acpi_int3496_default_gpios); > + ret = devm_acpi_dev_add_driver_gpios(dev, acpi_int3496_default_gpios); > if (ret) { > dev_err(dev, "can't add GPIO ACPI mapping\n"); > return ret; > @@ -169,8 +168,6 @@ static int int3496_remove(struct platform_device *pdev) > devm_free_irq(&pdev->dev, data->usb_id_irq, data); > cancel_delayed_work_sync(&data->work); > > - acpi_dev_remove_driver_gpios(ACPI_COMPANION(&pdev->dev)); > - > return 0; > } > > Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics