From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752196AbdFLIp7 (ORCPT ); Mon, 12 Jun 2017 04:45:59 -0400 Received: from regular1.263xmail.com ([211.150.99.131]:43201 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751988AbdFLIp6 (ORCPT ); Mon, 12 Jun 2017 04:45:58 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: lee.jones@linaro.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <593E54C0.8030303@rock-chips.com> Date: Mon, 12 Jun 2017 16:45:52 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Lee Jones CC: linux-kernel@vger.kernel.org, briannorris@chromium.org, dtor@chromium.org, dianders@chromium.org Subject: Re: [PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove References: <1497246453-11151-1-git-send-email-jeffy.chen@rock-chips.com> <20170612081754.mg6pnrr45wq2jj7a@dell> In-Reply-To: <20170612081754.mg6pnrr45wq2jj7a@dell> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, On 06/12/2017 04:17 PM, Lee Jones wrote: > mfd: cros_ec: Add missing free_irq in cros_ec_remove > > It would be better to use more English and less code in the patch's > subject line. Something like "Clean-up IRQ on unbind" Or "Free IRQ on > exit". Something of that nature. > > Also, you should populate the commit log with what are you doing and > why is it required. oh, right, thanks for your comment, i'll rewrite it :) > >> Signed-off-by: Jeffy Chen >> >> --- >> >> drivers/mfd/cros_ec.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c >> index e31ac60..dc6ce90 100644 >> --- a/drivers/mfd/cros_ec.c >> +++ b/drivers/mfd/cros_ec.c >> @@ -183,6 +183,9 @@ int cros_ec_remove(struct cros_ec_device *ec_dev) >> >> cros_ec_acpi_remove_gpe_handler(); >> >> + if (ec_dev->irq) >> + free_irq(ec_dev->irq, ec_dev); >> + >> return 0; >> } >> EXPORT_SYMBOL(cros_ec_remove); >