* [PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove
@ 2017-06-12 5:47 Jeffy Chen
2017-06-12 8:17 ` Lee Jones
0 siblings, 1 reply; 3+ messages in thread
From: Jeffy Chen @ 2017-06-12 5:47 UTC (permalink / raw)
To: linux-kernel, lee.jones; +Cc: briannorris, dtor, dianders, Jeffy Chen
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/mfd/cros_ec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
index e31ac60..dc6ce90 100644
--- a/drivers/mfd/cros_ec.c
+++ b/drivers/mfd/cros_ec.c
@@ -183,6 +183,9 @@ int cros_ec_remove(struct cros_ec_device *ec_dev)
cros_ec_acpi_remove_gpe_handler();
+ if (ec_dev->irq)
+ free_irq(ec_dev->irq, ec_dev);
+
return 0;
}
EXPORT_SYMBOL(cros_ec_remove);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove
2017-06-12 5:47 [PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove Jeffy Chen
@ 2017-06-12 8:17 ` Lee Jones
2017-06-12 8:45 ` jeffy
0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2017-06-12 8:17 UTC (permalink / raw)
To: Jeffy Chen; +Cc: linux-kernel, briannorris, dtor, dianders
mfd: cros_ec: Add missing free_irq in cros_ec_remove
It would be better to use more English and less code in the patch's
subject line. Something like "Clean-up IRQ on unbind" Or "Free IRQ on
exit". Something of that nature.
Also, you should populate the commit log with what are you doing and
why is it required.
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>
> ---
>
> drivers/mfd/cros_ec.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
> index e31ac60..dc6ce90 100644
> --- a/drivers/mfd/cros_ec.c
> +++ b/drivers/mfd/cros_ec.c
> @@ -183,6 +183,9 @@ int cros_ec_remove(struct cros_ec_device *ec_dev)
>
> cros_ec_acpi_remove_gpe_handler();
>
> + if (ec_dev->irq)
> + free_irq(ec_dev->irq, ec_dev);
> +
> return 0;
> }
> EXPORT_SYMBOL(cros_ec_remove);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove
2017-06-12 8:17 ` Lee Jones
@ 2017-06-12 8:45 ` jeffy
0 siblings, 0 replies; 3+ messages in thread
From: jeffy @ 2017-06-12 8:45 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, briannorris, dtor, dianders
Hi Lee,
On 06/12/2017 04:17 PM, Lee Jones wrote:
> mfd: cros_ec: Add missing free_irq in cros_ec_remove
>
> It would be better to use more English and less code in the patch's
> subject line. Something like "Clean-up IRQ on unbind" Or "Free IRQ on
> exit". Something of that nature.
>
> Also, you should populate the commit log with what are you doing and
> why is it required.
oh, right, thanks for your comment, i'll rewrite it :)
>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>>
>> ---
>>
>> drivers/mfd/cros_ec.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
>> index e31ac60..dc6ce90 100644
>> --- a/drivers/mfd/cros_ec.c
>> +++ b/drivers/mfd/cros_ec.c
>> @@ -183,6 +183,9 @@ int cros_ec_remove(struct cros_ec_device *ec_dev)
>>
>> cros_ec_acpi_remove_gpe_handler();
>>
>> + if (ec_dev->irq)
>> + free_irq(ec_dev->irq, ec_dev);
>> +
>> return 0;
>> }
>> EXPORT_SYMBOL(cros_ec_remove);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-12 8:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-12 5:47 [PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove Jeffy Chen
2017-06-12 8:17 ` Lee Jones
2017-06-12 8:45 ` jeffy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox