From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752714AbdFMJZ4 (ORCPT ); Tue, 13 Jun 2017 05:25:56 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:27367 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752397AbdFMJZx (ORCPT ); Tue, 13 Jun 2017 05:25:53 -0400 X-AuditID: b6c32a38-f791a6d0000031eb-82-593faf9f5e04 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <593FAF9E.1040406@samsung.com> Date: Tue, 13 Jun 2017 18:25:50 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hoegeun Kwon , jy0922.shim@samsung.com, sw0312.kim@samsung.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org Cc: javier@osg.samsung.com, a.hajda@samsung.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/exynos/dsi: Remove error handling for bridge_node DT parsing In-reply-to: <1497000180-30669-1-git-send-email-hoegeun.kwon@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0zTYBT1a7euEKZlCt6QqEuNJmA26RzQqYBGNFMwmfGHohJooAKBrWTd VPyjJoI6H8gjEZGIGFQkIDgQ5hOdJj6imyjie4pGUXyBKDHGRDc6o//ud+8593zn5JK4qomI IvMtNt5q4QppIlTWeTVao6lrTU6P7XSGsU9OeeTsXs9NjO39/oVgv5xwEOzHT80Y+87XI2PL Xn/AWa+3TcE6X/fJ2fvnagm22nsJY6sr3xMLwozOpl2EsWv0pdz4Yvd1zNjesMXYUfZcYdzX 0YSMI86pJsUafn4ez+XwVjVvyRZy8i25iXTqysxFmXHxsYyGMbAJtNrCmflEOiXNpFmSX+j/ KK3ewBXa/S0TJ4r07KT5VsFu49V5gmhLpNcyjE7LxCZodTqdVj8nY64uzg/J4vOG2u1Fw+Sm 9k9nZVvRMYUDhZBA6eFyyYBMqiPhrq+VcKBQUkW5ENQN75VJjxEELpcD/8s419uKpEELgjcN v+SBgZIKhx+VPj+DJHFqGly7VxBo41Q0vPtWEVzkQ9C9swqT8DFw+NsbPICXUTPg2c/kQJvw l+WNL4hAHUGthrN1o4oAdxJViaBz9MOYME6dR9BXe2TMw0RqFfS/rR9jhFBL4WnzsDwAAsqj gLvVP4mAAlBTwHk56CAFXt6oDnqeCIPXO4JZRMG29/2YxN2BoPTg7eCi7Qh+7+kNMubALcc2 TPI2Hj5/3yOXBJSws1QlQYzgG+wPLl0ILY3HMcl+LQLvQK1iP5pW819iNf8Sq/kvsSMIb0KR fJFozuVFpkivFTmzaLfkarMFsxON3WkM60IXPGluRJGIDlM2ViSlq+TcBrHY7EZA4vQkZWlz crpKmcMVb+atQqbVXsiLbhTnD7wcj4rIFvxXb7FlMnpDrD5e5781A8PQk5URrX2rVVQuZ+ML eL6It/7lYWRI1FZEpjrDq9QH879OX/lou4n8ykxmTx/KSMIXDYVunD2zyq0pyxq5mEGePOAq W2+aMNp1YNO6ZQ+Vs1ISe15l1fUcGqhPKNn/rK2he8U4ouKOVyg/aXD3MpsvHrsqPPD0n1ls 6BK6vYNZQyXL4gfP6K4UT0iKcz1OXR7dQvw+OjLvs20eLRPzOCYGt4rcH2fU/pq9AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKIsWRmVeSWpSXmKPExsVy+t9jQd156+0jDe4dNLO4te4cq0XvuZNM Fle+vmezeL+8i83izds1TBYv7l1kseh//JrZ4vz5DewWmx5fY7W4vGsOm8WM8/uYLGZMfsnm wOOxaVUnm8f2bw9YPe53H2fy2Lyk3mNL/112j74tqxg9Pm+SC2CPcrPJSE1MSS1SSM1Lzk/J zEu3VQoNcdO1UFLIS8xNtVWK0PUNCVJSKEvMKQXyjAzQgINzgHuwkr5dglvGh82lBR85Kja/ 3cnSwLiUvYuRk0NCwERi15X1jBC2mMSFe+vZuhi5OIQEVjNKbF/czgSS4BUQlPgx+R5LFyMH B7OAvMSRS9kQprrElCm5EOUPGCXObe9ghCjXkpj35SkzSA2LgKrEnV/2IGE2IHPiivtsIGFR gQiJ7hOVIK0iApMZJVZvuMYM4jAL7GaUWPD4MNhaYYFwiSfnHzNCLJjHKHHhxVJmkASngKfE 7TUfWScwCsxCct4shPNmIZy3gJF5FSNXakFxbnpusVGB4SZGYBRuO6zlv4Pxx9noQ4wCHIxK PLwrJtlFCrEmlhVX5h5ilOBgVhLhbVtjHynEm5JYWZValB9fVJqTWnyI0RToo4nMUqLJ+cAE kVcSb2hiaWRiYGZmaGRgbKYkzjsh8EuEkEB6YklqdmpqQWoRTB8TB6dUA2PLwj98Z3/NuGj2 wkdUfHGk+dyKtxE+864/qds/8/zOdJFZc1Z7ngiuYzadd+wv640D7Yv9atN5g1fK/v3B7Lgo tuiUr7v57BXmRRsMzizeddbvzNovy0uUF2jN+zEneYbZ0Q3TVj2r9u41Xhbsd2f9pb5ZixpD i9g6/KJP5fAU6H3z+vXwnKKmEktxRqKhFnNRcSIAKHX2oNgCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170613092550epcas1p4e4f83ec6e4b65b56c0974a1a15e1a6ea X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?64yA7J246riwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?SW5raSBEYWUbVGl6ZW4gUGxhdGZvcm0gTGFiLhtTYW1zdW5n?= =?UTF-8?B?IEVsZWN0cm9uaWNzG1NlbmlvciBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170609092307epcas5p3a7851f80bd799626782941a640824521 X-RootMTR: 20170609092307epcas5p3a7851f80bd799626782941a640824521 References: <1497000180-30669-1-git-send-email-hoegeun.kwon@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017년 06월 09일 18:23에 Hoegeun Kwon 이(가) 쓴 글: > The bridge_node is unnecessary between FIMD and DSIM. If don't remove > error handling, it will not work between FIMD and DSIM. So remove > error handling. Please make sure to describe why bridge_node is unnecessary. For example, In case of Exynos SoC, a bridge device such as mDNIe and MIC could be placed between Display Controller and MIPI DSI device but the bridge device is required optionally. Thanks, Inki Dae > > Signed-off-by: Hoegeun Kwon > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > index a11b795..6ee0dac 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > @@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi) > return ret; > > dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0); > - if (!dsi->bridge_node) > - return -EINVAL; > > return 0; > } >