From: Stephen Boyd <sboyd@kernel.org>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: Re: [PATCH] clk: qcom: gcc-sc8280xp: don't use parking clk_ops for QUPs
Date: Tue, 03 Sep 2024 13:02:23 -0700 [thread overview]
Message-ID: <59429303c8158b146b24d14f4869fcd5.sboyd@kernel.org> (raw)
In-Reply-To: <20240902070830.8535-1-johan+linaro@kernel.org>
Quoting Johan Hovold (2024-09-02 00:08:30)
> A recent change started parking the RCG at an always on parent during
> registration, something which specifically breaks handover from an early
> serial console.
>
> Quoting Stephen Boyd who fixed this issue for SM8550 [1]:
>
> The QUPs aren't shared in a way that requires parking the RCG at
> an always on parent in case some other entity turns on the clk.
> The hardware is capable of setting a new frequency itself with
> the DFS mode, so parking is unnecessary. Furthermore, there
> aren't any GDSCs for these devices, so there isn't a possibility
> of the GDSC turning on the clks for housekeeping purposes.
>
> This wasn't a problem to mark these clks shared until we started
> parking shared RCGs at clk registration time in commit
> 01a0a6cc8cfd ("clk: qcom: Park shared RCGs upon registration").
> Parking at init is actually harmful to the UART when earlycon is
> used. If the device is pumping out data while the frequency
> changes you'll see garbage on the serial console until the
> driver can probe and actually set a proper frequency.
>
> Fixes: 01a0a6cc8cfd ("clk: qcom: Park shared RCGs upon registration")
> Fixes: d65d005f9a6c ("clk: qcom: add sc8280xp GCC driver")
> Link: https://lore.kernel.org/all/20240819233628.2074654-2-swboyd@chromium.org/ [1]
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
Applied to clk-fixes
prev parent reply other threads:[~2024-09-03 20:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 7:08 [PATCH] clk: qcom: gcc-sc8280xp: don't use parking clk_ops for QUPs Johan Hovold
2024-09-03 20:02 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59429303c8158b146b24d14f4869fcd5.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=andersson@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox