From: jeffy <jeffy.chen@rock-chips.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org,
dmitry.torokhov@gmail.com, dianders@chromium.org,
Kukjin Kim <kgene@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
devicetree@vger.kernel.org,
Jonathan Hunter <jonathanh@nvidia.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-tegra@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
linux-samsung-soc@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Will Deacon <will.deacon@arm.com>,
linux-rockchip@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices
Date: Thu, 22 Jun 2017 10:33:47 +0800 [thread overview]
Message-ID: <594B2C8B.3000401@rock-chips.com> (raw)
In-Reply-To: <20170621153632.7cajs5xwdmhdm2fg@kozik-lap>
Hi Krzysztof,
thanx for noting that, will add it to next version :)
On 06/21/2017 11:36 PM, Krzysztof Kozlowski wrote:
> On Wed, Jun 21, 2017 at 11:33:29PM +0800, jeffy wrote:
>> Hi Krzysztof,
>>
>> thanx for your comment.
>>
>> On 06/21/2017 06:45 PM, Krzysztof Kozlowski wrote:
>>> On Wed, Jun 21, 2017 at 12:01 PM, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
>>>> We used to enable wakeup for cros-ec-spi devices unconditionally.
>>>> Now we are using the more generic wakeup-source property to enable it.
>>>
>>> Using wakeup-source property is still enabling this unconditionally.
>>> What do you exactly mean here?
>> i mean the wakeup-source is an optional property, we can disable wakeup by
>> not adding it.
>
> Maybe mention this in commit msg? This removes any confusion. "Till now
> the driver always enabled wakeup but now it supports wakeup property so
> add it to keep same functionality."
>
> Best regards,
> Krzysztof
>
>
>
>
next prev parent reply other threads:[~2017-06-22 2:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 10:01 [RFC PATCH v3 0/6] Report wakeup events in cros_ec_keyb and make cros-ec-spi wakeup optional Jeffy Chen
2017-06-21 10:01 ` [RFC PATCH v3 1/6] spi: core: add support for wakeup-source dts property Jeffy Chen
2017-06-21 10:52 ` Mark Brown
2017-06-21 10:01 ` [RFC PATCH v3 2/6] dt-bindings: spi/core: add wakeup-source optional property Jeffy Chen
2017-06-26 16:00 ` Rob Herring
2017-06-26 16:40 ` Dmitry Torokhov
2017-06-27 2:04 ` jeffy
2017-06-30 14:44 ` Rob Herring
2017-06-21 10:01 ` [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices Jeffy Chen
2017-06-21 10:45 ` Krzysztof Kozlowski
[not found] ` <594A91C9.1090906@rock-chips.com>
2017-06-21 15:36 ` Krzysztof Kozlowski
2017-06-22 2:33 ` jeffy [this message]
2017-06-21 10:01 ` [RFC PATCH v3 4/6] mfd: cros ec: spi: remove unconditionally wakeup enable Jeffy Chen
2017-06-21 10:01 ` [RFC PATCH v3 5/6] input: cros_ec_keyb: report wakeup events Jeffy Chen
2017-06-21 10:01 ` [RFC PATCH v3 6/6] ARM: dts: cros-ec-keyboard: enable as wakeup source Jeffy Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=594B2C8B.3000401@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=briannorris@chromium.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=heiko@sntech.de \
--cc=jonathanh@nvidia.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox