From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751371AbcDQPY6 (ORCPT ); Sun, 17 Apr 2016 11:24:58 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:49297 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872AbcDQPY5 (ORCPT ); Sun, 17 Apr 2016 11:24:57 -0400 From: Arnd Bergmann To: Robert Jarzmik Cc: Daniel Mack , Haojian Zhuang , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] ARM: pxa: add pxa25x device-tree support Date: Sun, 17 Apr 2016 17:24:12 +0200 Message-ID: <5954693.SgGqqDgWJO@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1460316600-15978-2-git-send-email-robert.jarzmik@free.fr> References: <1460316600-15978-1-git-send-email-robert.jarzmik@free.fr> <1460316600-15978-2-git-send-email-robert.jarzmik@free.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:9X+ayQ6JuWU6E8lCz6HeF8Nw2WB/iCXC0i6AHFTv7cgPZj1r67L 9djMwjy4dzrWg71D31izl2KBxr6HNzTM76F48o9sivh9JRqSPBwrznlBRQwIwGLtg9FIFc8 gEwyOuvTOlAzhT66rfym55BnZkwdI6eCI8Jbxx6o+XPDpPuymQMHS4q2WeXVq7ASkiEM9b3 lbZEGOhNQlx6F4iXn+azw== X-UI-Out-Filterresults: notjunk:1;V01:K0:XQfYjqvROHc=:KYn+itUf7VwtfYvtp6+R8o pUaYxnfJnYk6muawpysD13+yH1e7x/kh+TM6K2Xl5brsgOxQZ494V1h4JKUugSPiYQqlmzlNt 6TWkN2ssLnEaNdf6oWEka24cLSxV5oLRo5jfI2pfGQGoO5U7IYYFZ2slBcMuAUyclsL3e6ZSf 6bjGa6deRUPEGn7Sm2XAdO1Fe/e1QNYZcyvsVtXkh4M0K4y2SxaPUAQhqnl8kwsafrDiSc2dj K3PI7fYLl2zeqm4Tv3VyGM9Syh5IJYDgIRRlNt8G+r2eoI/8T2ncZugCBiaYkkd9dWP7dvF9X Bi3wVch8D1tM9uaoPN2dJ4KYbBLgoJ2WY9atozxmabPzaG/2BgjowshbYaWtD3msAnPmm8NhT 0M9cBdTaBo6CPirocnJ4MdgWYAMmzVUURTplp8ygaeqvuBSV+n9021Pn44skdQDKZoZiNXj1R LHM5P8AeL07xhM7IipTg3eUgtXT5zvahPnOhLiEHPZllTrhY9Sksb6fAf5D45smAKL4Zbfhy6 3blX1fG7MIhozlRVKVvuzWf3Zxy7LCBrbfJAuEGXQ0HinWd9F+ezt1vxM7RpN+M3RI+6y+AGt LaLLaZdy3dyzNdetwsb2c09RwNHr4v1ny58KfQpKg4+BavP4TJwCQsN1c9Prp7+LNcko77cF+ reiIi4SpjwqYc9XG0qnJgu6f+WbYeqR4lo+JSrTfs5qtkTQ4kIneduvWmPqaW+6qjzwgsT8Tm cQsjKherElfcRXcn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 10 April 2016 21:29:59 Robert Jarzmik wrote: > + > +DT_MACHINE_START(PXA_DT, "Marvell PXA3xx (Device Tree Support)") > + .map_io = pxa3xx_map_io, > + .init_irq = pxa3xx_dt_init_irq, > + .handle_irq = pxa3xx_handle_irq, > + .restart = pxa_restart, > + .dt_compat = pxa3xx_dt_board_compat, > +MACHINE_END > Nothing wrong with your series, it's a straightforward continuation of what you have for the other platforms, but I have a few comments on the method overall, and it might be good if you could work on improving those next, basically eliminating most of the machine descriptor contents in the long run: - It would be nice not to call map_io() at all and instead ensure that all drivers that have DT bindings use ioremap. The main reason for this is that relying on the hardwired mapping makes it easy to get things wrong in the bindings, by leaving out required memory ranges. - The init_irq()/handle_irq() callbacks can probably be replaced with a IRQCHIP_DECLARE() statement per irqchip variant, which then goes on to initialize the controller and set the handler. - The restart method is the least important here, but I guess we can convert that into a driver, or use an existing one from DT, like drivers/power/reset/gpio-restart.c Arnd