From: Daniel Borkmann <daniel@iogearbox.net>
To: Michael Ellerman <mpe@ellerman.id.au>,
kernel-hardening@lists.openwall.com
Cc: keescook@chromium.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, labbott@redhat.com
Subject: Re: [kernel-hardening] [RFC PATCH 1/4] Provide linux/set_memory.h
Date: Thu, 29 Jun 2017 11:03:30 +0200 [thread overview]
Message-ID: <5954C262.9000502@iogearbox.net> (raw)
In-Reply-To: <1498717781-29151-1-git-send-email-mpe@ellerman.id.au>
On 06/29/2017 08:29 AM, Michael Ellerman wrote:
> Currently code that wants to use set_memory_ro() etc, needs to include
> asm/set_memory.h, which doesn't exist on all arches. Some code knows
> it only builds on arches which have the header, other code guards the
> inclusion with an #ifdef, neither is ideal.
>
> So create linux/set_memory.h. This always exists, so users don't need
> an #ifdef just to include the header.
>
> When CONFIG_ARCH_HAS_SET_MEMORY=y it includes asm/set_memory.h,
> otherwise it provides empty non-failing implementations.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Looks good to me, thanks!
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
I'm fine if Andrew or Kees picks up the bpf patch as well, I think
there shouldn't be any conflict with net-next on this one (and even
if so, then looks trivial to resolve).
next prev parent reply other threads:[~2017-06-29 9:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 6:29 [RFC PATCH 1/4] Provide linux/set_memory.h Michael Ellerman
2017-06-29 6:29 ` [RFC PATCH 2/4] PM / hibernate: Use linux/set_memory.h Michael Ellerman
2017-06-29 6:29 ` [RFC PATCH 3/4] module: " Michael Ellerman
2017-06-29 6:29 ` [RFC PATCH 4/4] bpf: " Michael Ellerman
2017-06-29 8:57 ` [kernel-hardening] " Daniel Borkmann
2017-06-29 9:03 ` Daniel Borkmann [this message]
2017-06-29 16:11 ` [kernel-hardening] [RFC PATCH 1/4] Provide linux/set_memory.h Kees Cook
2017-06-30 1:43 ` Michael Ellerman
2017-06-29 16:45 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5954C262.9000502@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox