From: Chanwoo Choi <cw00.choi@samsung.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe()
Date: Fri, 30 Jun 2017 17:02:18 +0900 [thread overview]
Message-ID: <5956058A.3090304@samsung.com> (raw)
In-Reply-To: <20170630072211.GA21867@embeddedgus>
Hi,
On 2017년 06월 30일 16:22, Gustavo A. R. Silva wrote:
> Print and propagate the return value of platform_get_irq on failure.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/devfreq/tegra-devfreq.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
> index 214fff9..ae71215 100644
> --- a/drivers/devfreq/tegra-devfreq.c
> +++ b/drivers/devfreq/tegra-devfreq.c
> @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> - if (irq <= 0) {
> - dev_err(&pdev->dev, "Failed to get IRQ\n");
> - return -ENODEV;
> + if (irq < 0) {
> + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
> + return irq;
> }
>
> platform_set_drvdata(pdev, tegra);
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2017-06-30 8:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170630072216epcas1p34027491553237c57f0270b3f305f0058@epcas1p3.samsung.com>
2017-06-30 7:22 ` [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() Gustavo A. R. Silva
2017-06-30 8:02 ` Chanwoo Choi [this message]
2017-07-01 7:42 ` MyungJoo Ham
2017-07-03 11:35 ` Jon Hunter
2017-07-03 11:59 ` Gustavo A. R. Silva
2017-07-03 12:22 ` Jon Hunter
2017-07-03 12:47 ` [PATCH v2] devfreq: tegra: fix error return " Gustavo A. R. Silva
2017-07-04 8:35 ` Jon Hunter
2017-07-17 4:52 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5956058A.3090304@samsung.com \
--to=cw00.choi@samsung.com \
--cc=garsilva@embeddedor.com \
--cc=jonathanh@nvidia.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox