From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753156AbdGJA4p (ORCPT ); Sun, 9 Jul 2017 20:56:45 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:60721 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752276AbdGJA4m (ORCPT ); Sun, 9 Jul 2017 20:56:42 -0400 X-AuditID: b6c32a38-f793c6d000001aba-41-5962d0c89b9d MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <5962D0C6.5060803@samsung.com> Date: Mon, 10 Jul 2017 09:56:38 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Jaechul Lee , Krzysztof Kozlowski , Sangbeom Kim , Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel Cc: Jaechul Lee , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ASoC: samsung: i2s: Support more resolution rates In-reply-to: <20170707013110.7060-1-jcsing.lee@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKJsWRmVeSWpSXmKPExsWy7bCmru6JC0mRBreOcVtcuXiIyWLqwyds FsdXzmK2eLu/m9ni/PkN7BbfrnQwWVzeNYfNYsb5fUwWnbv6WS0Ov2lntbi44guTxYbvaxkd eDw2fG5i89g56y67x6ZVnWwe+94uY/Po27KK0WP9lqssHp83yQWwR6XaZKQmpqQWKaTmJeen ZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gBdqqRQlphTChQKSCwuVtK3synK Ly1JVcjILy6xVYo2NDTSMzQw1zMyMtIzMY61MjIFKklIzTg87wBLwTXVivULzzM3MG6Q62Lk 5JAQMJFY8eozC4QtJnHh3nq2LkYuDiGBHYwSN5+dgXI+M0p8+7OWGabjy4G1CFXXz+0GS/AK CEr8mHwPaBQHB7OAvMSRS9kgYWYBTYmtu9ezQ9TfY5SYcP85M0gNr4CWxMELwSA1LAKqEi8e HmAEsdmAwvtf3GADsfkFFCWu/ngMFhcViJDYOf8b2BwRgZtMEk+2fWSEWJAucaztI9gLwgKe Ek/egxRxcHAKWEtMfBIEUi8hcItdYuL822wgcQkBWYlNB6B+cZH42faEFcIWlnh1fAs7hC0l 0fjyIRNEbzujxOY5IH+BOB2MEvdXNkJ1GEuc6mpkgjiCT+Ld1x5WiAW8Eh1tQhAlHhLHdy5h gQg7SjxqjoSEQx+jxNWD99knMCrMQgq6WYigm4UUdAsYmVcxiqUWFOempxYbFpjoFSfmFpfm pesl5+duYgQnWS2LHYx7zvkcYhTgYFTi4fWYlBQpxJpYVlyZe4hRgoNZSYS3ZzdQiDclsbIq tSg/vqg0J7X4EKMpMOgnMkuJJucDM0BeSbyhiaWBiZkRMNVZGhoqifOKrr8WISSQnliSmp2a WpBaBNPHxMEp1cC4frF5q97ubdJXrla5hirW2ullTfuvz1C1NPWvyu7t85Yw9m7yOPC95tJi pdyzfIV1C7XeNd9kiuY+YL5h6t165ZcJfrKMX28UJJy88on/98fDRwoF8uecvWfvftbY6YnV hwLONnVnTaE3a2Mll3NsWvPety9fcTK/aabph+8ixwMPy6ZMvrlQiaU4I9FQi7moOBEAiqJb dcgDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEIsWRmVeSWpSXmKPExsVy+t9jAd3jF5IiDXbtsbS4cvEQk8XUh0/Y LI6vnMVs8XZ/N7PF+fMb2C2+Xelgsri8aw6bxYzz+5gsOnf1s1ocftPOanFxxRcmiw3f1zI6 8Hhs+NzE5rFz1l12j02rOtk89r1dxubRt2UVo8f6LVdZPD5vkgtgj3KzyUhNTEktUkjNS85P ycxLt1UKDXHTtVBSyEvMTbVVitD1DQlSUihLzCkF8owM0ICDc4B7sJK+XYJbxuF5B1gKrqlW rF94nrmBcYNcFyMnh4SAicSXA2vZIGwxiQv31gPZXBxCAtsYJS7vu8AIkuAVEJT4MfkeSxcj BwezgLzEkUvZIGFmAXWJSfMWMUPUP2CUWLDoBxNIDa+AlsTBC8EgNSwCqhIvHh4AG8MGFN7/ 4gbYLn4BRYmrPx4zgpSLCkRIdJ+oBBkjInCbSWLRw9tQq9Il5sxVBikXFvCUePL+GzvEqgmM Ek19T9hBajgFrCUmPgmawCg4C8mhsxAOnYXk0AWMzKsYuVILinPTc4uNCgw3MQLjc9thLf8d jD/ORh9iFOBgVOLh9ZiUFCnEmlhWXJl7iFGCg1lJhLdnN1CINyWxsiq1KD++qDQntfgQoynQ cxOZpUST84GpI68k3tDE0sjEwMzM0MjA2ExJnHdC4JcIIYH0xJLU7NTUgtQimD4mDk6pBsb6 9/cW7b3Kyv29eN/GGS8/MoS98rSaqSJ3YPGJk79ZObh2O1o1766f+2BWeFndzf3un5J0v7wu 72UP5/j5IjSv71Rz1bmM9gP6Vh2rHLsK9Ctj75Y8r5tfukrvyz3N/3//6bj8fef8837lBr7V Vualf98cPzn5WUXLw6Lrvk1Nl+U//DdfsvmGEktxRqKhFnNRcSIAcgzxauUCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170710005639epcas1p2b4960fdd03fa354e4a5c93ccb7fbe09c X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170707013112epcas5p43273c95afd43b18ded971bea081edd40 X-RootMTR: 20170707013112epcas5p43273c95afd43b18ded971bea081edd40 References: <20170707013110.7060-1-jcsing.lee@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaechul, Looks good to me. Reviewed-by: Chanwoo Choi On 2017년 07월 07일 10:31, Jaechul Lee wrote: > This driver can support more frequencies over 96KHz. There are no reasons > to limit the frequency range below 96KHz. If codecs/amps or something else > can't support higher resolution rates, the constraints would be set rates > properly because each drivers have its own limits. > > I added the 'pcm_rates' field to the dai_data to be set rates by the > compatibilities. As a result, rates will be set each devices respectively. > For example of exynos5433, rates will be set from 8KHz to 192KHz. > > Signed-off-by: Jaechul Lee > --- > v2: > - changed the name of variable to pcm_rates. > - removed duplicated code. > - modified commit message. > --- > sound/soc/samsung/i2s.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c > index af3ba4d4ccc5..c9f87f7bae99 100644 > --- a/sound/soc/samsung/i2s.c > +++ b/sound/soc/samsung/i2s.c > @@ -50,6 +50,7 @@ struct samsung_i2s_variant_regs { > > struct samsung_i2s_dai_data { > u32 quirks; > + unsigned int pcm_rates; > const struct samsung_i2s_variant_regs *i2s_variant_regs; > }; > > @@ -1076,13 +1077,13 @@ static const struct snd_soc_component_driver samsung_i2s_component = { > .name = "samsung-i2s", > }; > > -#define SAMSUNG_I2S_RATES SNDRV_PCM_RATE_8000_96000 > - > #define SAMSUNG_I2S_FMTS (SNDRV_PCM_FMTBIT_S8 | \ > SNDRV_PCM_FMTBIT_S16_LE | \ > SNDRV_PCM_FMTBIT_S24_LE) > > -static struct i2s_dai *i2s_alloc_dai(struct platform_device *pdev, bool sec) > +static struct i2s_dai *i2s_alloc_dai(struct platform_device *pdev, > + const struct samsung_i2s_dai_data *i2s_dai_data, > + bool sec) > { > struct i2s_dai *i2s; > > @@ -1101,13 +1102,13 @@ static struct i2s_dai *i2s_alloc_dai(struct platform_device *pdev, bool sec) > i2s->i2s_dai_drv.resume = i2s_resume; > i2s->i2s_dai_drv.playback.channels_min = 1; > i2s->i2s_dai_drv.playback.channels_max = 2; > - i2s->i2s_dai_drv.playback.rates = SAMSUNG_I2S_RATES; > + i2s->i2s_dai_drv.playback.rates = i2s_dai_data->pcm_rates; > i2s->i2s_dai_drv.playback.formats = SAMSUNG_I2S_FMTS; > > if (!sec) { > i2s->i2s_dai_drv.capture.channels_min = 1; > i2s->i2s_dai_drv.capture.channels_max = 2; > - i2s->i2s_dai_drv.capture.rates = SAMSUNG_I2S_RATES; > + i2s->i2s_dai_drv.capture.rates = i2s_dai_data->pcm_rates; > i2s->i2s_dai_drv.capture.formats = SAMSUNG_I2S_FMTS; > } > return i2s; > @@ -1242,7 +1243,7 @@ static int samsung_i2s_probe(struct platform_device *pdev) > i2s_dai_data = (struct samsung_i2s_dai_data *) > platform_get_device_id(pdev)->driver_data; > > - pri_dai = i2s_alloc_dai(pdev, false); > + pri_dai = i2s_alloc_dai(pdev, i2s_dai_data, false); > if (!pri_dai) { > dev_err(&pdev->dev, "Unable to alloc I2S_pri\n"); > return -ENOMEM; > @@ -1316,7 +1317,7 @@ static int samsung_i2s_probe(struct platform_device *pdev) > goto err_disable_clk; > > if (quirks & QUIRK_SEC_DAI) { > - sec_dai = i2s_alloc_dai(pdev, true); > + sec_dai = i2s_alloc_dai(pdev, i2s_dai_data, true); > if (!sec_dai) { > dev_err(&pdev->dev, "Unable to alloc I2S_sec\n"); > ret = -ENOMEM; > @@ -1452,29 +1453,34 @@ static const struct samsung_i2s_variant_regs i2sv5_i2s1_regs = { > > static const struct samsung_i2s_dai_data i2sv3_dai_type = { > .quirks = QUIRK_NO_MUXPSR, > + .pcm_rates = SNDRV_PCM_RATE_8000_96000, > .i2s_variant_regs = &i2sv3_regs, > }; > > static const struct samsung_i2s_dai_data i2sv5_dai_type = { > .quirks = QUIRK_PRI_6CHAN | QUIRK_SEC_DAI | QUIRK_NEED_RSTCLR | > QUIRK_SUPPORTS_IDMA, > + .pcm_rates = SNDRV_PCM_RATE_8000_96000, > .i2s_variant_regs = &i2sv3_regs, > }; > > static const struct samsung_i2s_dai_data i2sv6_dai_type = { > .quirks = QUIRK_PRI_6CHAN | QUIRK_SEC_DAI | QUIRK_NEED_RSTCLR | > QUIRK_SUPPORTS_TDM | QUIRK_SUPPORTS_IDMA, > + .pcm_rates = SNDRV_PCM_RATE_8000_96000, > .i2s_variant_regs = &i2sv6_regs, > }; > > static const struct samsung_i2s_dai_data i2sv7_dai_type = { > .quirks = QUIRK_PRI_6CHAN | QUIRK_SEC_DAI | QUIRK_NEED_RSTCLR | > QUIRK_SUPPORTS_TDM, > + .pcm_rates = SNDRV_PCM_RATE_8000_192000, > .i2s_variant_regs = &i2sv7_regs, > }; > > static const struct samsung_i2s_dai_data i2sv5_dai_type_i2s1 = { > .quirks = QUIRK_PRI_6CHAN | QUIRK_NEED_RSTCLR, > + .pcm_rates = SNDRV_PCM_RATE_8000_96000, > .i2s_variant_regs = &i2sv5_i2s1_regs, > }; > > -- Best Regards, Chanwoo Choi Samsung Electronics