From: wangyijing <wangyijing@huawei.com>
To: John Garry <john.garry@huawei.com>, <jejb@linux.vnet.ibm.com>,
<martin.petersen@oracle.com>
Cc: <chenqilin2@huawei.com>, <hare@suse.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<chenxiang66@hisilicon.com>, <huangdaode@hisilicon.com>,
<wangkefeng.wang@huawei.com>, <zhaohongjiang@huawei.com>,
<dingtianhong@huawei.com>, <guohanjun@huawei.com>,
<yanaijie@huawei.com>, <hch@lst.de>, <dan.j.williams@intel.com>,
<emilne@redhat.com>, <thenzl@redhat.com>, <wefu@redhat.com>,
<charles.chenxin@huawei.com>, <chenweilong@huawei.com>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH v3 0/7] Enhance libsas hotplug feature
Date: Thu, 13 Jul 2017 16:38:18 +0800 [thread overview]
Message-ID: <5967317A.9080401@huawei.com> (raw)
In-Reply-To: <47ad4316-e374-26db-3cbe-aa91642aeb68@huawei.com>
在 2017/7/13 16:08, John Garry 写道:
> On 13/07/2017 02:37, wangyijing wrote:
>>> > So much nicer. BTW, /dev/sdb is a SATA disk, the rest are SAS.
>> Oh, I take a mistake ? The result you tested the hotplug which applied this patchset is fine ?
>>
>> Thanks!
>> Yijing.
>
> Well basic hotplug is fine, as below. I did not do any robust testing.
>
OK， thanks，I tested with and without fio running, the results are both fine.
Thanks!
Yijing.
> root@(none)$ echo 0 > ./phy-0:7/sas_phy/phy-0:7/enable
> root@(none)$ [ 180.147676] hisi_sas_v2_hw HISI0162:01: found dev[8:1] is gone
> [ 180.216558] hisi_sas_v2_hw HISI0162:01: found dev[7:1] is gone
> [ 180.280548] hisi_sas_v2_hw HISI0162:01: found dev[6:1] is gone
> [ 180.352556] hisi_sas_v2_hw HISI0162:01: found dev[5:1] is gone
> [ 180.432495] hisi_sas_v2_hw HISI0162:01: found dev[4:1] is gone
> [ 180.508492] hisi_sas_v2_hw HISI0162:01: found dev[3:1] is gone
> [ 180.527577] sd 0:0:1:0: [sdb] Synchronizing SCSI cache
> [ 180.532728] sd 0:0:1:0: [sdb] Synchronize Cache(10) failed: Result: hostbyte=0x04 driverbyte=0x00
> [ 180.541591] sd 0:0:1:0: [sdb] Stopping disk
> [ 180.545767] sd 0:0:1:0: [sdb] Start/Stop Unit failed: Result: hostbyte=0x04 driverbyte=0x00
> [ 180.612491] hisi_sas_v2_hw HISI0162:01: found dev[2:5] is gone
> [ 180.696452] hisi_sas_v2_hw HISI0162:01: found dev[1:1] is gone
> [ 180.703221] hisi_sas_v2_hw HISI0162:01: found dev[0:2] is gone
>
> root@(none)$ echo 1 > ./phy-0:7/sas_phy/phy-0:7/enable
> root@(none)$ [ 185.937831] hisi_sas_v2_hw HISI0162:01: phyup: phy7 link_rate=11
> [ 185.996575] scsi 0:0:8:0: Direct-Access SanDisk LT0200MO P404 PQ: 0 ANSI: 6
> [ 187.059642] ata2.00: ATA-8: HGST HUS724040ALA640, MFAOA8B0, max UDMA/133
> [ 187.066341] ata2.00: 7814037168 sectors, multi 0: LBA48 NCQ (depth 31/32)
> [ 187.073278] ata2.00: ATA Identify Device Log not supported
> [ 187.078755] ata2.00: Security Log not supported
> [ 187.085239] ata2.00: ATA Identify Device Log not supported
> [ 187.090715] ata2.00: Security Log not supported
> [ 187.095236] ata2.00: configured for UDMA/133
> [ 187.136917] scsi 0:0:9:0: Direct-Access ATA HGST HUS724040AL A8B0 PQ: 0 ANSI: 5
> [ 187.187612] sd 0:0:9:0: [sdb] 7814037168 512-byte logical blocks: (4.00 TB/3.64 TiB)
> [ 187.195365] sd 0:0:9:0: [sdb] Write Protect is off
> [ 187.200161] sd 0:0:9:0: [sdb] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> [ 187.223844] sd 0:0:9:0: [sdb] Attached SCSI disk
> [ 187.225498] scsi 0:0:10:0: Direct-Access SanDisk LT0200MO P404 PQ: 0 ANSI: 6
> [ 187.243864] sd 0:0:8:0: [sda] 390721968 512-byte logical blocks: (200 GB/186 GiB)
> [ 187.285879] sd 0:0:8:0: [sda] Write Protect is off
> [ 187.367898] sd 0:0:8:0: [sda] Write cache: disabled, read cache: disabled, supports DPO and FUA
> [ 187.524043] scsi 0:0:11:0: Direct-Access SanDisk LT0200MO P404 PQ: 0 ANSI: 6
> [ 187.701505] sd 0:0:10:0: [sdc] 390721968 512-byte logical blocks: (200 GB/186 GiB)
> [ 187.743547] sd 0:0:10:0: [sdc] Write Protect is off
> [ 187.822546] scsi 0:0:12:0: Direct-Access SanDisk LT0200MO P404 PQ: 0 ANSI: 6
> [ 187.825531] sd 0:0:10:0: [sdc] Write cache: disabled, read cache: disabled, supports DPO and FUA
> [ 188.000167] sd 0:0:11:0: [sdd] 390721968 512-byte logical blocks: (200 GB/186 GiB)
> [ 188.042205] sd 0:0:11:0: [sdd] Write Protect is off
> [ 188.121527] scsi 0:0:13:0: Direct-Access SanDisk LT0200MO P404 PQ: 0 ANSI: 6
> [ 188.124274] sd 0:0:11:0: [sdd] Write cache: disabled, read cache: disabled, supports DPO and FUA
> [ 188.298942] sd 0:0:12:0: [sde] 390721968 512-byte logical blocks: (200 GB/186 GiB)
> [ 188.340960] sd 0:0:12:0: [sde] Write Protect is off
> [ 188.420023] scsi 0:0:14:0: Direct-Access SanDisk LT0200MO P404 PQ: 0 ANSI: 6
> [ 188.422969] sd 0:0:12:0: [sde] Write cache: disabled, read cache: disabled, supports DPO and FUA
> [ 188.597501] sd 0:0:13:0: [sdf] 390721968 512-byte logical blocks: (200 GB/186 GiB)
> [ 188.605069] sd 0:0:8:0: [sda] Attached SCSI disk
> [ 188.639520] sd 0:0:13:0: [sdf] Write Protect is off
> [ 188.682445] scsi 0:0:15:0: Enclosure 12G SAS Expander RevB PQ: 0 ANSI: 6
> [ 188.721540] sd 0:0:13:0: [sdf] Write cache: disabled, read cache: disabled, supports DPO and FUA
> [ 188.896399] sd 0:0:14:0: [sdg] 390721968 512-byte logical blocks: (200 GB/186 GiB)
> [ 188.938445] sd 0:0:14:0: [sdg] Write Protect is off
> [ 189.020444] sd 0:0:14:0: [sdg] Write cache: disabled, read cache: disabled, supports DPO and FUA
> [ 189.060608] sd 0:0:10:0: [sdc] Attached SCSI disk
> [ 189.359073] sd 0:0:11:0: [sdd] Attached SCSI disk
> [ 189.657643] sd 0:0:12:0: [sde] Attached SCSI disk
> [ 189.956585] sd 0:0:13:0: [sdf] Attached SCSI disk
> [ 190.255148] sd 0:0:14:0: [sdg] Attached SCSI disk
>
> root@(none)$ echo 0 > ./phy-0:7/sas_phy/phy-0:7/enable
> root@(none)$ [ 192.895718] hisi_sas_v2_hw HISI0162:01: found dev[8:1] is gone
> [ 192.964671] hisi_sas_v2_hw HISI0162:01: found dev[7:1] is gone
> [ 193.032744] hisi_sas_v2_hw HISI0162:01: found dev[6:1] is gone
> [ 193.096755] hisi_sas_v2_hw HISI0162:01: found dev[5:1] is gone
> [ 193.157072] hisi_sas_v2_hw HISI0162:01: found dev[4:1] is gone
> [ 193.221062] hisi_sas_v2_hw HISI0162:01: found dev[3:1] is gone
> [ 193.247684] sd 0:0:9:0: [sdb] Synchronizing SCSI cache
> [ 193.252834] sd 0:0:9:0: [sdb] Synchronize Cache(10) failed: Result: hostbyte=0x04 driverbyte=0x00
> [ 193.261701] sd 0:0:9:0: [sdb] Stopping disk
> [ 193.265879] sd 0:0:9:0: [sdb] Start/Stop Unit failed: Result: hostbyte=0x04 driverbyte=0x00
> [ 193.325165] hisi_sas_v2_hw HISI0162:01: found dev[2:5] is gone
> [ 193.381094] hisi_sas_v2_hw HISI0162:01: found dev[1:1] is gone
> [ 193.388719] hisi_sas_v2_hw HISI0162:01: found dev[0:2] is gone
>
> root@(none)$ echo 1 > ./phy-0:7/sas_phy/phy-0:7/enable
> root@(none)$ [ 196.221879] hisi_sas_v2_hw HISI0162:01: phyup: phy7 link_rate=11
> [ 196.281178] scsi 0:0:16:0: Direct-Access SanDisk LT0200MO P404 PQ: 0 ANSI: 6
> [ 196.973390] ata3.00: ATA-8: HGST HUS724040ALA640, MFAOA8B0, max UDMA/133
> [ 196.980088] ata3.00: 7814037168 sectors, multi 0: LBA48 NCQ (depth 31/32)
> [ 196.987022] ata3.00: ATA Identify Device Log not supported
> [ 196.992499] ata3.00: Security Log not supported
> [ 196.998953] ata3.00: ATA Identify Device Log not supported
> [ 197.004434] ata3.00: Security Log not supported
> [ 197.008954] ata3.00: configured for UDMA/133
> [ 197.050428] scsi 0:0:17:0: Direct-Access ATA HGST HUS724040AL A8B0 PQ: 0 ANSI: 5
> [ 197.091593] sd 0:0:17:0: [sdb] 7814037168 512-byte logical blocks: (4.00 TB/3.64 TiB)
> [ 197.099441] sd 0:0:17:0: [sdb] Write Protect is off
> [ 197.104326] sd 0:0:17:0: [sdb] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> [ 197.122982] sd 0:0:17:0: [sdb] Attached SCSI disk
> [ 197.129367] scsi 0:0:18:0: Direct-Access SanDisk LT0200MO P404 PQ: 0 ANSI: 6
> [ 197.157605] sd 0:0:16:0: [sda] 390721968 512-byte logical blocks: (200 GB/186 GiB)
> [ 197.199622] sd 0:0:16:0: [sda] Write Protect is off
> [ 197.281604] sd 0:0:16:0: [sda] Write cache: disabled, read cache: disabled, supports DPO and FUA
> [ 197.427727] scsi 0:0:19:0: Direct-Access SanDisk LT0200MO P404 PQ: 0 ANSI: 6
> [ 197.605362] sd 0:0:18:0: [sdc] 390721968 512-byte logical blocks: (200 GB/186 GiB)
> [ 197.647409] sd 0:0:18:0: [sdc] Write Protect is off
> [ 197.726403] scsi 0:0:20:0: Direct-Access SanDisk LT0200MO P404 PQ: 0 ANSI: 6
> [ 197.729389] sd 0:0:18:0: [sdc] Write cache: disabled, read cache: disabled, supports DPO and FUA
> [ 197.903664] sd 0:0:19:0: [sdd] 390721968 512-byte logical blocks: (200 GB/186 GiB)
> [ 197.945699] sd 0:0:19:0: [sdd] Write Protect is off
> [ 198.024789] scsi 0:0:21:0: Direct-Access SanDisk LT0200MO P404 PQ: 0 ANSI: 6
> [ 198.027685] sd 0:0:19:0: [sdd] Write cache: disabled, read cache: disabled, supports DPO and FUA
> [ 198.202410] sd 0:0:20:0: [sde] 390721968 512-byte logical blocks: (200 GB/186 GiB)
> [ 198.244458] sd 0:0:20:0: [sde] Write Protect is off
> [ 198.323137] scsi 0:0:22:0: Direct-Access SanDisk LT0200MO P404 PQ: 0 ANSI: 6
> [ 198.326491] sd 0:0:20:0: [sde] Write cache: disabled, read cache: disabled, supports DPO and FUA
> [ 198.500754] sd 0:0:21:0: [sdf] 390721968 512-byte logical blocks: (200 GB/186 GiB)
> [ 198.516373] sd 0:0:16:0: [sda] Attached SCSI disk
> [ 198.542773] sd 0:0:21:0: [sdf] Write Protect is off
> [ 198.585184] scsi 0:0:23:0: Enclosure 12G SAS Expander RevB PQ: 0 ANSI: 6
> [ 198.624911] sd 0:0:21:0: [sdf] Write cache: disabled, read cache: disabled, supports DPO and FUA
> [ 198.799446] sd 0:0:22:0: [sdg] 390721968 512-byte logical blocks: (200 GB/186 GiB)
> [ 198.841484] sd 0:0:22:0: [sdg] Write Protect is off
> [ 198.923508] sd 0:0:22:0: [sdg] Write cache: disabled, read cache: disabled, supports DPO and FUA
> [ 198.964420] sd 0:0:18:0: [sdc] Attached SCSI disk
> [ 199.262903] sd 0:0:19:0: [sdd] Attached SCSI disk
> [ 199.561175] sd 0:0:20:0: [sde] Attached SCSI disk
> [ 199.859533] sd 0:0:21:0: [sdf] Attached SCSI disk
>
> root@(none)$ [ 200.158121] sd 0:0:22:0: [sdg] Attached SCSI disk
>
> root@(none)$
>
>
>>
>>
>>> >
>>> > John
>
>
>
> .
>
next prev parent reply other threads:[~2017-07-13 8:40 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 7:06 [PATCH v3 0/7] Enhance libsas hotplug feature Yijing Wang
2017-07-10 7:06 ` [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost Yijing Wang
2017-07-11 15:37 ` John Garry
2017-07-12 2:06 ` wangyijing
2017-07-12 8:17 ` John Garry
2017-07-12 8:47 ` wangyijing
2017-07-12 10:13 ` John Garry
2017-07-13 2:13 ` wangyijing
2017-07-14 6:40 ` Hannes Reinecke
2017-07-10 7:06 ` [PATCH v3 2/7] libsas: remove unused port_gone_completion Yijing Wang
2017-07-11 15:54 ` John Garry
2017-07-12 2:18 ` wangyijing
2017-07-14 6:40 ` Hannes Reinecke
2017-07-10 7:06 ` [PATCH v3 3/7] libsas: Use new workqueue to run sas event Yijing Wang
2017-07-14 6:42 ` Hannes Reinecke
2017-07-10 7:06 ` [PATCH v3 4/7] libsas: add sas event wait-complete support Yijing Wang
2017-07-14 6:51 ` Hannes Reinecke
2017-07-14 7:46 ` wangyijing
2017-07-14 8:42 ` John Garry
2017-07-10 7:06 ` [PATCH v3 5/7] libsas: add a new workqueue to run probe/destruct discovery event Yijing Wang
2017-07-12 16:50 ` John Garry
2017-07-13 2:36 ` wangyijing
2017-07-14 6:52 ` Hannes Reinecke
2017-07-10 7:06 ` [PATCH v3 6/7] libsas: add wait-complete support to sync " Yijing Wang
2017-07-12 13:51 ` John Garry
2017-07-13 2:19 ` wangyijing
2017-07-14 6:53 ` Hannes Reinecke
2017-07-10 7:06 ` [PATCH v3 7/7] libsas: release disco mutex during waiting in sas_ex_discover_end_dev Yijing Wang
2017-07-13 16:10 ` John Garry
2017-07-14 1:44 ` wangyijing
2017-07-14 8:26 ` John Garry
2017-07-14 6:55 ` Hannes Reinecke
2017-07-12 9:59 ` [PATCH v3 0/7] Enhance libsas hotplug feature John Garry
2017-07-12 11:56 ` Johannes Thumshirn
2017-07-13 1:27 ` wangyijing
2017-07-13 1:37 ` wangyijing
2017-07-13 8:08 ` John Garry
2017-07-13 8:38 ` wangyijing [this message]
2017-07-14 8:19 ` wangyijing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5967317A.9080401@huawei.com \
--to=wangyijing@huawei.com \
--cc=charles.chenxin@huawei.com \
--cc=chenqilin2@huawei.com \
--cc=chenweilong@huawei.com \
--cc=chenxiang66@hisilicon.com \
--cc=dan.j.williams@intel.com \
--cc=dingtianhong@huawei.com \
--cc=emilne@redhat.com \
--cc=guohanjun@huawei.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=huangdaode@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=thenzl@redhat.com \
--cc=wangkefeng.wang@huawei.com \
--cc=wefu@redhat.com \
--cc=yanaijie@huawei.com \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).