From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9ABBF3446DA for ; Sat, 21 Feb 2026 09:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771666814; cv=none; b=huzsBsGlbghH5E0f7Fpumw0PkuWrFiiTaJlMnCi0auuBUmCaVzFFtnLwkTRXFABBP4AjSTbSY9u87xZJZNi/P9q/YpuSzBnNiwiq29qybGNS0JzoXc4DGob66LL5KZ6qhbbXCBgbw5JMNRXq2fWLcjifJOYfjNT+RGvg2+q4+PU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771666814; c=relaxed/simple; bh=+T/ZYClx1R3HtRgnaGI/FCamHUwL+EtSB1lhrA2R27I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UGxRFvldn93y9SJ7NkhB0i6CEjvYddHu1SUw8aqRbP5oLZLn/JRufxvYq+6B2D/jHQLGCUROEOyIkLVB7muKQ22UuZhNH36hBJ1GliJ8i8L7dm0Y6mSE2TYp5rqT8MWXjOTUKZ+OOvG/6DVOrvuCn88gtj/9reBqLYG4KkREi1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jT7gd0YQ; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jT7gd0YQ" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4836e3288cdso19340985e9.0 for ; Sat, 21 Feb 2026 01:40:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771666811; x=1772271611; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wuF5x3a6e11GI4kifXt3xbSibryG5QrOhbEp/FvY8E0=; b=jT7gd0YQaJ+DQDnbRaAgpbMEsvJrfYmkMBX8qd/bgcy1mLGrzJnnw1AWhLrUBcGEni tFx54u+qiPmtrtXLqajrbQK/CELswolbwkQvGCLPpA/ea30s+kKpKyXsgzto2edWP4Bd FasZU8B7IzHMxo+dl3lLiVuTki8cazjRfvlPDvVn229SUPJbNPF5bG63QrQfxZ+aedfH BgNZ4XsYKhPEpN+N81WXVBKVTD87Q4xpspArETYk9qcZ0ReriTly2B8VKWa9ed/pyQQH FqHPaGNN3MEpHivtoHVBEvlAgSAYGS47p4y62f0Wad4BxPR96OiJc6KI1PSpX34wTQY1 7viA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771666811; x=1772271611; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wuF5x3a6e11GI4kifXt3xbSibryG5QrOhbEp/FvY8E0=; b=lM/4jy0BroBtCb3wOszEUGEpR9Y5THfw0n5e8Jx6RmouRuu6UELuaevOZmPnKva3U4 iNoMvGyVOOhJxug+WfEmFZhe9mMrZPE0dzkCP/UhYQ2C3VBZiDd6xK7F9rtr+JpCNDUV n0e9WDUPr619HkQaojnvOe/0TI1u5watwikMTeUqBWSnGjuL9IWo1kHemsqMpMm7YlFz VdepUy5J+aNSA2XwK8MU2760kOEo5dLolzQHxi86CWrHO9lLMXMyTDodVrMoA5IAg4Yz YJtSbtrkNooWztORyvAhcZs9M9O/yuJ5kMSVstflDB/BJ6fjNc5sqTEcz8C2ECLqBz3V GXUw== X-Forwarded-Encrypted: i=1; AJvYcCX/ReTpQTBUJJHmyYeS6i1Don1Iu6DR6DdbtJH4h4/agGjh+Tz3CZfI1mlD7mNpgIwgdMj8IxZ1dS1UnNM=@vger.kernel.org X-Gm-Message-State: AOJu0YzAUkg+0XyKfP99eppNQDfkGGuVr/weqXbxUsfwzZ35n3UAGrNl RIhEqZjUjyHvSeNYeppfpnmXh0pKejYcy8XAZd7pNfJyLRhQr8rDRGE4 X-Gm-Gg: AZuq6aJMtHuXGt5JryLstUs2IfMaIzCSsYsRHwgVUelYl8ysy7R81gRnWuMmsfh92Pj zJnJipExkt8LhteCa/oZKyuz7Ducop0jH8ZTXat5Kpe2+eD6KvWnG8hQAfF0g80Eo1IdRUu2INg 0xDpyR4T7jQfCzO4UyzcOysIzz43mtgMwlv+D3XGAl+fCCGLvkBGxhKXecdRCK71tvDP491HPzZ mGzjxl9iTq/nrSYHGeKW1A78ycuLk46iQ1zHEp+O0wQB5YzXU8zFU9eRNnN/s6k0HN91xYGAxe7 DUU/nQf/x5iL3tuKaZOdll0ZNA4AJUxBOwb23dho+0T6aJCqhyuWi3l8MLXO1kehFs2jGKB2z36 S51TVnE2pg7xzSZPrMhUWT1F0iP5bebHQyx8RpJL1M08d0/sTW0yNvs5ji2mj0Gv9R5tW2suRgE 9shbLp6U7h/vvMfMWt+xSzFRbQj8+mMiekDMvqYPqtdITtJDrThdUW3ZpJVcXF7YvX2HHZeSeGw CnmlTLHcvrLvozO0g== X-Received: by 2002:a05:600c:1c29:b0:483:6d9e:e4f5 with SMTP id 5b1f17b1804b1-483a949e5edmr41113355e9.5.1771666810853; Sat, 21 Feb 2026 01:40:10 -0800 (PST) Received: from jernej-laptop.localnet (86-58-126-118.dynamic.telemach.net. [86.58.126.118]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a31b3d88sm133439895e9.3.2026.02.21.01.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Feb 2026 01:40:10 -0800 (PST) From: Jernej =?UTF-8?B?xaBrcmFiZWM=?= To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Chen-Yu Tsai , Samuel Holland , Richard Genoud Cc: Wentao Liang , Maxime Ripard , Thomas Petazzoni , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Genoud Subject: Re: [PATCH 1/6] mtd: rawnand: sunxi: fix sunxi_nand_ooblayout_free Date: Sat, 21 Feb 2026 10:13:16 +0100 Message-ID: <5967652.DvuYhMxLoT@jernej-laptop> In-Reply-To: <20260220161011.999642-2-richard.genoud@bootlin.com> References: <20260220161011.999642-1-richard.genoud@bootlin.com> <20260220161011.999642-2-richard.genoud@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Dne petek, 20. februar 2026 ob 17:10:06 Srednjeevropski standardni =C4=8Das= je Richard Genoud napisal(a): > The available length is really USER_DATA_LEN - 2 instead of just 2 (the > user data length minus the BBM length) > That doesn't change anything now, but if USER_DATA_LEN changes, it will. s/USER_DATA_LEN/USER_DATA_SZ/ >=20 > Signed-off-by: Richard Genoud If this is really a fix as subject suggest, then Fixes tag is in order. How= ever, this looks more like code refactor as end result is the same. So maybe reword subject? Best regards, Jernej > --- > drivers/mtd/nand/raw/sunxi_nand.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sun= xi_nand.c > index 9dcdc93734cb..c420909b944b 100644 > --- a/drivers/mtd/nand/raw/sunxi_nand.c > +++ b/drivers/mtd/nand/raw/sunxi_nand.c > @@ -1761,12 +1761,12 @@ static int sunxi_nand_ooblayout_free(struct mtd_i= nfo *mtd, int section, > =20 > /* > * The first 2 bytes are used for BB markers, hence we > - * only have 2 bytes available in the first user data > + * only have USER_DATA_SZ - 2 bytes available in the first user data > * section. > */ > if (!section && ecc->engine_type =3D=3D NAND_ECC_ENGINE_TYPE_ON_HOST) { > oobregion->offset =3D 2; > - oobregion->length =3D 2; > + oobregion->length =3D USER_DATA_SZ - 2; > =20 > return 0; > } >=20